diff --git a/.golangci.yml b/.golangci.yml index 9e66c045..a5c43870 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -39,3 +39,4 @@ linters: - unconvert - unparam - unused + - loggercheck diff --git a/api/v1alpha2/jenkins_webhook.go b/api/v1alpha2/jenkins_webhook.go index 63ba9942..2cb18957 100644 --- a/api/v1alpha2/jenkins_webhook.go +++ b/api/v1alpha2/jenkins_webhook.go @@ -269,7 +269,7 @@ func (in *SecurityValidator) download() error { } defer func() { if err := out.Close(); err != nil { - jenkinslog.V(log.VDebug).Info("Failed to close file", err) + jenkinslog.V(log.VDebug).Info("Failed to close file", "error", err) } }() diff --git a/pkg/configuration/user/seedjobs/seedjobs.go b/pkg/configuration/user/seedjobs/seedjobs.go index f7522f67..5b23d0b8 100644 --- a/pkg/configuration/user/seedjobs/seedjobs.go +++ b/pkg/configuration/user/seedjobs/seedjobs.go @@ -344,7 +344,7 @@ func (s *seedJobs) credentialValue(namespace string, seedJob v1alpha2.SeedJob) ( } func (s *seedJobs) getAllSeedJobIDs(jenkins v1alpha2.Jenkins) []string { - var ids []string + ids := make([]string, 0, len(jenkins.Spec.SeedJobs)) for _, seedJob := range jenkins.Spec.SeedJobs { ids = append(ids, seedJob.ID) }