mirror of
https://github.com/GoogleContainerTools/kaniko
synced 2026-10-09 04:45:31 +02:00
Priya Wadhwa
99ab68e7f4
gometalinter is broken @ HEAD, and I looked into why that was. During that process, I remembered that we took the linting scripts from skaffold, and found that in skaffold gometalinter was replaced with GolangCI-Lint: https://github.com/GoogleContainerTools/skaffold/pull/619 The change made linting in skaffold faster, so I figured instead of fixing gometalinter it made more sense to remove it and replace it with GolangCI-Lint for kaniko as well.
103 lines
2.1 KiB
Go
103 lines
2.1 KiB
Go
/*
|
|
Copyright 2018 Google LLC
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
package commands
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/GoogleContainerTools/kaniko/pkg/dockerfile"
|
|
|
|
"github.com/GoogleContainerTools/kaniko/testutil"
|
|
"github.com/google/go-containerregistry/pkg/v1"
|
|
"github.com/moby/buildkit/frontend/dockerfile/instructions"
|
|
)
|
|
|
|
var userTests = []struct {
|
|
user string
|
|
expectedUID string
|
|
shouldError bool
|
|
}{
|
|
{
|
|
user: "root",
|
|
expectedUID: "root",
|
|
shouldError: false,
|
|
},
|
|
{
|
|
user: "0",
|
|
expectedUID: "0",
|
|
shouldError: false,
|
|
},
|
|
{
|
|
user: "fakeUser",
|
|
expectedUID: "",
|
|
shouldError: true,
|
|
},
|
|
{
|
|
user: "root:root",
|
|
expectedUID: "root:root",
|
|
shouldError: false,
|
|
},
|
|
{
|
|
user: "0:root",
|
|
expectedUID: "0:root",
|
|
shouldError: false,
|
|
},
|
|
{
|
|
user: "root:0",
|
|
expectedUID: "root:0",
|
|
shouldError: false,
|
|
},
|
|
{
|
|
user: "0:0",
|
|
expectedUID: "0:0",
|
|
shouldError: false,
|
|
},
|
|
{
|
|
user: "root:fakeGroup",
|
|
expectedUID: "",
|
|
shouldError: true,
|
|
},
|
|
{
|
|
user: "$envuser",
|
|
expectedUID: "root",
|
|
shouldError: false,
|
|
},
|
|
{
|
|
user: "root:$envgroup",
|
|
expectedUID: "root:root",
|
|
shouldError: false,
|
|
},
|
|
}
|
|
|
|
func TestUpdateUser(t *testing.T) {
|
|
for _, test := range userTests {
|
|
cfg := &v1.Config{
|
|
Env: []string{
|
|
"envuser=root",
|
|
"envgroup=root",
|
|
},
|
|
}
|
|
cmd := UserCommand{
|
|
&instructions.UserCommand{
|
|
User: test.user,
|
|
},
|
|
}
|
|
buildArgs := dockerfile.NewBuildArgs([]string{})
|
|
err := cmd.ExecuteCommand(cfg, buildArgs)
|
|
testutil.CheckErrorAndDeepEqual(t, test.shouldError, err, test.expectedUID, cfg.User)
|
|
}
|
|
}
|