mirror of
https://github.com/GoogleContainerTools/kaniko
synced 2026-10-05 23:21:48 +02:00
I improved handling of the .dockerignore file by: 1. Using docker's parser to parse the .dockerignore and using their helper functions to determine if a file should be deleted 2. Copying the Dockerfile we are building to /kaniko/Dockerfile so that if the Dockerfile is specified in .dockerignore it won't be deleted, and if it is specified in the .dockerignore it won't end up in the final image 3. I also improved the integration test to create a temp directory with files to ignore, and updated the .dockerignore to include exclusions (!)
190 lines
5.3 KiB
Go
190 lines
5.3 KiB
Go
/*
|
|
Copyright 2018 Google LLC
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package dockerfile
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"path/filepath"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/GoogleContainerTools/kaniko/pkg/config"
|
|
"github.com/GoogleContainerTools/kaniko/pkg/util"
|
|
"github.com/docker/docker/builder/dockerignore"
|
|
"github.com/moby/buildkit/frontend/dockerfile/instructions"
|
|
"github.com/moby/buildkit/frontend/dockerfile/parser"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
// Stages parses a Dockerfile and returns an array of KanikoStage
|
|
func Stages(opts *config.KanikoOptions) ([]config.KanikoStage, error) {
|
|
d, err := ioutil.ReadFile(opts.DockerfilePath)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, fmt.Sprintf("reading dockerfile at path %s", opts.DockerfilePath))
|
|
}
|
|
stages, err := Parse(d)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "parsing dockerfile")
|
|
}
|
|
targetStage, err := targetStage(stages, opts.Target)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
resolveStages(stages)
|
|
var kanikoStages []config.KanikoStage
|
|
for index, stage := range stages {
|
|
resolvedBaseName, err := util.ResolveEnvironmentReplacement(stage.BaseName, opts.BuildArgs, false)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "resolving base name")
|
|
}
|
|
stage.Name = resolvedBaseName
|
|
kanikoStages = append(kanikoStages, config.KanikoStage{
|
|
Stage: stage,
|
|
BaseImageIndex: baseImageIndex(index, stages),
|
|
BaseImageStoredLocally: (baseImageIndex(index, stages) != -1),
|
|
SaveStage: saveStage(index, stages),
|
|
Final: index == targetStage,
|
|
})
|
|
if index == targetStage {
|
|
break
|
|
}
|
|
}
|
|
return kanikoStages, nil
|
|
}
|
|
|
|
// baseImageIndex returns the index of the stage the current stage is built off
|
|
// returns -1 if the current stage isn't built off a previous stage
|
|
func baseImageIndex(currentStage int, stages []instructions.Stage) int {
|
|
for i, stage := range stages {
|
|
if i > currentStage {
|
|
break
|
|
}
|
|
if stage.Name == stages[currentStage].BaseName {
|
|
return i
|
|
}
|
|
}
|
|
return -1
|
|
}
|
|
|
|
// Parse parses the contents of a Dockerfile and returns a list of commands
|
|
func Parse(b []byte) ([]instructions.Stage, error) {
|
|
p, err := parser.Parse(bytes.NewReader(b))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
stages, _, err := instructions.Parse(p.AST)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return stages, err
|
|
}
|
|
|
|
// targetStage returns the index of the target stage kaniko is trying to build
|
|
func targetStage(stages []instructions.Stage, target string) (int, error) {
|
|
if target == "" {
|
|
return len(stages) - 1, nil
|
|
}
|
|
for i, stage := range stages {
|
|
if stage.Name == target {
|
|
return i, nil
|
|
}
|
|
}
|
|
return -1, fmt.Errorf("%s is not a valid target build stage", target)
|
|
}
|
|
|
|
// resolveStages resolves any calls to previous stages with names to indices
|
|
// Ex. --from=second_stage should be --from=1 for easier processing later on
|
|
func resolveStages(stages []instructions.Stage) {
|
|
nameToIndex := make(map[string]string)
|
|
for i, stage := range stages {
|
|
index := strconv.Itoa(i)
|
|
if stage.Name != index {
|
|
nameToIndex[stage.Name] = index
|
|
}
|
|
for _, cmd := range stage.Commands {
|
|
switch c := cmd.(type) {
|
|
case *instructions.CopyCommand:
|
|
if c.From != "" {
|
|
if val, ok := nameToIndex[c.From]; ok {
|
|
c.From = val
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// ParseCommands parses an array of commands into an array of instructions.Command; used for onbuild
|
|
func ParseCommands(cmdArray []string) ([]instructions.Command, error) {
|
|
var cmds []instructions.Command
|
|
cmdString := strings.Join(cmdArray, "\n")
|
|
ast, err := parser.Parse(strings.NewReader(cmdString))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
for _, child := range ast.AST.Children {
|
|
cmd, err := instructions.ParseCommand(child)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
cmds = append(cmds, cmd)
|
|
}
|
|
return cmds, nil
|
|
}
|
|
|
|
// SaveStage returns true if the current stage will be needed later in the Dockerfile
|
|
func saveStage(index int, stages []instructions.Stage) bool {
|
|
for stageIndex, stage := range stages {
|
|
if stageIndex <= index {
|
|
continue
|
|
}
|
|
if stage.BaseName == stages[index].Name {
|
|
if stage.BaseName != "" {
|
|
return true
|
|
}
|
|
}
|
|
for _, cmd := range stage.Commands {
|
|
switch c := cmd.(type) {
|
|
case *instructions.CopyCommand:
|
|
if c.From == strconv.Itoa(index) {
|
|
return true
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// DockerignoreExists returns true if .dockerignore exists in the source context
|
|
func DockerignoreExists(opts *config.KanikoOptions) bool {
|
|
path := filepath.Join(opts.SrcContext, ".dockerignore")
|
|
return util.FilepathExists(path)
|
|
}
|
|
|
|
// ParseDockerignore returns a list of all paths in .dockerignore
|
|
func ParseDockerignore(opts *config.KanikoOptions) ([]string, error) {
|
|
path := filepath.Join(opts.SrcContext, ".dockerignore")
|
|
contents, err := ioutil.ReadFile(path)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "parsing .dockerignore")
|
|
}
|
|
reader := bytes.NewBuffer(contents)
|
|
return dockerignore.ReadAll(reader)
|
|
}
|