mirror of
https://github.com/GoogleContainerTools/kaniko
synced 2026-09-30 20:59:19 +02:00
Aris Buzachis
61312a95ae
WORKDIR ignores the currently set USER and creates the new directories with the root user ownership. This changes that, by executing a chown after the mkdir if needed, and also handle the case where the provided USER is an uid and the passwd file is not available to resolve to the username. Fixes #2259 Signed-off-by: Aris Buzachis <buzachis.aris@gmail.com> Signed-off-by: Aris Buzachis <buzachis.aris@gmail.com>
95 lines
2.9 KiB
Go
95 lines
2.9 KiB
Go
/*
|
|
Copyright 2018 Google LLC
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package commands
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
|
|
"github.com/GoogleContainerTools/kaniko/pkg/dockerfile"
|
|
"github.com/pkg/errors"
|
|
|
|
"github.com/GoogleContainerTools/kaniko/pkg/util"
|
|
v1 "github.com/google/go-containerregistry/pkg/v1"
|
|
"github.com/moby/buildkit/frontend/dockerfile/instructions"
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
type WorkdirCommand struct {
|
|
BaseCommand
|
|
cmd *instructions.WorkdirCommand
|
|
snapshotFiles []string
|
|
}
|
|
|
|
// For testing
|
|
var mkdirAllWithPermissions = util.MkdirAllWithPermissions
|
|
|
|
func (w *WorkdirCommand) ExecuteCommand(config *v1.Config, buildArgs *dockerfile.BuildArgs) error {
|
|
logrus.Info("Cmd: workdir")
|
|
workdirPath := w.cmd.Path
|
|
replacementEnvs := buildArgs.ReplacementEnvs(config.Env)
|
|
resolvedWorkingDir, err := util.ResolveEnvironmentReplacement(workdirPath, replacementEnvs, true)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if filepath.IsAbs(resolvedWorkingDir) {
|
|
config.WorkingDir = resolvedWorkingDir
|
|
} else {
|
|
if config.WorkingDir != "" {
|
|
config.WorkingDir = filepath.Join(config.WorkingDir, resolvedWorkingDir)
|
|
} else {
|
|
config.WorkingDir = filepath.Join("/", resolvedWorkingDir)
|
|
}
|
|
}
|
|
logrus.Infof("Changed working directory to %s", config.WorkingDir)
|
|
|
|
// Only create and snapshot the dir if it didn't exist already
|
|
w.snapshotFiles = []string{}
|
|
if _, err := os.Stat(config.WorkingDir); os.IsNotExist(err) {
|
|
uid, gid := int64(-1), int64(-1)
|
|
|
|
if config.User != "" {
|
|
logrus.Debugf("Fetching uid and gid for USER '%s'", config.User)
|
|
uid, gid, err = util.GetUserGroup(config.User, replacementEnvs)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "identifying uid and gid for user %s", config.User)
|
|
}
|
|
}
|
|
|
|
logrus.Infof("Creating directory %s with uid %d and gid %d", config.WorkingDir, uid, gid)
|
|
w.snapshotFiles = append(w.snapshotFiles, config.WorkingDir)
|
|
if err := mkdirAllWithPermissions(config.WorkingDir, 0755, uid, gid); err != nil {
|
|
return errors.Wrapf(err, "creating workdir %s", config.WorkingDir)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// FilesToSnapshot returns the workingdir, which should have been created if it didn't already exist
|
|
func (w *WorkdirCommand) FilesToSnapshot() []string {
|
|
return w.snapshotFiles
|
|
}
|
|
|
|
// String returns some information about the command for the image config history
|
|
func (w *WorkdirCommand) String() string {
|
|
return w.cmd.String()
|
|
}
|
|
|
|
func (w *WorkdirCommand) MetadataOnly() bool {
|
|
return false
|
|
}
|