`IsSrcRemoteFileURL` was doing a `http.Get` call to make sure the URL was valid, but not surfacing any errors. Because the error from the http.Get call is not handled, some useful information can be buried. It also means kaniko will download the file twice during a build, once to validate, and once to actually add the file to the image. Removing the http.Get call and validating the URL is valid, and has the correct schema and hostname will stop the double handling, and allow any errors to be surfaced through the error handing in the file download function. Fixes #1590 Signed-off-by: Angus Williams <anguswilliams@gmail.com> |
||
|---|---|---|
| .. | ||
| bucket | ||
| proc | ||
| .editorconfig | ||
| azureblob_util.go | ||
| azureblob_util_test.go | ||
| command_util.go | ||
| command_util_test.go | ||
| fs_util.go | ||
| fs_util_test.go | ||
| gcr_util.go | ||
| gcr_util_test.go | ||
| groupids_cgo.go | ||
| groupids_fallback.go | ||
| syscall_credentials.go | ||
| syscall_credentials_test.go | ||
| tar_util.go | ||
| tar_util_test.go | ||
| transport_util.go | ||
| transport_util_test.go | ||
| util.go | ||
| util_test.go | ||