/* Copyright 2018 Google LLC Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package dockerfile import ( "io/ioutil" "os" "strconv" "testing" "github.com/GoogleContainerTools/kaniko/pkg/config" "github.com/GoogleContainerTools/kaniko/testutil" "github.com/moby/buildkit/frontend/dockerfile/instructions" ) func Test_Stages_ArgValueWithQuotes(t *testing.T) { dockerfile := ` ARG IMAGE="ubuntu:16.04" FROM ${IMAGE} RUN echo hi > /hi FROM scratch AS second COPY --from=0 /hi /hi2 FROM scratch COPY --from=second /hi2 /hi3 ` tmpfile, err := ioutil.TempFile("", "Dockerfile.test") if err != nil { t.Fatal(err) } defer os.Remove(tmpfile.Name()) if _, err := tmpfile.Write([]byte(dockerfile)); err != nil { t.Fatal(err) } if err := tmpfile.Close(); err != nil { t.Fatal(err) } stages, err := Stages(&config.KanikoOptions{DockerfilePath: tmpfile.Name()}) if err != nil { t.Fatal(err) } if len(stages) == 0 { t.Fatal("length of stages expected to be greater than zero, but was zero") } if len(stages[0].MetaArgs) == 0 { t.Fatal("length of stage[0] meta args expected to be greater than zero, but was zero") } expectedVal := "ubuntu:16.04" arg := stages[0].MetaArgs[0] if arg.ValueString() != expectedVal { t.Fatalf("expected stages[0].MetaArgs[0] val to be %s but was %s", expectedVal, arg.ValueString()) } } func Test_stripEnclosingQuotes(t *testing.T) { type testCase struct { name string inArgs []instructions.ArgCommand expected []string success bool } newArgCommand := func(key, val string) instructions.ArgCommand { return instructions.ArgCommand{ KeyValuePairOptional: instructions.KeyValuePairOptional{Key: key, Value: &val}, } } cases := []testCase{{ name: "value with no enclosing quotes", inArgs: []instructions.ArgCommand{newArgCommand("MEOW", "Purr")}, expected: []string{"Purr"}, success: true, }, { name: "value with unmatched leading double quote", inArgs: []instructions.ArgCommand{newArgCommand("MEOW", "\"Purr")}, }, { name: "value with unmatched trailing double quote", inArgs: []instructions.ArgCommand{newArgCommand("MEOW", "Purr\"")}, }, { name: "value with enclosing double quotes", inArgs: []instructions.ArgCommand{newArgCommand("MEOW", "\"mrow\"")}, expected: []string{"mrow"}, success: true, }, { name: "value with unmatched leading single quote", inArgs: []instructions.ArgCommand{newArgCommand("MEOW", "'Purr")}, }, { name: "value with unmatched trailing single quote", inArgs: []instructions.ArgCommand{newArgCommand("MEOW", "Purr'")}, }, { name: "value with enclosing single quotes", inArgs: []instructions.ArgCommand{newArgCommand("MEOW", "'mrow'")}, expected: []string{"mrow"}, success: true, }, { name: "blank value with enclosing double quotes", inArgs: []instructions.ArgCommand{newArgCommand("MEOW", "\"\"")}, expected: []string{""}, success: true, }, { name: "blank value with enclosing single quotes", inArgs: []instructions.ArgCommand{newArgCommand("MEOW", "''")}, expected: []string{""}, success: true, }, { name: "value with escaped, enclosing double quotes", inArgs: []instructions.ArgCommand{newArgCommand("MEOW", `\"Purr\"`)}, expected: []string{`\"Purr\"`}, success: true, }, { name: "value with escaped, enclosing single quotes", inArgs: []instructions.ArgCommand{newArgCommand("MEOW", `\'Purr\'`)}, expected: []string{`\'Purr\'`}, success: true, }, { name: "multiple values enclosed with single quotes", inArgs: []instructions.ArgCommand{ newArgCommand("MEOW", `'Purr'`), newArgCommand("MEW", `'Mrow'`), }, expected: []string{"Purr", "Mrow"}, success: true, }, { name: "no values", success: true, }} for _, test := range cases { t.Run(test.name, func(t *testing.T) { inArgs := test.inArgs expected := test.expected success := test.success out, err := stripEnclosingQuotes(inArgs) if success && err != nil { t.Fatal(err) } if !success && err == nil { t.Fatal("expected an error but none received") } if len(expected) != len(out) { t.Fatalf("Expected %d args but got %d", len(expected), len(out)) } for i := range out { if expected[i] != out[i].ValueString() { t.Errorf( "Expected arg at index %d to equal %v but instead equaled %v", i, expected[i], out[i].ValueString()) } } }) } } func Test_resolveStages(t *testing.T) { dockerfile := ` FROM scratch RUN echo hi > /hi FROM scratch AS second COPY --from=0 /hi /hi2 FROM scratch COPY --from=second /hi2 /hi3 ` stages, _, err := Parse([]byte(dockerfile)) if err != nil { t.Fatal(err) } resolveStages(stages) for index, stage := range stages { if index == 0 { continue } copyCmd := stage.Commands[0].(*instructions.CopyCommand) expectedStage := strconv.Itoa(index - 1) if copyCmd.From != expectedStage { t.Fatalf("unexpected copy command: %s resolved to stage %s, expected %s", copyCmd.String(), copyCmd.From, expectedStage) } } } func Test_targetStage(t *testing.T) { dockerfile := ` FROM scratch RUN echo hi > /hi FROM scratch AS second COPY --from=0 /hi /hi2 FROM scratch COPY --from=second /hi2 /hi3 ` stages, _, err := Parse([]byte(dockerfile)) if err != nil { t.Fatal(err) } tests := []struct { name string target string targetIndex int shouldErr bool }{ { name: "test valid target", target: "second", targetIndex: 1, shouldErr: false, }, { name: "test no target", target: "", targetIndex: 2, shouldErr: false, }, { name: "test invalid target", target: "invalid", targetIndex: -1, shouldErr: true, }, } for _, test := range tests { t.Run(test.name, func(t *testing.T) { target, err := targetStage(stages, test.target) testutil.CheckError(t, test.shouldErr, err) if !test.shouldErr { if target != test.targetIndex { t.Errorf("got incorrect target, expected %d got %d", test.targetIndex, target) } } }) } } func Test_SaveStage(t *testing.T) { tests := []struct { name string index int expected bool }{ { name: "reference stage in later copy command", index: 0, expected: false, }, { name: "reference stage in later from command", index: 1, expected: true, }, { name: "don't reference stage later", index: 2, expected: false, }, { name: "reference current stage in next stage", index: 4, expected: true, }, { name: "from prebuilt stage, and reference current stage in next stage", index: 5, expected: true, }, { name: "final stage", index: 6, expected: false, }, } stages, _, err := Parse([]byte(testutil.Dockerfile)) if err != nil { t.Fatalf("couldn't retrieve stages from Dockerfile: %v", err) } for _, test := range tests { t.Run(test.name, func(t *testing.T) { actual := saveStage(test.index, stages) testutil.CheckErrorAndDeepEqual(t, false, nil, test.expected, actual) }) } } func Test_baseImageIndex(t *testing.T) { tests := []struct { name string currentStage int expected int }{ { name: "stage that is built off of a previous stage", currentStage: 2, expected: 1, }, { name: "another stage that is built off of a previous stage", currentStage: 5, expected: 4, }, { name: "stage that isn't built off of a previous stage", currentStage: 4, expected: -1, }, } stages, _, err := Parse([]byte(testutil.Dockerfile)) if err != nil { t.Fatalf("couldn't retrieve stages from Dockerfile: %v", err) } for _, test := range tests { t.Run(test.name, func(t *testing.T) { actual := baseImageIndex(test.currentStage, stages) if actual != test.expected { t.Fatalf("unexpected result, expected %d got %d", test.expected, actual) } }) } }