Sam Stoelinga
fa94f6b942
Fix #950 integration test failing on go 1.13
...
From Golang 1.13 release notes:
Testing flags are now registered in the new Init function, which is
invoked by the generated main function for the test. As a result,
testing flags are now only registered when running a test binary, and
packages that call flag.Parse during package initialization may cause
tests to fail.
2020-01-07 09:46:25 -08:00
Cole Wippern
bdabd774fc
Update linter and fix errors
...
* disable linters that are now enabled by default in new version
* fix linter errors
2019-12-21 12:27:14 -08:00
Cole Wippern
05447f1eaa
clean up unused code
2019-12-09 13:57:59 -08:00
Cole Wippern
c2645b2207
Fix #897 - only build required docker images
...
Only build the docker images required for the integration tests which
will be executed rather than building all docker images every time.
2019-12-02 13:19:43 -08:00
Cole Wippern
b057776849
Merge pull request #857 from cvgw/u/cgwippern/symlink-bug
...
Resolve symlink targets to abs path before copying
2019-11-22 10:02:58 -08:00
Cole Wippern
1ec2387940
Add integration test for add url with arg
2019-11-15 14:44:39 -08:00
Cole Wippern
8f66e8613f
Add new test for copy to symlink which should fail
2019-11-15 11:23:04 -08:00
Cole Wippern
006b4996cb
Fix quote strip behavior for ARG values
...
* fixes issue 847
* previous implementation did not properly parse blank
values which were enclosed in quotes
2019-11-08 14:28:31 -08:00
Tejal Desai
5bbb40e4f0
Merge pull request #834 from cvgw/u/cgwippern/ISSUE_439_strip_arg_quotes
...
Issue #439 Strip out double quotes in ARG value
2019-11-07 10:54:17 -08:00
Don McCasland
ab7b210ac1
Adding missing integration test file
2019-11-04 09:30:58 -08:00
Don McCasland
5716c44ab8
Merge branch 'master' into bug-742-2
2019-11-04 09:25:25 -08:00
Cole Wippern
ec2e7705c8
Issue #439 add additional tests for quotes
...
Add additional tests to ensure that ARG values with quotes
are handled properly
2019-10-25 16:08:57 -07:00
Cole Wippern
79649a1614
Issue #439 double quotes in ARG value
...
* Strip out double quotes enclosing ARG value after parsing
dockerfile
2019-10-24 16:30:25 -07:00
Don McCasland
e5da55d4cd
Adding integration test
2019-10-08 07:42:09 -07:00
Tejal Desai
9eb4a1c1ff
Merge pull request #801 from victornoel/776-dockerignore-relative
...
Support Dockerfile.dockerignore
2019-10-04 01:56:40 -07:00
Victor Noel
ff7abba47b
Fix integration tests for #776
2019-10-04 10:31:40 +02:00
Tejal Desai
22188595f0
Merge pull request #768 from N4rm0/fix-envar-replacement-for-url
...
Fix #691 - ADD does not understand ENV variables
2019-10-04 01:17:22 -07:00
Victor Noel
db12a77e6c
Fix #776
2019-10-03 17:53:14 +02:00
Monard Vong
a63a809e98
fix tests
2019-09-22 00:26:35 +02:00
Monard Vong
dfbe9cf7f8
Add integration test
2019-09-22 00:12:54 +02:00
Hugues Alary
4327e9ba24
Resolve relative paths to absolute paths in command line arguments
...
The executor accepts a few arguments dockerfile, context, cache-dir and
digest-file that all represent paths. This commits allows those paths to
be relative to the working directory of the executor.
Fixes #732 #731 #675
2019-08-27 21:06:26 +00:00
Tejal Desai
4b422ee5dd
Merge pull request #677 from priyawadhwa/git
...
Improve git buildcontext integration test
2019-08-23 15:03:27 -07:00
Carlos Alexandro Becker
46a738f2b2
fix: integration tests
...
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2019-06-22 12:18:42 -03:00
Carlos Alexandro Becker
f0b9ad3a57
feat: support specifying branch for cloning
...
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2019-06-22 11:45:07 -03:00
Priya Wadhwa
e2a4098b8e
fixed dockerfile path
2019-06-19 11:06:59 -07:00
Priya Wadhwa
317d1b7017
Improve git buildcontext integration test
...
Build a dockerfile that will copy the LICENSE from the kaniko github repository into the image to make sure the git buildcontext works as expected.
2019-05-23 16:12:20 +02:00
Kartik Verma
f137f81884
Resolved Merge Conflicts
...
Signed-off-by: Kartik Verma <vkartik97@gmail.com>
2019-05-21 01:52:14 +05:30
Johannes 'fish' Ziemke
8c732f6f52
Fix kaniko caching ( #639 )
...
* Revert "Change cache key calculation to be more reproducible. (#525 )"
This reverts commit 1ffae47fdd .
* Add logging of composition key back
* Do not include build args in cache key
This should be save, given that the commands will have the args included
when the cache key gets built.
2019-05-10 09:57:03 -05:00
Kartik Verma
fa2a2c803b
Updated PR Branch with master
2019-04-09 02:18:28 +05:30
dlorenc
c8fabdf6e4
Fix arg handling for multi-stage images in COPY instructions. ( #621 )
2019-03-22 12:24:43 -05:00
Daisuke Taniwaki
1bf4421047
Fix parent directory permissions ( #619 )
...
* Add parent directories of adding files
* Add integration Dockerfile to test parent directory permissions
* Remove unnecessary helper method
* Use a file on the internet for integration Dockerfile
2019-03-19 12:40:15 -05:00
Daisuke Taniwaki
28bfb75a31
Fix file mode bug ( #618 )
...
* Fix file mode
* Add Dockerfile for special file permission test
2019-03-18 13:28:24 -05:00
dlorenc
9912ccbf8d
Fix USER handling. There were two issues: ( #600 )
...
- We were validating usernames/groupnames existed in etc/passwd. Docker does not do this
- We were incorrectly caching USER commands. This was fixed automatically by fixing the first part.
2019-03-07 07:05:24 -08:00
dlorenc
2abe109eb2
Environment variables should be replaced in URLs in ADD commands. ( #580 )
...
We were previously explicitly skipping this for some reason, but Docker
seems to expand these in URLs so we should too.
2019-02-25 10:42:34 -06:00
Priya Wadhwa
8b459b57aa
Test git buildcontext
2019-02-21 13:03:02 -08:00
Priya Wadhwa
3da2fdf2d0
Merge branch 'issue#269' of https://github.com/vkartik97/kaniko into vkartik97-issue#269
2019-02-21 11:55:51 -08:00
dlorenc
9047ccf7cc
This fixes a bug in the interaction between volumes in base images ( #555 )
...
and our snapshot optimizations.
If a previous base image has a volume, the directory is added to the
list of files to snapshot. That directory may not actually exist in the image.
2019-02-08 14:40:37 -06:00
dlorenc
e14b660947
Fix a bug in volume handling for multi-stage images. ( #554 )
...
We were previously not resetting the whitelist between stages, this caused issues with volumes.
2019-02-07 09:01:49 -06:00
dlorenc
9f65174cb8
Generate the config.json from gcloud rather than relying on a hardcoded one. ( #551 )
...
marketplace.gcr.io now requires auth, but our credential helper doesn't know that.
2019-02-04 16:53:59 -06:00
Kartik Verma
2f8bdd99b7
Resolved Merge Conflicts
2019-02-02 11:28:40 +05:30
Kartik Verma
785691ecc2
Made changes as per review
2019-02-02 11:18:54 +05:30
dlorenc
c2514305ef
Fix a bug in snapshotting with multi-stage images. ( #546 )
...
We previously had an optimization that would skip snapshotting mutli-stage images
when in an intermediate stage, until the very end.
This conflicted with another optimization to avoid snapshotting when no files had changed.
2019-01-30 13:57:02 -06:00
dlorenc
e3bf9fb062
Only log the hour of the benchmark run. ( #544 )
...
Also combine all files into one directory.
2019-01-28 15:53:13 -06:00
dlorenc
4c960709df
Actually fix the paths for benchmark uploading during integration test runs. ( #543 )
2019-01-28 12:52:27 -06:00
dlorenc
1ffae47fdd
Change cache key calculation to be more reproducible. ( #525 )
...
Before we were using the full image digest, but that contains a timestamp. Now
we only use the layers themselves and the image config (env vars, etc.).
Also fix a bug in unpacking the layers themselves. mtimes can change during unpacking,
so set them all once at the end.
2019-01-23 13:46:12 -06:00
dlorenc
a493035287
Log the output from uploading files to GCS. ( #541 )
2019-01-23 12:08:04 -06:00
dlorenc
a4b47a4992
Fix the time format we use to upload to GCS. ( #538 )
2019-01-22 14:23:28 -06:00
dlorenc
b0e7c0e8cd
Upload benchmarks to GCS. ( #523 )
2019-01-17 16:10:14 -05:00
dlorenc
6e7c91a1cb
Deflake the daemon test ( #532 )
...
There's a race condition here where sometimes we get a layer and othertimes we don't.
2019-01-17 15:30:08 -05:00
dlorenc
48f9968e5b
Move the benchmark files from /workspace to their own mounted volume in tests. ( #527 )
...
If we don't do this, they can end up in the built images causing test failures.
2019-01-11 16:04:16 -07:00