9f76932171
Update GowalkDir dependency to pick up fixes. Added default 90 min timeout for walking FS. Override it with environment variable. Add slowjam to kaniko pod ( #1530 )
2020-12-21 22:40:37 -08:00
dde98a8e73
feat(warmer): Warmer now supports all registry-related flags ( #1499 )
...
which means we can now:
- set up one or more mirrors
- set up registries certificates
- skip TLS verify
- use plain HTTP
using the same set of flags that are defined for the executor
2020-12-10 22:55:43 -08:00
0c1a1a690a
Fix COPY with --chown command ( #1477 )
...
* Fix COPY with --chown command
* fix linters
2020-12-08 16:12:04 -08:00
9ed158c1f6
Fixes #1469 : Remove file that matches with the directory path ( #1478 )
...
* Fixes #1469 : Remove file that matches with the directory path
* Fixes #1469 : Remove file that matches with the directory path
* Fixes #1469 : Fix lint errors
* Fixes #1469 : Fix lint errors
* Fixes #1469 : Fix lint errors
* Fixes #1469 : Reduce conditional depth
* Fixes #1469 : Remove an additional line
Co-authored-by: anugu-chegg <anugu.s@chegg.com>
2020-11-05 08:48:55 -08:00
5f4e2f1366
Fix .dockerignore for build context copies in later stages ( #1447 )
...
* Extend .dockerignore integration test with copies in later stages
.dockerignore should continue to apply when copying from the build context in later stages, but it currently doesn't
* Replace excluded global with passed along FileContext struct
This new FileContext struct allows much cleaner handling of context specific file exclusions.
The global excluded file state is no longer needed.
Additionally this also fixes the issue where excluded files aren't being applied for build context copies in later build stages.
2020-10-08 12:47:14 -07:00
0a0b4f1583
Add func to append to ignorelist.
...
This allows those using Kaniko as a library to add ignored dirs and
files without needs to modify /proc/self/mountinfo or doing other
strange things with mount -t tmpfs
2020-08-26 08:30:42 -05:00
11024f258d
new implementation for run
2020-08-13 13:43:07 -07:00
999365f5f9
fixup! fixup! add should fail on 40x
...
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-06-20 10:42:59 +02:00
ca23ae441e
add should fail on 40x
...
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-06-20 09:49:11 +02:00
4ac51ef515
merge
2020-06-06 20:17:17 -07:00
58276274e8
better improvements
2020-06-05 23:44:17 -07:00
bea020f34f
add another snapshotter
2020-06-05 02:54:32 -07:00
ec3ca84ad9
add another redo snapshotter
2020-06-04 22:02:13 -07:00
994a412d0b
some more renames
2020-06-02 16:08:46 -07:00
cbf3073fda
rename whitelist to ignorelist
2020-06-02 15:56:27 -07:00
2f6090dcd7
Remove use of DefaultTransport
...
Using DefaultTransport and manipulating its tls configuration may lead to unexpected behaviour
2020-05-20 11:43:13 +02:00
3f3c19a545
Merge pull request #1234 from tejal29/fix_copy_from
...
Apply dockefile exclude only for first stage
2020-05-19 15:40:51 -07:00
d9a6bbe956
add tests
2020-05-06 12:11:03 -07:00
23ac909b2d
Revert "small perf optimizing. Only remove whiteout path if it needs to be included in the tar"
...
This reverts commit 67db51810b
2020-05-06 12:08:44 -07:00
113c2397ea
Update comment.
2020-05-05 22:27:28 -07:00
5e275d9824
Apply dockefile exclude only for first stage
2020-05-05 21:45:36 -07:00
e32715ef55
Merge pull request #1164 from tstromberg/add-groups
...
Add secondary group impersonation w/ !cgo support
2020-05-03 22:00:36 -07:00
cb14b65e08
fix boilerplate
2020-05-03 21:10:55 -07:00
5cbf34b67e
Update pkg/util/groupids_fallback.go
2020-05-03 21:04:22 -07:00
7eb2458ba4
Merge pull request #1166 from gilbsgilbs/snapshot-directories
...
Always add parent directories of files to snapshots.
2020-05-01 10:25:25 -07:00
8a780be748
Merge pull request #1139 from JordanGoasdoue/allow-injecting-context-tar-gz
...
feat: allow injecting through stdin tar.gz on kaniko
2020-05-01 10:24:05 -07:00
6b44ed4477
calculateDepdencies on a copy of envvars
2020-04-04 23:27:15 +03:00
14170aa455
Fix sorting of parent directories.
...
This refactoring reversed the order of the "ParentDirectories" function: ffc372a63b (diff-d36eb675aa49a7b471e3a2be77005b18R465)
2020-03-31 20:18:24 +02:00
fd8a2d6dd8
Merge branch 'master' into snapshot-directories
2020-03-31 14:25:04 +02:00
0fe0a64113
Merge pull request #1168 from PhoenixMage/32bit-overflow-fix
...
32bit overflow fix
2020-03-30 10:23:31 -07:00
8dc64549a1
Merge pull request #1155 from tejal29/fix_multi_stage_symlinks
...
Refactor Kaniko to test across multistages
2020-03-30 10:21:51 -07:00
aa6a3de316
Fix 32bit overflow
...
math.UaxUint32 will actually overflow on a 32 bit platform (tested on armv7)
This will resolve that issue.
2020-03-30 23:37:34 +11:00
e5585fded8
Always add parent directories of files to snapshots.
...
During a snapshot, when a file changed and not its parent directories,
the parent directories weren't added to the layer. This is inconsistent
with Docker's behavior which always add parent directories to the layer.
In some edge-cases, it could lead to problems with docker considering
that parent directories where owned by root in forthcoming layers
although they shouldn't (see #1163 ).
Also, Docker seems to be POSIX compliant regarding the name of
directories in the archive, which always have a slash appended. This
commit also fixes this.
Fixes #1163
2020-03-29 18:25:37 +02:00
a6504769e3
Add secondary group impersonation w/ !cgo support
2020-03-28 22:01:20 -07:00
caaf6c8adf
fix tests
2020-03-24 10:50:59 -07:00
5da32d3f18
Merge pull request #1147 from tejal29/small_perf
...
small perf optimizing. Only remove whiteout path if it needs to be included in base image
2020-03-23 18:12:39 -07:00
ffc372a63b
refactor to add unit tests
2020-03-23 17:48:49 -07:00
d08a767454
feat: allow injecting through stdin tar.gz on kaniko
2020-03-18 12:29:49 +01:00
67db51810b
small perf optimizing. Only remove whiteout path if it needs to be included in the tar
2020-03-18 00:43:55 -07:00
3ff2ee3ba5
copy: unit test for chown
...
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-03-17 15:19:00 +01:00
c136f886a9
Add support to --chown flag to ADD command
2020-03-14 16:24:40 +02:00
9592f2640f
more tests similar to docker cp
2020-03-09 15:54:35 -07:00
2181c5e6f5
create correct link across Multistage builds
2020-03-07 11:28:16 -08:00
c523c691eb
revert back to old 0.17.1 behavior
2020-03-06 23:48:31 -08:00
6c14d202a3
better error wrapping and add more tests for copy
2020-03-06 17:18:36 -08:00
b4b70d040a
wip
2020-03-06 13:08:02 -08:00
3cc8aa2a9c
fix resolve link for dirs with trailing /
2020-03-06 09:38:00 -08:00
dd5d2e6661
ignore errors while deleting
2020-02-28 04:48:22 -08:00
17f808da8a
check for filepath.Walk error everywhere
2020-02-28 04:23:27 -08:00
a1af057f99
Merge pull request #1069 from cvgw/u/cgwippern/implement-filepath-resolver
...
Resolve filepaths before scanning for changes
2020-02-25 00:19:38 -08:00
60e2187d85
Fix #1020 os.Chtimes invalid arg
...
The zero value of time.Time is not a valid argument to os.Chtimes
because of the syscall that os.Chtimes calls. Instead we update the zero
value of time.Time to the zero value of Unix Epoch
2020-02-24 08:29:19 -08:00
a675ad998a
Resolve filepaths before scanning for changes
2020-02-20 09:45:44 -08:00
474fdcf68d
image: fix registry mirror setup
...
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-02-16 11:41:51 +01:00
edc4eb33f4
Merge remote-tracking branch 'origin/master' into registry-mirror
2020-02-16 09:28:54 +01:00
2716557379
Merge pull request #1032 from tinkerborg/consistent-sha
...
Ensure image SHA stays consistent when layer contents haven't changed
2020-02-13 11:22:27 -08:00
8b69a13641
fix commut
2020-02-06 15:37:47 -08:00
9dd050b892
set log format using a flag
2020-02-07 00:05:59 +02:00
82bce229bd
omit uname/gname in tar headers
...
When using cache, the rootfs may not have been extracted. This prevents uname/gname from resolving
as there is no /etc/password or /etc/group. This makes this layer unnecessarily differ from
a cached layer which does contain this information. Omitting these should be consistent with Docker's
behavior.
2020-02-06 13:36:26 -05:00
9e17ffd6cb
fix unit tests
2020-02-05 15:59:07 -08:00
2cd68d2e2f
fix flake in copy symlink
2020-02-05 14:40:52 -08:00
2e95c3040c
update initialWhitelist instead of whitelist
2020-02-04 11:06:26 -08:00
31f626cb22
initilize group to 0
2020-02-03 22:15:56 -08:00
56125ff464
Rebase from master with some changes
2020-02-03 14:57:10 -08:00
ac4c80d241
Refactor code, introduce constants for uid/gid = -1
2020-02-03 14:56:23 -08:00
517cb50278
Add Unit test for GetUIDAndGIDFromString
2020-02-03 14:56:23 -08:00
e3b5a7b85d
Support COPY --chown flag ( Closes : #9 )
2020-02-03 14:56:23 -08:00
6894be442f
remove duplicate code
2020-02-01 15:19:36 -08:00
956495784e
fix group string being always set to uid in case a user has a gid set
2020-02-01 15:19:36 -08:00
0e833e4643
fix test
2020-02-01 09:29:18 -08:00
5a4a6c4a17
fix test flake
2020-01-31 15:23:38 -08:00
3f73230884
Merge pull request #1000 from tejal29/769
...
whitelist /tmp/apt-key-gpghome.* directory
2020-01-31 10:50:26 -08:00
47ab3fe997
Merge branch 'master' into registry-mirror
2020-01-29 11:42:06 -08:00
8bdcb4f544
Merge pull request #854 from WanzenBug/ignored-files-invalidate-cache
...
Fix caching to respect .dockerignore
2020-01-29 11:32:43 -08:00
65cd9124d1
Merge pull request #957 from antechrestos/fix/scopes_asked_to_remote_registry
...
Upgrade go-containerregistry third-party library
2020-01-28 16:00:21 -08:00
8b991f6baf
Add falg to --whitelist-var-run set to true to preserver default kaniko behaviour of /var/run ignored. Set it to false to add /var/run in destination directory
2020-01-28 10:52:36 -08:00
d49c198c90
Revert "add option additonal-whitelist"
...
This reverts commit 72bfed1850
2020-01-28 08:52:36 -08:00
c8b19894bb
Revert "additional-whitelist"
...
This reverts commit ac8e123815
2020-01-28 08:52:29 -08:00
0529579db7
Merge pull request #971 from tejal29/915
...
Fix Symlinks not being copied across stages
2020-01-27 10:58:49 -08:00
03b8922ede
Upgrade dependency to go-containerregistry third-party library
...
By doing so it will fix issues met when mixing source/remote registry
Close #808
2020-01-26 18:55:52 +01:00
e0322042c7
use filepath.Match instead of regex
2020-01-24 22:12:37 -08:00
5951d9b0ee
add /tmp/apt-key to whitelist for Dockerfiles which use command
2020-01-24 15:54:44 -08:00
ac8e123815
additional-whitelist
...
* update readme
* improve test
* change default
2020-01-24 10:22:20 -08:00
72bfed1850
add option additonal-whitelist
...
Add a new option additonal-whitelist which defaults
to a single entry, "/var/run". This will allow users to
remove "/var/run" from the whitelist or retain the current
behavior with no change.
2020-01-23 16:50:33 -08:00
123dcaf83e
Fix caching to respect .dockerignore
...
Previously kaniko would compute the cache key for any copy command by computing
the combined hash of all files in a directory, even if they were listed
as ignored.
With this change, the cache key creation was updated to be aware of ignored
files.
Related issues:
* https://github.com/GoogleContainerTools/kaniko/issues/594
2020-01-23 15:37:37 -08:00
a2aae6274d
Merge pull request #973 from cvgw/u/cgwippern/fix-issue-704
...
Fix issue #704
2020-01-23 13:00:34 -08:00
bb129e9c88
code review comments
2020-01-22 16:27:06 -08:00
b271eb8ab9
fix linter
2020-01-22 15:39:03 -08:00
478205e5ca
fix adding symlinks to FS which do not exists
2020-01-22 15:27:01 -08:00
f1f7297478
fix tests
2020-01-22 11:47:10 -08:00
da7e9928e4
Fix Symlinks not being copies across stages
2020-01-22 11:47:10 -08:00
6a6c547811
Merge pull request #980 from PhoenixMage/PR646_rebase_fix
...
Prefer platform that is currently running for pulling remote images and kaniko binary Makefile target
2020-01-21 16:26:00 -08:00
76f0bf44e5
fix hack linter
2020-01-21 15:22:49 -08:00
d362359314
Merge pull request #981 from cvgw/u/cgwippern/fix-issue-940
...
Fix #940 set modtime when extracting
2020-01-21 09:59:22 -08:00
b1970a3584
Merge pull request #792 from loganprice/FixAddTar
...
Fix Ability for ADD to unTar a file
2020-01-21 09:55:25 -08:00
b9b61e2a12
Merge pull request #943 from shortstories/bugfix/copy-with-symlink
...
Fix #942 COPY or ADD to symlink destination breaks image
2020-01-20 20:55:35 -08:00
4e8bdb3947
Fix #940 set modtime when extracting
...
Certain utilities like Apt depend on modtime
for certain files. Kaniko was not setting modtime when
extracting files and so this broke things like apt.
Kaniko now sets the file mod time to the value from the tar
header.
2020-01-20 09:11:44 -08:00
ed22afc19b
Rebase fix for PR #646
...
I needed this for my arm64 k8s cluster. I have zero Go experience but
enough experience with other things to fix the rebase (I think!). This
patch is working fine on my cluster.
2020-01-20 13:43:45 +11:00
e26bd672f1
fixup! Merge remote-tracking branch 'origin/master' into registry-mirror
...
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-01-18 09:36:22 +01:00
140879fadd
Merge remote-tracking branch 'origin/master' into registry-mirror
2020-01-18 09:35:56 +01:00
96093359c1
rename mock pkg for lint
2020-01-17 14:59:14 -08:00
Tejal Desai
Vincent Behar
Sladyn
Shashank
Tinjo Schöni
Joe Kutner
Yoan Blanc
Tejal Desai
Ben Einaudi
Dani Raznikov
Gilbert Gilb's
PhoenixMage
Thomas Stromberg
Jordan Goasdoué
cvgw
Or Sela
tinkerborg
xanonid
Cole Wippern
Moritz Wanzenböck
Anthony Davies