Tejal Desai
1990cb76e9
change repo string to just string
2020-09-09 09:09:19 -07:00
Jon Johnson
c42881410c
Add pkg.dev to automagic config file population
...
Kaniko currently does config file setup for GCR such that pushing to GCR
automagically works. This change does the same for pkg.dev:
https://cloud.google.com/artifact-registry
This also tightens up the hostname check to ensure we don't send
credentials to a registry that happens to contain "gcr.io".
2020-06-23 11:23:07 -07:00
Tejal Desai
98a2ee2e34
intoduce delay
2020-06-06 20:52:58 -07:00
Tejal Desai
07cdfcf091
fix tests
2020-06-06 20:28:04 -07:00
Tejal Desai
4ac51ef515
merge
2020-06-06 20:17:17 -07:00
Tejal Desai
c85d64c8ae
better shdTakeSnapshot
2020-06-06 19:49:34 -07:00
Tejal Desai
b7462742c1
add deletion logic
2020-06-06 02:05:45 -07:00
Tejal Desai
58276274e8
better improvements
2020-06-05 23:44:17 -07:00
Tejal Desai
43338d4b2f
add a new run command along with a new flag
2020-06-05 19:53:16 -07:00
Tejal Desai
ec3ca84ad9
add another redo snapshotter
2020-06-04 22:02:13 -07:00
Tejal Desai
cbf3073fda
rename whitelist to ignorelist
2020-06-02 15:56:27 -07:00
Ben Einaudi
2f6090dcd7
Remove use of DefaultTransport
...
Using DefaultTransport and manipulating its tls configuration may lead to unexpected behaviour
2020-05-20 11:43:13 +02:00
Tejal Desai
3f3c19a545
Merge pull request #1234 from tejal29/fix_copy_from
...
Apply dockefile exclude only for first stage
2020-05-19 15:40:51 -07:00
Tejal Desai
da5c420ee9
use a mock
2020-05-19 15:05:46 -07:00
Mitchell Friedman
6978fab45c
Add retries to image push.
...
This uses the default provided retry transport by
go-containerregistry as this originally had no retries
built in.
This is useful to avoid intermittent failures of image
registries when returning a retryable status code.
2020-05-08 14:18:43 +01:00
Tejal Desai
c71deae38c
remove dedupes
2020-05-07 16:37:17 -07:00
David Dooling
8bfd370ef9
Provide full path to Docker config file
...
Add tests. The tests assume a POSIX file system, but it seems many
other tests assume Linux, so perhaps this is not a problem, or at
least does not add a new problem.
Fixes #1235
2020-05-06 10:02:47 -05:00
Tejal Desai
5e275d9824
Apply dockefile exclude only for first stage
2020-05-05 21:45:36 -07:00
David Dooling
0871dfd6ab
Use DOCKER_CONFIG for docker config location
...
If the DOCKER_CONFIG environment variable is set, use it when
determining if the Docker config file exists. Fall back to kaniko
default if it the DOCKER_CONFIG environment variable is not set.
Fixes #1228
2020-05-04 16:46:50 -05:00
Jordan Goasdoue
a9c7839491
fix: stages are now resolved correctly if skip-unused
2020-05-04 18:38:18 +02:00
Tejal Desai
ee097f9b70
fix unit tests
2020-05-03 22:01:50 -07:00
Tejal Desai
d37896b94f
Merge branch 'master' into experiment
2020-05-03 21:02:41 -07:00
Tejal Desai
a2af3272cf
Merge pull request #1192 from tp-tc/snapshot-maintainers
...
Handle `MAINTAINERS` when passing `--single-snapshot`.
2020-05-03 20:45:48 -07:00
Tejal Desai
5090baafda
fix single snapshot
2020-05-03 20:23:07 -07:00
Tejal Desai
db7687dbce
wip
2020-05-03 18:37:45 -07:00
Tejal Desai
75864d5c85
flip the flag
2020-05-01 23:41:06 -07:00
Tejal Desai
7d32139a13
fix a bug where file check nil is insufficient
2020-05-01 22:38:14 -07:00
Tejal Desai
32e3336d4c
add a new method to indicate if the command provides files to snapshot
2020-05-01 15:50:46 -07:00
Tejal Desai
6c627645ad
Merge pull request #1194 from tp-tc/greedy-cache-substitution
...
Don't generate cache key, if not caching builds.
2020-05-01 10:21:44 -07:00
Tejal Desai
2e1ca5f19d
remove log added for debugging
2020-05-01 09:40:39 -07:00
Ben Einaudi
d763b7e961
fix previous name checking in 'executor.build.fetchExtraStages'
2020-05-01 16:45:01 +02:00
Tejal Desai
8fb17f60d9
Defer initial snapshot. Remove ReadSuccess()
2020-04-30 13:25:22 -07:00
Tom Prince
c520218cec
Don't generate cache key, if not caching builds.
...
The cache key generation does environment subsitution in places that running
the commands doesn't. This causes issues if a command uses complex shell
substitutions. The cache key is generated even if caching isn't enabled.
This disables the cache key generation if caching is not enabled. This doesn't
fix the underlying issue, but limits it to when the cache is being used.
2020-04-13 16:50:13 -06:00
Tom Prince
484d03550c
Handle `MAINTAINERS` when passing `--single-snapshot`.
2020-04-13 15:54:27 -06:00
Dani Raznikov
f720c817c7
add unit tests
2020-04-12 20:17:40 +03:00
Dani Raznikov
961e634366
calculate dependency for onbuild
2020-04-10 18:49:34 +03:00
Dani Raznikov
70eb7ebcfa
suport multistage onbuild
2020-04-10 18:30:25 +03:00
Dani Raznikov
3ab6524fe5
optimize: don't parse Dockerfile twice and just reuse stages
2020-04-03 18:53:22 +03:00
Dani Raznikov
a3ce1cebf3
optimize: don't parse Dockerfile twice and just reuse stages
2020-04-03 17:39:59 +03:00
Tejal Desai
8dc64549a1
Merge pull request #1155 from tejal29/fix_multi_stage_symlinks
...
Refactor Kaniko to test across multistages
2020-03-30 10:21:51 -07:00
Tejal Desai
340ca79fbb
lint
2020-03-25 11:01:12 -07:00
Tejal Desai
1978f1e08e
Merge pull request #1130 from Vlatombe/set_image_platform
...
Set image platform for any build
2020-03-25 10:10:41 -07:00
Tejal Desai
9567b755dd
fix unit tests
2020-03-25 10:09:33 -07:00
Tejal Desai
2ea28fc7f5
revert back to previous file to save logic
2020-03-25 09:43:59 -07:00
Tejal Desai
caaf6c8adf
fix tests
2020-03-24 10:50:59 -07:00
Sam Stoelinga
1b662e7834
Merge pull request #1140 from samos123/fix-1122-public-gcr
...
Add ability to use public GCR repos without being authenticated
2020-03-24 10:31:58 -07:00
Vincent Latombe
336bcd3a9a
Merge branch 'master' into set_image_platform
2020-03-24 09:51:11 +01:00
Tejal Desai
ffc372a63b
refactor to add unit tests
2020-03-23 17:48:49 -07:00
Sam Stoelinga
1fb1eddd8c
Test: Remove DockerConf after CheckPushPermission
2020-03-23 10:51:09 -07:00
Sam Stoelinga
c2393df7c3
Cleanup push_test CheckPushPermission unit tests
2020-03-22 17:11:08 -07:00
Sam Stoelinga
c56f16b163
Create constant for Docker conf location
2020-03-21 16:45:04 -07:00
Sam Stoelinga
8518b37ca1
Add unit tests for CheckPushPermissions
2020-03-21 16:15:34 -07:00
Tejal Desai
0302e5150c
Merge pull request #1085 from tejal29/rm_buildargs_from_cache_key
...
remove build args from composite key and replace all build args
2020-03-17 16:02:59 -07:00
Sam Stoelinga
66268690b3
Add comments
2020-03-17 09:11:50 -07:00
Sam Stoelinga
8a020010b7
Add ability to use public GCR image
...
Kaniko by default used to configure the GCR credential helper however
this caused Kaniko to fail when trying to use a base image from a public
GCR image. This patch makes it possible to use public GCR images as base
image when using docker even when you're not authenticated to GCR.
Co-authored-by: Nate Williams <nate.williams@files.com>
2020-03-17 09:09:41 -07:00
Tejal Desai
32decf5798
Merge pull request #1075 from greut/label-flag
...
executor: add --label flag
2020-03-12 13:47:01 -07:00
Tejal Desai
18de5d6d2d
Merge pull request #1037 from antechrestos/feature/add_option_to_import_registry_certificate
...
Allow user to provide registry certificate
2020-03-12 12:56:40 -07:00
Vincent Latombe
4d26c1f51e
Set OS/ARCH when assembling image
2020-03-12 10:41:32 +01:00
Ben Einaudi
b73c2c10c8
Allow user to provide registry certificate
...
Fixes #1100
Fixes #1101
2020-03-08 18:17:50 +01:00
Yoan Blanc
53326fa0bf
executor: add --label flag
...
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-03-07 18:17:26 +01:00
Tejal Desai
6c14d202a3
better error wrapping and add more tests for copy
2020-03-06 17:18:36 -08:00
Tejal Desai
3cc8aa2a9c
fix resolve link for dirs with trailing /
2020-03-06 09:38:00 -08:00
Tejal Desai
579ec52a30
add more tests for stageBuilder_build
2020-03-04 17:04:42 -08:00
Tejal Desai
b9f4c4bab5
add more tests for stageBuilder_build
2020-03-04 16:57:26 -08:00
Tejal Desai
ae5a7bf158
fix tests
2020-02-28 02:53:42 -08:00
Tejal Desai
58c0d47fa6
fix npe
2020-02-28 02:44:43 -08:00
Tejal Desai
2ba7d25090
remove build args from composite key and replace all build args before adding command to the cache
2020-02-28 01:51:31 -08:00
Tejal Desai
a17ad8e8e8
Merge pull request #882 from cvgw/u/cvgw/reuse-cached-layer
...
Do not recompute layers retrieved from cache
2020-02-07 13:37:39 -08:00
Tejal Desai
2cd68d2e2f
fix flake in copy symlink
2020-02-05 14:40:52 -08:00
Tejal Desai
8bdcb4f544
Merge pull request #854 from WanzenBug/ignored-files-invalidate-cache
...
Fix caching to respect .dockerignore
2020-01-29 11:32:43 -08:00
Cole Wippern
65cd9124d1
Merge pull request #957 from antechrestos/fix/scopes_asked_to_remote_registry
...
Upgrade go-containerregistry third-party library
2020-01-28 16:00:21 -08:00
Ben Einaudi
03b8922ede
Upgrade dependency to go-containerregistry third-party library
...
By doing so it will fix issues met when mixing source/remote registry
Close #808
2020-01-26 18:55:52 +01:00
Moritz Wanzenböck
bab1c170e8
fix skipping ignored directories if they have whitelisted content
2020-01-24 22:27:56 +01:00
Cole Wippern
cd9be5d513
reuse cached layer
2020-01-23 16:48:26 -08:00
Cole Wippern
782e4916b6
update build and composite cache tests
2020-01-23 15:37:38 -08:00
Moritz Wanzenböck
ef692e55f3
composite_cache: add unit tests
...
Add unit tests that check the behaviour of CompositeCache
on adding filesytem resources. It checks that
* 2 identical directory trees produces the same hash
* an extra file produces a different hash
* an extra directry produces a different hash
* an extra file that is excluded does not alter the hash
* an extra directory that is excluded does not alter the hash
2020-01-23 15:37:37 -08:00
Moritz Wanzenböck
123dcaf83e
Fix caching to respect .dockerignore
...
Previously kaniko would compute the cache key for any copy command by computing
the combined hash of all files in a directory, even if they were listed
as ignored.
With this change, the cache key creation was updated to be aware of ignored
files.
Related issues:
* https://github.com/GoogleContainerTools/kaniko/issues/594
2020-01-23 15:37:37 -08:00
Tejal Desai
79d226ade0
refactor
2020-01-22 16:32:46 -08:00
Tejal Desai
478205e5ca
fix adding symlinks to FS which do not exists
2020-01-22 15:27:01 -08:00
Tejal Desai
da7e9928e4
Fix Symlinks not being copies across stages
2020-01-22 11:47:10 -08:00
Nao YONASHIRO
2599c0c69b
docs: fix wrong document
2019-12-21 14:42:58 -08:00
Cole Wippern
9e9b8a6e71
Fix #899 cached copy results in inconsistent key
...
* Update cached copy command to return the same result for
files used from context so that cached and uncached copy
commands produce the same cache key
* Update tests for fix
* Add test for cached run command key consistency
2019-12-15 10:23:31 -08:00
Cole Wippern
2aa481c15e
add unit tests for caching run and copy
2019-12-10 09:29:10 -08:00
Cole Wippern
b19214ad1e
Use cachekey not digest for COPY --from src
...
* use the cachekey of the src stage rather than the digest
for COPY --from commands as they are reproducible unlike digests
* track digest to cache keys and stage indexes to digest
* add extra debug logging for troubleshooting cachekey building issues
* convert Sha256 hashes to hex encoded strings rather than plain strings
for easier human reading
2019-12-10 08:45:13 -08:00
Cole Wippern
7b4b768edf
Update copy command cache key logic
...
Include the digest of the stage specified in the --from argument for
COPY commands which use --from
2019-12-09 16:48:20 -08:00
Tejal Desai
56f92e74af
Merge pull request #849 from wripley/master
...
Modified error message for writing image with digest file
2019-12-09 12:57:33 -08:00
Cole Wippern
7ba65daf7f
cleanup executor/build_test.go
2019-11-28 09:36:39 -08:00
Cole Wippern
828e764b95
add boilerplate for composite_cache_test
2019-11-28 09:18:58 -08:00
Cole Wippern
6d0c8da90e
more stagebuilder caching tests
2019-11-28 08:42:13 -08:00
Cole Wippern
33f3191b17
Don't hardcode hashes for stagebuilder tests
2019-11-27 21:47:00 -08:00
Cole Wippern
697037cbcf
Add unit tests for compositecache and stagebuilder
...
* add mock types for testing
* enhance error messaging
* add tests
2019-11-27 21:47:00 -08:00
Cole Wippern
54635c3d39
don't exit optimize early so we record cache keys
2019-11-27 17:09:00 -08:00
Cole Wippern
2755ae4470
Final cachekey for stage
...
Store the last cachekey generated for each stage
If the base image for a stage is present in the map of digest
and cachekeys use the retrieved cachekey instead of the base image
digest in the compositecache
2019-11-27 14:40:05 -08:00
Will Ripley
f6aa8f709b
Modified error message for writing image with digest file
2019-11-08 12:59:25 -06:00
Will Ripley
c8f089fdbb
Fixed formatting errors with push.go and push_test.go
2019-10-29 13:09:27 -05:00
Will Ripley
a0651436b5
Changed image name to be full image name minus tag. Also added test for new ImageNameDigestFile flag
2019-10-29 12:55:50 -05:00
Will Ripley
f38c47daa0
Made changes to --image-name-with-digest-file to support multiple destinations
2019-10-29 10:55:49 -05:00
Will Ripley
4c9a800e12
Added image digest file path
2019-10-21 11:55:55 -05:00
Tejal Desai
b57160198e
fix bad merge
2019-10-04 11:20:41 -07:00
Tejal Desai
f206e3f425
Merge branch 'master' into output
2019-10-04 08:43:02 -07:00