1240333657
Stop caching COPY layers ( #1408 )
...
Cached COPY layers are expensive in that they both need to be retrieved
over the network and occupy space in the layer cache.
They are unnecessary in that we already have all resources needed to
execute the COPY locally, and doing so is a trivial file-system
operation. This is in contrast to RUN layers, which can do
arbitrary and unbounded work.
The end result is that cached COPY commands were more expensive when
cached, not less. Remove them.
Resolves #1357
2020-09-30 17:18:50 -07:00
44b35b28eb
remove read succesS
2020-04-30 15:18:39 -07:00
ffc372a63b
refactor to add unit tests
2020-03-23 17:48:49 -07:00
3ff2ee3ba5
copy: unit test for chown
...
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-03-17 15:19:00 +01:00
c136f886a9
Add support to --chown flag to ADD command
2020-03-14 16:24:40 +02:00
9592f2640f
more tests similar to docker cp
2020-03-09 15:54:35 -07:00
c523c691eb
revert back to old 0.17.1 behavior
2020-03-06 23:48:31 -08:00
8f87267002
fix lint error
2020-03-06 21:37:00 -08:00
6c14d202a3
better error wrapping and add more tests for copy
2020-03-06 17:18:36 -08:00
b4b70d040a
wip
2020-03-06 13:08:02 -08:00
17f808da8a
check for filepath.Walk error everywhere
2020-02-28 04:23:27 -08:00
8d9e6b8ea5
Merge pull request #1027 from tejal29/small_refacto
...
refactor copy.chown code and add more tests
2020-02-07 13:48:05 -08:00
d94a1ed53b
fix linter
2020-02-06 11:40:41 -08:00
9dba097a7e
refactor and add more tests
2020-02-06 11:40:41 -08:00
cd9be5d513
reuse cached layer
2020-01-23 16:48:26 -08:00
df767bb195
apply code review results
2020-01-21 12:07:13 +09:00
d6fe98aa49
Fixed an issue where the image is broken if there are symlink in the destination path when ADD, COPY
2020-01-03 16:28:12 +09:00
9e9b8a6e71
Fix #899 cached copy results in inconsistent key
...
* Update cached copy command to return the same result for
files used from context so that cached and uncached copy
commands produce the same cache key
* Update tests for fix
* Add test for cached run command key consistency
2019-12-15 10:23:31 -08:00
2aa481c15e
add unit tests for caching run and copy
2019-12-10 09:29:10 -08:00
2b26dfea61
Add unit tests for resolveIfSymlink
2019-11-15 11:23:15 -08:00
27020f23b9
Resolving comments
2019-10-08 12:19:20 -07:00
2d73c2d996
addressing lint issues
2019-10-07 13:06:40 -07:00
2eace1d511
Refactoring to add use of a tempdir
2019-10-07 12:56:34 -07:00
4e1639c030
Addressing review comments
2019-10-07 10:46:28 -07:00
1bb5a41d7d
Fixing lint issues. Adding tests for COPY command. Fixing issue with copying files out of snapshots
2019-09-16 10:48:31 -07:00
e003bae87d
first commit of copy_test
2019-09-16 10:46:57 -07:00
Ian Kerins
Tejal Desai
Yoan Blanc
Dani Raznikov
Cole Wippern
ohchang-kwon
Don McCasland