Commit Graph

283 Commits

Author SHA1 Message Date
Yoan Blanc ca23ae441e
add should fail on 40x
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-06-20 09:49:11 +02:00
Tejal Desai 4ac51ef515 merge 2020-06-06 20:17:17 -07:00
Tejal Desai 35d2358482 add integration tests 2020-06-06 00:53:08 -07:00
Tejal Desai 2a7d33526b lint 2020-06-06 00:30:07 -07:00
Tejal Desai 0f5387960e minimal changes 2020-06-06 00:16:14 -07:00
Tejal Desai 01c3a1bcf3 mend 2020-06-05 23:47:31 -07:00
Tejal Desai 58276274e8 better improvements 2020-06-05 23:44:17 -07:00
Tejal Desai 43338d4b2f add a new run command along with a new flag 2020-06-05 19:53:16 -07:00
Tejal Desai 57818cfb79 lint 2020-06-05 16:49:28 -07:00
Tejal Desai ba00c9fb7d add benchmarking for gcb 2020-06-05 15:10:28 -07:00
Tejal Desai 95a8ecc200 fix lint 2020-06-05 14:58:36 -07:00
Tejal Desai 66c8266627 remove private buckets 2020-06-05 13:58:30 -07:00
Tejal Desai 6ab97e2b5f ADD GCB benchmark code 2020-06-05 12:46:47 -07:00
Tejal Desai 92a5c89b97
update year in license. 2020-06-04 15:12:57 -07:00
Tejal Desai 18dbb0e12a add biolerplate 2020-06-04 15:11:24 -07:00
Tejal Desai 85c40c45b3 fix dockerfile 2020-06-04 15:10:01 -07:00
Tejal Desai 9b48be6440 Merge branch 'master' into benchmark-snapshot 2020-06-04 13:02:04 -07:00
Tejal Desai 8074a70863
Merge pull request #1285 from antechrestos/fix/image_argument_name
Added integration test for multi level argument
2020-06-04 12:04:06 -07:00
Tejal Desai 994a412d0b some more renames 2020-06-02 16:08:46 -07:00
Tejal Desai cbf3073fda rename whitelist to ignorelist 2020-06-02 15:56:27 -07:00
Tejal Desai b98f55a41d some more fixes 2020-05-26 08:40:25 -07:00
Tejal Desai a60a097c9b one more fix 2020-05-26 00:22:50 -07:00
Tejal Desai 48421f1126 more fixes 2020-05-26 00:16:03 -07:00
Tejal Desai 4129c17d12 more changes 2020-05-25 23:36:59 -07:00
Tejal Desai 5d013626fc benchmark project added 2020-05-25 21:30:07 -07:00
Ben Einaudi 3462b7585b Added integration test for multi level argument
Added integration test to check that following pattern is supported

ARG TAG=1.2
ARG IMAGE=my-image:${TAG}
FROM ${IMAGE}
...
2020-05-24 13:04:31 +02:00
Tejal Desai 5e275d9824 Apply dockefile exclude only for first stage 2020-05-05 21:45:36 -07:00
Tejal Desai c6a98b754a
Make sure integration test has a relative workdir 2020-05-04 09:48:09 -07:00
Tejal Desai e32715ef55
Merge pull request #1164 from tstromberg/add-groups
Add secondary group impersonation w/ !cgo support
2020-05-03 22:00:36 -07:00
Tejal Desai ae11db43d7
Merge pull request #1193 from tp-tc/dangling-symlink
Ignore the target of dangling symlinks.
2020-05-03 20:47:12 -07:00
Tejal Desai a2af3272cf
Merge pull request #1192 from tp-tc/snapshot-maintainers
Handle `MAINTAINERS` when passing `--single-snapshot`.
2020-05-03 20:45:48 -07:00
Tejal Desai 8a780be748
Merge pull request #1139 from JordanGoasdoue/allow-injecting-context-tar-gz
feat: allow injecting through stdin tar.gz on kaniko
2020-05-01 10:24:05 -07:00
Tejal Desai 6c627645ad
Merge pull request #1194 from tp-tc/greedy-cache-substitution
Don't generate cache key, if not caching builds.
2020-05-01 10:21:44 -07:00
Tom Prince c520218cec Don't generate cache key, if not caching builds.
The cache key generation does environment subsitution in places that running
the commands doesn't. This causes issues if a command uses complex shell
substitutions. The cache key is generated even if caching isn't enabled.

This disables the cache key generation if caching is not enabled. This doesn't
fix the underlying issue, but limits it to when the cache is being used.
2020-04-13 16:50:13 -06:00
Tom Prince 5061b72e42 Ignore the target of dangling symlinks. 2020-04-13 16:26:19 -06:00
Tom Prince 484d03550c Handle `MAINTAINERS` when passing `--single-snapshot`. 2020-04-13 15:54:27 -06:00
Carlos Alexandro Becker 8b50908e48
test: fixed
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2020-04-03 17:15:40 -03:00
Carlos Alexandro Becker 0fc7b8a4f4
test: add it
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2020-04-03 16:34:22 -03:00
Thomas Stromberg a6504769e3 Add secondary group impersonation w/ !cgo support 2020-03-28 22:01:20 -07:00
Sam Stoelinga 1b662e7834
Merge pull request #1140 from samos123/fix-1122-public-gcr
Add ability to use public GCR repos without being authenticated
2020-03-24 10:31:58 -07:00
Jordan Goasdoué d08a767454 feat: allow injecting through stdin tar.gz on kaniko 2020-03-18 12:29:49 +01:00
Tejal Desai a173bf020b
Merge pull request #1115 from JordanGoasdoue/allow-build-context-from-local-targz
feat: add support of local '.tar.gz' file inside the kaniko container
2020-03-17 15:24:10 -07:00
Tejal Desai 0185818bd8
Merge pull request #1134 from dani29/master
Add support to --chown flag to ADD command (Issue #57)
2020-03-17 15:07:02 -07:00
Sam Stoelinga 0cfc5c635a Remove importing gcr images into docker registry
Previously there was a need to import public GCR images into the local
docker registry and replace the base images to use the local docker
registry. This is no longer needed since Kaniko now works with public
GCR images also for unauthenticated users.
2020-03-16 14:53:18 -07:00
Sam Stoelinga 23e3fe7486
Merge pull request #1124 from samos123/travis-k8s-test
Travis k8s integration test
2020-03-16 11:00:56 -07:00
Dani Raznikov c136f886a9 Add support to --chown flag to ADD command 2020-03-14 16:24:40 +02:00
Jordan GOASDOUE fda7ed4f74 feat: add support of local '.tar.gz' file inside the kaniko container 2020-03-12 22:51:30 +01:00
Tejal Desai 32decf5798
Merge pull request #1075 from greut/label-flag
executor: add --label flag
2020-03-12 13:47:01 -07:00
Sam Stoelinga 882793b755 Add K8s integration tests
- Use minikube for deploying a lightweight K8s on Travis CI
- Build and push Kaniko image to local docker registry
- Build dockerfiles with context on both docker and K8s and check
  the diff between the 2.
2020-03-11 11:49:22 -07:00
Tejal Desai 2181c5e6f5 create correct link across Multistage builds 2020-03-07 11:28:16 -08:00
Yoan Blanc 53326fa0bf
executor: add --label flag
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-03-07 18:17:26 +01:00
Yoan Blanc c7028c6d2f
run: user LookupId
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-03-05 16:44:55 +01:00
Tejal Desai 9e83210b07 Rebase over 1105 2020-03-04 14:16:24 -08:00
Yoan Blanc 55361b2998 fixup! fixup! integration: test user fancy home
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-03-04 14:14:21 -08:00
Yoan Blanc c8d2cb7071 fixup! integration: test user fancy home
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-03-04 14:14:21 -08:00
Yoan Blanc bfeb40d600 integration: test user fancy home
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-03-04 14:14:21 -08:00
Yoan Blanc 0c6571a1fc integration: test case for HOME
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-03-04 14:11:49 -08:00
Tejal Desai bc399d9257 remove accessing user dir 2020-03-04 13:43:23 -08:00
Tejal Desai c1e3f42625 fix user metadata string 2020-03-04 13:08:38 -08:00
Cole Wippern 17ceb312c6
Merge pull request #1054 from cvgw/u/cgwippern/integration-tests-from-issues
Add integration tests from Issues
2020-03-03 11:47:23 -08:00
Tejal Desai b538066dcb
Merge pull request #1088 from cvgw/u/cgwippern/integration-tests-with-context
add integration tests with their own context
2020-03-02 09:41:59 -08:00
cvgw 75f6bfe265 fix #1092 TestRelativePaths
Fix integraton test TestRelativePaths
2020-02-29 21:16:07 -08:00
cvgw 57c97dea3e add integration tests with their own context 2020-02-29 15:41:10 -08:00
cvgw 5651ff8c92 remove failing tests, add later 2020-02-29 15:39:51 -08:00
Tejal Desai 7aa737c297
Merge pull request #1077 from greut/container-diff
test: refactor container-diff call
2020-02-27 21:57:42 -08:00
cvgw 9f18d8006c add integration tests from GH issues 2020-02-27 11:04:55 -08:00
Yoan Blanc 8b34c99de8
fixup! integration: refactor container-diff
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-02-26 14:20:03 +01:00
Tejal Desai fb0cfd7464
Merge pull request #1049 from antechrestos/refactor/build_cache_in_integration_image_build
Refactor integration image built
2020-02-26 01:03:05 -08:00
Yoan Blanc f856b831d1
test: refactor container-diff call
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-02-26 07:00:33 +01:00
cvgw a675ad998a Resolve filepaths before scanning for changes 2020-02-20 09:45:44 -08:00
cvgw 61bcba23f2 Fix #1067 - image no longer available
replace the tenstartups/alpine image with the canonical alpine image in
our integration tests as the former is no longer available
2020-02-20 08:40:38 -08:00
Yoan Blanc 474fdcf68d
image: fix registry mirror setup
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2020-02-16 11:41:51 +01:00
Yoan Blanc edc4eb33f4
Merge remote-tracking branch 'origin/master' into registry-mirror 2020-02-16 09:28:54 +01:00
Ben Einaudi 0c1d05520f Refactor integration imaqge built
The aim of this change is to hide the complexity of image not being rebuilt. Image builder won't also have to know the list of dockerfiles
2020-02-15 09:52:09 +01:00
Ben Einaudi 3e2221cf6f Allow contributors to launch integration tests against local registry
This change allows user to launch integration tests with a local registry

Fixes #1012
2020-02-06 13:35:51 +01:00
Tejal Desai 2cd68d2e2f fix flake in copy symlink 2020-02-05 14:40:52 -08:00
Tejal Desai 3cd216f75b add the registry mirror flag 2020-01-30 15:37:10 -08:00
Tejal Desai 611ba51c88 fix web editor conflicts resolutions 2020-01-30 11:18:53 -08:00
Ben Einaudi 2f1e54e591 Expand build argument from environment when no value specified
Fixes #713
2020-01-30 12:01:06 +01:00
Tejal Desai 47ab3fe997
Merge branch 'master' into registry-mirror 2020-01-29 11:42:06 -08:00
Tejal Desai 0529579db7
Merge pull request #971 from tejal29/915
Fix Symlinks not being copied across stages
2020-01-27 10:58:49 -08:00
Cole Wippern a2aae6274d
Merge pull request #973 from cvgw/u/cgwippern/fix-issue-704
Fix issue #704
2020-01-23 13:00:34 -08:00
Tejal Desai 3e5d0a6334 add unit tests 2020-01-23 11:12:54 -08:00
Tejal Desai da7e9928e4 Fix Symlinks not being copies across stages 2020-01-22 11:47:10 -08:00
Tejal Desai 6e80e627ac
Merge pull request #979 from samos123/travis-ci-integration-testv2
Run integration tests in Travis CI
2020-01-22 09:55:02 -08:00
cvgw e652f815ef Fix #519 capital letter in stage names
update stage code so that when comparing the BaseName of
a stage against the recorded, lowercase version of a Stage name
the BaseName is also lowercased.
2020-01-20 15:57:05 -08:00
Sam Stoelinga 61af994a33 Run integration tests in Travis CI
- Change integration tests to use docker hub instead of GCR due to bug
in library that requires authentication with gcr.io even for public
images. See #966 for bug tracking this.
- Make uploading to GCS bucket configurable through a flag --uploadToGCS
- Utilize a locally deployed docker registry in travis CI to remove
dependency of needing to authenticate with GCP. This requires host
networking such that we can access the registry on localhost:5000
- Use the commit that's being tested for `TestGitBuildcontext`
- Remove duplicate GitBuildContext case that's now covered by default in
travis CI.
2020-01-19 22:33:04 -08:00
Yoan Blanc 140879fadd
Merge remote-tracking branch 'origin/master' into registry-mirror 2020-01-18 09:35:56 +01:00
Cole Wippern 71aed35094 GetFSFromLayers
* add util.GetFSFromLayers
* GetFSFromImage delegates to GetFSFromLayers
* add FSOpts and FSConfig for GetFSFromLayers
* add tests for GetFSFromLayers
* add gomock for test support
* add mock_v1 for layers
2020-01-17 13:36:23 -08:00
Tejal Desai a6add78a97 do not use the git repo as context 2020-01-16 23:08:22 -08:00
Tejal Desai 20604dff3d
fix integration test 2020-01-16 22:12:35 -08:00
Tejal Desai 2a4cb90ea1
remove registry name from dockerfile
Rename dockerfile 
Revert registry name change
2020-01-16 22:09:50 -08:00
Tejal Desai f721212ded
fix base image link. 2020-01-16 22:01:47 -08:00
Sam Stoelinga 64bfc3eabb Fix bug with docker compatibility
ArgsEscaped according to Docker docs should only be set in Windows
environments: https://docs.docker.com/engine/api/v1.30/

It was causing integration test to fail with following message:
```
FAIL: TestRun/test_Dockerfile_test_metadata (8.48s)
           "Diff": {
             "Adds": [
               "ArgsEscaped: true"
             ],
             "Dels": [
               "ArgsEscaped: false"
             ]
```

However docker 18.xx returns ArgsEscaped: true
whereas docker 19.xx returns ArgsEscaped: false
Hence this patch also adds the docker version check to the integration
to ignore ArgsEscaped being different when 18.xx is used.
2020-01-13 21:18:54 -08:00
Sam Stoelinga 8cf392e20e Allow setting serviceAccount in integration test
Previously it would mount .config/gcloud directory which is not
recommended for systems such as CI that authenticate with Google Cloud.
This commit allows you to set the path to a service account.

By default previous behaviour will be as before so this shouldn't break
existing systems that run the integration test.
2020-01-12 18:54:50 -08:00
Sam Stoelinga fa94f6b942 Fix #950 integration test failing on go 1.13
From Golang 1.13 release notes:
Testing flags are now registered in the new Init function, which is
invoked by the generated main function for the test. As a result,
testing flags are now only registered when running a test binary, and
packages that call flag.Parse during package initialization may cause
tests to fail.
2020-01-07 09:46:25 -08:00
Yoan Blanc 3ad9f7d94c
fixup! fixup! fixup! integration-test: using registry-mirror
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2019-12-23 09:34:32 +01:00
Yoan Blanc e05bdd58f2
fixup! fixup! integration-test: using registry-mirror
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2019-12-23 09:32:13 +01:00
Yoan Blanc 9fb2111379
fixup! integration-test: using registry-mirror
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2019-12-22 14:10:12 +01:00
Yoan Blanc c7d173cd99
integration-test: using registry-mirror
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
2019-12-22 11:29:03 +01:00