diff --git a/Makefile b/Makefile index 9d1064eb8..1694112bf 100644 --- a/Makefile +++ b/Makefile @@ -48,3 +48,7 @@ test: out/executor out/kbuild .PHONY: integration-test integration-test: out/executor out/kbuild @ ./integration-test.sh + +.PHONY: images +images: out/executor out/kbuild + docker build -t $(REGISTRY)/executor:latest -f deploy/Dockerfile . diff --git a/integration_tests/executor/Dockerfile b/deploy/Dockerfile similarity index 100% rename from integration_tests/executor/Dockerfile rename to deploy/Dockerfile diff --git a/integration_tests/integration_test_yaml.go b/integration_tests/integration_test_yaml.go index 545add4d5..e81d4269d 100644 --- a/integration_tests/integration_test_yaml.go +++ b/integration_tests/integration_test_yaml.go @@ -18,6 +18,7 @@ package main import ( "fmt" + "gopkg.in/yaml.v2" ) @@ -116,7 +117,7 @@ func main() { // Build executor image buildExecutorImage := step{ Name: dockerImage, - Args: []string{"build", "-t", executorImage, "-f", "integration_tests/executor/Dockerfile", "."}, + Args: []string{"build", "-t", executorImage, "-f", "deploy/Dockerfile", "."}, } y := testyaml{ Steps: []step{containerDiffStep, containerDiffPermissions, structureTestsStep, structureTestPermissions, buildExecutorImage}, diff --git a/pkg/commands/env.go b/pkg/commands/env.go index b88b5f01e..87e668efd 100644 --- a/pkg/commands/env.go +++ b/pkg/commands/env.go @@ -31,7 +31,6 @@ type EnvCommand struct { func (e *EnvCommand) ExecuteCommand(config *manifest.Schema2Config) error { logrus.Info("cmd: ENV") - envString := envToString(e.cmd) newEnvs := e.cmd.Env for index, pair := range newEnvs { diff --git a/pkg/commands/env_test.go b/pkg/commands/env_test.go index c7c767059..a6c8af246 100644 --- a/pkg/commands/env_test.go +++ b/pkg/commands/env_test.go @@ -93,7 +93,7 @@ func Test_EnvExecute(t *testing.T) { }, { Key: "$path", - Value: "$home", + Value: "$home/", }, }, }, @@ -103,7 +103,7 @@ func Test_EnvExecute(t *testing.T) { "path=/some/path", "home=/root", "HOME=/root", - "/usr/=/root", + "/usr/=/root/", } err := envCmd.ExecuteCommand(cfg) testutil.CheckErrorAndDeepEqual(t, false, err, expectedEnvs, cfg.Env) diff --git a/pkg/util/command_util.go b/pkg/util/command_util.go index d9187a7ed..ab56dd923 100644 --- a/pkg/util/command_util.go +++ b/pkg/util/command_util.go @@ -33,7 +33,7 @@ func ResolveEnvironmentReplacementList(command string, values, envs []string, is var resolvedValues []string for _, value := range values { resolved, err := ResolveEnvironmentReplacement(command, value, envs, isFilepath) - logrus.Infof("Resolved %s to %s", value, resolved) + logrus.Debugf("Resolved %s to %s", value, resolved) if err != nil { return nil, err }