diff --git a/pkg/commands/add.go b/pkg/commands/add.go index 52c5842a7..dfc7f63f8 100644 --- a/pkg/commands/add.go +++ b/pkg/commands/add.go @@ -43,18 +43,15 @@ type AddCommand struct { // 2. If is a local tar archive: // -If is a local tar archive, it is unpacked at the dest, as 'tar -x' would func (a *AddCommand) ExecuteCommand(config *v1.Config, buildArgs *dockerfile.BuildArgs) error { - srcs := a.cmd.SourcesAndDest[:len(a.cmd.SourcesAndDest)-1] - dest := a.cmd.SourcesAndDest[len(a.cmd.SourcesAndDest)-1] - // First, resolve any environment replacement replacementEnvs := buildArgs.ReplacementEnvs(config.Env) resolvedEnvs, err := util.ResolveEnvironmentReplacementList(a.cmd.SourcesAndDest, replacementEnvs, true) if err != nil { return err } - dest = resolvedEnvs[len(resolvedEnvs)-1] + dest := resolvedEnvs[len(resolvedEnvs)-1] // Resolve wildcards and get a list of resolved sources - srcs, err = util.ResolveSources(resolvedEnvs, a.buildcontext) + srcs, err := util.ResolveSources(resolvedEnvs, a.buildcontext) if err != nil { return err } diff --git a/pkg/commands/copy.go b/pkg/commands/copy.go index cdb05fba5..8b34d1b6b 100644 --- a/pkg/commands/copy.go +++ b/pkg/commands/copy.go @@ -35,9 +35,6 @@ type CopyCommand struct { } func (c *CopyCommand) ExecuteCommand(config *v1.Config, buildArgs *dockerfile.BuildArgs) error { - srcs := c.cmd.SourcesAndDest[:len(c.cmd.SourcesAndDest)-1] - dest := c.cmd.SourcesAndDest[len(c.cmd.SourcesAndDest)-1] - // Resolve from if c.cmd.From != "" { c.buildcontext = filepath.Join(constants.KanikoDir, c.cmd.From) @@ -48,9 +45,9 @@ func (c *CopyCommand) ExecuteCommand(config *v1.Config, buildArgs *dockerfile.Bu if err != nil { return err } - dest = resolvedEnvs[len(resolvedEnvs)-1] + dest := resolvedEnvs[len(resolvedEnvs)-1] // Resolve wildcards and get a list of resolved sources - srcs, err = util.ResolveSources(resolvedEnvs, c.buildcontext) + srcs, err := util.ResolveSources(resolvedEnvs, c.buildcontext) if err != nil { return err }