public_git/kaniko
1
0
Fork 0
mirror of https://github.com/GoogleContainerTools/kaniko synced 2026-10-18 06:50:21 +02:00
Code Issues Releases Wiki Activity

feat: kaniko dir config option (#1997)

Browse Source 
* remove configurables from constants

* add configurables to config init

* add kaniko dir flag

* cleanup pkg constants

* replace buildcontext constants pkg occurrences with config

* add KanikoDir to KanikoOptions

* replace executor constants pkg occurrences with config

* remove redundant KanikoDir assignment

* replace constants to config for IntermediateStagesDir

* fix imports

* add default kaniko directory into constants

* add check for kanikoDir on use

* update init to use default path constant

* update executor kanikoDir check

Co-authored-by: Jason Hall <jasonhall@redhat.com>

* alter checkKanikoDir parameter

* add TestKanikoDir func

* update error handling style

Co-authored-by: Jason Hall <jasonhall@redhat.com>

* remove shorthand flag usage from test

Co-authored-by: Jason Hall <jasonhall@redhat.com>

* add docstring to integration test

Co-authored-by: Jason Hall <jasonhall@redhat.com>

* remove shorthand flag from kaniko-dir

Co-authored-by: Jason Hall <jasonhall@redhat.com>
This commit is contained in:
Jack
2022-03-31 15:10:23 -04:00
committed by GitHub
co-authored by Jason Hall
parent 2a8c565dd5
commit d4cf49077a
14 changed files with 105 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/executor/build.go
+1 -1
View File
@@ -829,7 +829,7 @@ func saveStageAsTarball(path string, image v1.Image) error {
if err != nil {
return err
}
tarPath := filepath.Join(constants.KanikoIntermediateStagesDir, path)
tarPath := filepath.Join(config.KanikoIntermediateStagesDir, path)
logrus.Infof("Storing source image from stage %s at path %s", path, tarPath)
if err := os.MkdirAll(filepath.Dir(tarPath), 0750); err != nil {
return err
pkg/executor/copy_multistage_test.go
-1
View File
@@ -177,7 +177,6 @@ func setupMultistageTests(t *testing.T) (string, func()) {
}
config.IgnoreListPath = mFile
return testDir, func() {
config.KanikoDir = constants.KanikoDir
config.RootDir = constants.RootDir
config.IgnoreListPath = constants.IgnoreListPath
}