fix golint problem

This commit is contained in:
yw-liu 2020-04-17 00:21:48 +08:00
parent 0fc311a8b7
commit c9fc6b5bcf
2 changed files with 11 additions and 11 deletions

View File

@ -27,12 +27,12 @@ import (
const (
gitPullMethodEnvKey = "GIT_PULL_METHOD"
gitPullMethodHttps = "https"
gitPullMethodHttp = "http"
gitPullMethodHTTPS = "https"
gitPullMethodHTTP = "http"
)
var (
supportedGitPullMethods = map[string]bool{gitPullMethodHttps: true, gitPullMethodHttp: true}
supportedGitPullMethods = map[string]bool{gitPullMethodHTTPS: true, gitPullMethodHTTP: true}
)
// Git unifies calls to download and unpack the build context.

View File

@ -15,7 +15,7 @@ func TestGetGitPullMethod(t *testing.T) {
{
testName: "noEnv",
setEnv: func() (expectedValue string) {
expectedValue = gitPullMethodHttps
expectedValue = gitPullMethodHTTPS
return
},
},
@ -23,18 +23,18 @@ func TestGetGitPullMethod(t *testing.T) {
testName: "emptyEnv",
setEnv: func() (expectedValue string) {
_ = os.Setenv(gitPullMethodEnvKey, "")
expectedValue = gitPullMethodHttps
expectedValue = gitPullMethodHTTPS
return
},
},
{
testName: "httpEnv",
setEnv: func() (expectedValue string) {
err := os.Setenv(gitPullMethodEnvKey, gitPullMethodHttp)
err := os.Setenv(gitPullMethodEnvKey, gitPullMethodHTTP)
if nil != err {
expectedValue = gitPullMethodHttps
expectedValue = gitPullMethodHTTPS
} else {
expectedValue = gitPullMethodHttp
expectedValue = gitPullMethodHTTP
}
return
},
@ -42,8 +42,8 @@ func TestGetGitPullMethod(t *testing.T) {
{
testName: "httpsEnv",
setEnv: func() (expectedValue string) {
_ = os.Setenv(gitPullMethodEnvKey, gitPullMethodHttps)
expectedValue = gitPullMethodHttps
_ = os.Setenv(gitPullMethodEnvKey, gitPullMethodHTTPS)
expectedValue = gitPullMethodHTTPS
return
},
},
@ -51,7 +51,7 @@ func TestGetGitPullMethod(t *testing.T) {
testName: "unknownEnv",
setEnv: func() (expectedValue string) {
_ = os.Setenv(gitPullMethodEnvKey, "unknown")
expectedValue = gitPullMethodHttps
expectedValue = gitPullMethodHTTPS
return
},
},