Integration tests for entrypoint

This commit is contained in:
Priya Wadhwa 2018-03-20 13:00:36 -07:00
parent d49c7c5ed1
commit bf47ea928b
No known key found for this signature in database
GPG Key ID: 0D0DAFD8F7AA73AE
4 changed files with 12 additions and 6 deletions

View File

@ -2,3 +2,6 @@ FROM gcr.io/distroless/base:latest
CMD ["command", "one"]
CMD ["command", "two"]
CMD echo "hello"
ENTRYPOINT ["execute", "something"]
ENTRYPOINT ["execute", "entrypoint"]

View File

@ -1,3 +1,4 @@
schemaVersion: '2.0.0'
metadataTest:
cmd: ["/bin/sh", "-c", "echo \"hello\""]
entrypoint: ["execute", "entrypoint"]

View File

@ -66,11 +66,11 @@ var structureTests = []struct {
structureTestYamlPath: "/workspace/integration_tests/dockerfiles/test_env.yaml",
},
{
description: "test cmd",
dockerfilePath: "/workspace/integration_tests/dockerfiles/Dockerfile_test_cmd",
repo: "test-cmd",
description: "test metadata",
dockerfilePath: "/workspace/integration_tests/dockerfiles/Dockerfile_test_metadata",
repo: "test-metadata",
dockerBuildContext: "/workspace/integration_tests/dockerfiles/",
structureTestYamlPath: "/workspace/integration_tests/dockerfiles/test_cmd.yaml",
structureTestYamlPath: "/workspace/integration_tests/dockerfiles/test_metadata.yaml",
},
}

View File

@ -53,11 +53,13 @@ func (c *CmdCommand) FilesToSnapshot() []string {
// CreatedBy returns some information about the command for the image config history
func (c *CmdCommand) CreatedBy() string {
cmd := []string{"CMD"}
cmdLine := strings.Join(c.cmd.CmdLine, " ")
if c.cmd.PrependShell {
// TODO: Support shell command here
shell := []string{"/bin/sh", "-c"}
return strings.Join(append(shell, cmdLine), " ")
appendedShell := append(cmd, shell...)
return strings.Join(append(appendedShell, cmdLine), " ")
}
return cmdLine
return strings.Join(append(cmd, cmdLine), " ")
}