From 6b6795e4a7a3a6c01a85530b70dce22d70e02311 Mon Sep 17 00:00:00 2001 From: Jason Hall Date: Mon, 16 May 2022 15:19:39 -0400 Subject: [PATCH] Fix release tagging workflow (#2034) In Bash, "-eq" compares integers, and "==" compares strings, so "debug -eq latest" always evaulated to true. $ if [[ "debug" -eq "latest" ]]; then echo latest; else echo debug; fi latest $ if [[ "debug" == "latest" ]]; then echo latest; else echo debug; fi debug --- .github/workflows/images.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/images.yaml b/.github/workflows/images.yaml index 2065932cc..fbfbbd2bd 100644 --- a/.github/workflows/images.yaml +++ b/.github/workflows/images.yaml @@ -115,7 +115,7 @@ jobs: crane cp ${{ matrix.image-name }}@${{ steps.build-and-push.outputs.digest }} \ ${{ matrix.image-name }}:${{ matrix.release-tag }} - if [[ ${{ matrix.release-tag }} -eq "latest" ]]; then + if [[ "${{ matrix.release-tag }}" == "latest" ]]; then # Tag :latest images as :v1.X.Y crane cp ${{ matrix.image-name }}@${{ steps.build-and-push.outputs.digest }} \ ${{ matrix.image-name }}:${tag}