public_git
/
kaniko
mirror of https://github.com/GoogleContainerTools/kaniko
1
0
Fork 0
Code Issues Releases Wiki Activity

fix: CheckPushPermissions not being called when CacheRepo was set (#1471)

This commit is contained in:
ejose19 2020-10-30 03:46:00 -03:00 committed by GitHub
parent 5afb142c69
commit 2f8d939b3f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/executor/cmd/root.go
View File

@ -95,7 +95,7 @@ var RootCmd = &cobra.Command{
} }
logrus.Warn("kaniko is being run outside of a container. This can have dangerous effects on your system") logrus.Warn("kaniko is being run outside of a container. This can have dangerous effects on your system")
} }
if !opts.NoPush { if !opts.NoPush || opts.CacheRepo != "" {
if err := executor.CheckPushPermissions(opts); err != nil { if err := executor.CheckPushPermissions(opts); err != nil {
exit(errors.Wrap(err, "error checking push permissions -- make sure you entered the correct tag name, and that you are authenticated correctly, and try again")) exit(errors.Wrap(err, "error checking push permissions -- make sure you entered the correct tag name, and that you are authenticated correctly, and try again"))
} }

2
pkg/executor/push.go
View File

@ -102,7 +102,7 @@ var (
// CheckPushPermissions checks that the configured credentials can be used to // CheckPushPermissions checks that the configured credentials can be used to
// push to every specified destination. // push to every specified destination.
func CheckPushPermissions(opts *config.KanikoOptions) error { func CheckPushPermissions(opts *config.KanikoOptions) error {
var targets = opts.Destinations targets := opts.Destinations
// When no push is set, whe want to check permissions for the cache repo // When no push is set, whe want to check permissions for the cache repo
// instead of the destinations // instead of the destinations
if opts.NoPush { if opts.NoPush {