From 03a9847ab5b42911745644b8166d8e8740459d35 Mon Sep 17 00:00:00 2001 From: priyawadhwa Date: Mon, 18 Oct 2021 11:44:05 -0700 Subject: [PATCH] Fix executor Dockerfile, which wasn't building (#1741) The Makefile from the `docker-credential-gcr` repo was removed, so all builds were failing. This PR removes the `make` command and pins `docker-credential-gcr` to a specific commit so that this doesn't happen again. --- deploy/Dockerfile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/deploy/Dockerfile b/deploy/Dockerfile index 37c4a059d..42afe07db 100644 --- a/deploy/Dockerfile +++ b/deploy/Dockerfile @@ -32,7 +32,8 @@ RUN GOARCH=$(cat /goarch) && CGO_ENABLED=0 && \ cd /go/src/github.com/GoogleCloudPlatform && \ git clone https://github.com/GoogleCloudPlatform/docker-credential-gcr.git && \ cd /go/src/github.com/GoogleCloudPlatform/docker-credential-gcr && \ - make deps OUT_DIR=/usr/local/bin && \ + # pin to a specific commit + git checkout 4cdd60d0f2d8a69bc70933f4d7718f9c4e956ff8 && \ go build -ldflags "-linkmode external -extldflags -static" -i -o /usr/local/bin/docker-credential-gcr main.go # Get Amazon ECR credential helper