From 038dcc19587525963e659223fc8aed9a7f157ec4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Benjamin=20N=C3=B8rgaard?= Date: Wed, 3 Oct 2018 14:23:53 +0200 Subject: [PATCH] use strings.SplitN to avoid the join --- pkg/dockerfile/buildargs.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/dockerfile/buildargs.go b/pkg/dockerfile/buildargs.go index 4f472e782..b929528ef 100644 --- a/pkg/dockerfile/buildargs.go +++ b/pkg/dockerfile/buildargs.go @@ -29,12 +29,11 @@ type BuildArgs struct { func NewBuildArgs(args []string) *BuildArgs { argsFromOptions := make(map[string]*string) for _, a := range args { - s := strings.Split(a, "=") + s := strings.SplitN(a, "=", 2) if len(s) == 1 { argsFromOptions[s[0]] = nil } else { - val := strings.Join(s[1:], "=") - argsFromOptions[s[0]] = &val + argsFromOptions[s[0]] = &s[1] } } return &BuildArgs{