helmfile

mirror of https://github.com/helmfile/helmfile.git synced 2026-09-30 21:30:36 +02:00

Files

T

Danny Shemesh 71bb7354e7 Fix: populate .Values regardless of prestate success (#1202 )

This commit proposes a potential solution for
https://github.com/roboll/helmfile/issues/1201

The gist is that, if prestate rendering fails, for any reason,
we do not populate the .Values in the second pass renderer.

I think that what have been expected in this case is to populate the
.Values irregardless.

pkg/app/two_pass_renderer.go
- Migrated to use finalEnv.GetMergedValues()

pkg/environment/environment.go
- Introduced GetMergedValues, which merges the environment's defaults
and current values, and then casts the keys to string;
This was previously defined in HelmState.Values() - however, as this
method is only concerned with the environment, I think it's more
appropriate for it to sit here.

pkg/state/state_exec_tmpl.go
- Extracted out HelmState.Values() to environment.go, see above

2020-04-17 09:18:01 +09:00

app

Fix: populate .Values regardless of prestate success (#1202 )

2020-04-17 09:18:01 +09:00

argparser

fix: helmDefaults.kubeContext ignored in helm diff of helmfile apply (#682 )

2019-06-12 16:49:19 +09:00

environment

Fix: populate .Values regardless of prestate success (#1202 )

2020-04-17 09:18:01 +09:00

event

feat: Enhance postsync event to include .Error (#882 )