mirror of
https://github.com/helmfile/helmfile.git
synced 2026-09-30 07:08:38 +02:00
Aditya Menon
4f275b3667
This commit adds comprehensive support for Helm 4 while maintaining full backward compatibility with Helm 3. The implementation includes: - Updated helm version detection to support both Helm 3 and Helm 4 - Added HELMFILE_HELM4 environment variable to control Helm version - Modified helm execution paths to handle version-specific binaries - Updated helm plugin installation to support split architecture - Helm 4: Uses split plugin architecture (3 separate .tgz files) - helm-secrets.tgz - helm-secrets-getter.tgz - helm-secrets-post-renderer.tgz - Helm 3: Continues using single plugin installation - Updated Dockerfiles, CI workflows, and core installation code - Helm 4 requires post-renderers to be plugins, not executable scripts - Created Helm plugin structure for integration tests - Updated helmfile.yaml templates to dynamically select renderer type - Added test plugins: add-cm, add-cm1, add-cm2 - Updated integration tests for Helm 3/4 compatibility - Created Helm 4 variant expected output files - Fixed test determinism issues (repo cleanup between iterations) - Added version-specific output filtering for warnings/messages - Updated workflows to test both Helm 3 and Helm 4 - Matrix testing across Helm versions - Updated helm-diff to v3.14.0 for compatibility - Updated README and docs with Helm 4 information - Added migration guidance - Updated version requirements All changes are backward compatible - existing Helm 3 users will see no behavior changes. fix: update Helm 4 lint expected output to match filtered output The grep filter removes the semver warning, so the expected output should not include it. Updated lint-helm4 files to match the filtered output (warning removed, no extra blank line). Signed-off-by: Aditya Menon <amenon@canarytechnologies.com>
40 lines
1.9 KiB
Bash
40 lines
1.9 KiB
Bash
chartify_case_input_dir="${cases_dir}/chartify/input"
|
|
chartify_case_output_dir="${cases_dir}/chartify/output"
|
|
|
|
config_file="helmfile.yaml.gotmpl"
|
|
chartify_tmp=$(mktemp -d)
|
|
chartify_template_reverse=${chartify_tmp}/chartify.template.log
|
|
|
|
# Use Helm 4 variant files if available (output format may differ)
|
|
template_out_file="${chartify_case_output_dir}/template"
|
|
template_set_out_file="${chartify_case_output_dir}/template-set"
|
|
template_values_out_file="${chartify_case_output_dir}/template-values"
|
|
|
|
if [ "${HELMFILE_HELM4}" = "1" ]; then
|
|
if [ -f "${template_out_file}-helm4" ]; then
|
|
template_out_file="${template_out_file}-helm4"
|
|
fi
|
|
if [ -f "${template_set_out_file}-helm4" ]; then
|
|
template_set_out_file="${template_set_out_file}-helm4"
|
|
fi
|
|
if [ -f "${template_values_out_file}-helm4" ]; then
|
|
template_values_out_file="${template_values_out_file}-helm4"
|
|
fi
|
|
fi
|
|
|
|
test_start "helmfile template with chartify"
|
|
|
|
info "Comparing template/chartify"
|
|
${helmfile} -f ${chartify_case_input_dir}/${config_file} template >${chartify_template_reverse} || fail "\"helmfile template\" shouldn't fail"
|
|
./dyff between -bs ${template_out_file} ${chartify_template_reverse} || fail "\"helmfile template\" should be consistent"
|
|
|
|
info "Comparing template/chartify with set"
|
|
${helmfile} -f ${chartify_case_input_dir}/${config_file} template --set image.tag=v2 >${chartify_template_reverse} || fail "\"helmfile template\" shouldn't fail"
|
|
./dyff between -bs ${template_set_out_file} ${chartify_template_reverse} || fail "\"helmfile template\" should be consistent"
|
|
|
|
info "Comparing template/chartify with values"
|
|
${helmfile} -f ${chartify_case_input_dir}/${config_file} template --values "./extra-values.yaml" >${chartify_template_reverse} || fail "\"helmfile template\" shouldn't fail"
|
|
./dyff between -bs ${template_values_out_file} ${chartify_template_reverse} || fail "\"helmfile template\" should be consistent"
|
|
|
|
test_pass "helmfile template with chartify"
|