helmfile/pkg/app
yxxhero c584c0e07f
fix: helmDefaults.postRendererArgs not passed to helm commands (#2510)
* fix: helmDefaults.postRendererArgs not passed to helm commands (#2508)

The commit b5eb8793 (#1839) added template support for postRendererArgs
by copying HelmDefaults.PostRendererArgs to each release and then
niling out HelmDefaults.PostRendererArgs. However, the nil-out
prevented the fallback in appendPostRenderArgsFlags from ever being
reached, causing helmDefaults.postRendererArgs to be silently ignored
when no release-level postRendererArgs was set.

Remove the nil-out line so that HelmDefaults.PostRendererArgs remains
available as a fallback while still supporting template expressions
via the copy-to-release mechanism.

Signed-off-by: yxxhero <aiopsclub@163.com>

* fix: use helm4-compatible postRenderer value in app tests

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/17a1a3c2-e104-49c5-a607-1e81a7b9de06

Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>

* fix: remove postRendererArgs copy loop so CLI flags can override helmDefaults

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/c85f0436-2346-402e-8ad6-e08a4fff7413

Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>

* test: add missing CLI>helmDefault and release>CLI postRendererArgs priority tests

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/37cf3613-a4e1-4eac-b6bc-002761256d31

Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>

* fix: clarify comment wording in app_test.go

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/37cf3613-a4e1-4eac-b6bc-002761256d31

Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>

* refactor: extract newPostRendererTestApp and hasFlagWithValue helpers in app_test.go

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/faf50bca-33b2-4eb4-8ef1-49f470dfa5b7

Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>

---------

Signed-off-by: yxxhero <aiopsclub@163.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
2026-04-16 11:08:15 +08:00
..
testdata fix: pass --timeout flag through to helm for sync and apply (#2495) 2026-03-22 07:34:33 +08:00
version
app.go fix: update state values files handling to replace arrays instead of merging (#2537) 2026-04-13 19:46:15 +08:00
app_apply_hooks_test.go
app_apply_nokubectx_test.go
app_apply_test.go fix: pass --timeout flag through to helm for sync and apply (#2495) 2026-03-22 07:34:33 +08:00
app_diff_test.go
app_gethelm_test.go
app_lint_test.go
app_list_test.go fix: helmfile list now reflects version from helmfile.lock (#2486) 2026-03-19 14:25:03 +08:00
app_parallel_test.go
app_sequential_test.go
app_sync_test.go fix: pass --timeout flag through to helm for sync and apply (#2495) 2026-03-22 07:34:33 +08:00
app_template_test.go
app_test.go fix: helmDefaults.postRendererArgs not passed to helm commands (#2510) 2026-04-16 11:08:15 +08:00
app_unittest_test.go
ask.go
cleanup_hooks_error_test.go fix: cleanup hooks not receiving error signal (#2475) 2026-03-21 14:29:32 +08:00
config.go feat: add an arg that passing description to `helm upgrade` command (#2497) 2026-03-24 21:01:44 +08:00
constants.go
constants_test.go
context.go
context_test.go
dag_test.go
desired_state_file_loader.go fix: helmDefaults.postRendererArgs not passed to helm commands (#2510) 2026-04-16 11:08:15 +08:00
destroy_nokubectx_test.go
destroy_test.go
diff_nokubectx_test.go
diff_test.go
errors.go
errors_test.go
formatters.go
formatters_test.go
init.go build: update helm-diff to v3.15.3 (#2498) 2026-03-24 17:28:41 +08:00
init_test.go
load_opts.go fix: update state values files handling to replace arrays instead of merging (#2537) 2026-04-13 19:46:15 +08:00
load_opts_test.go fix: update state values files handling to replace arrays instead of merging (#2537) 2026-04-13 19:46:15 +08:00
print_env.go
print_env_test.go
run.go fix: cleanup hooks not receiving error signal (#2475) 2026-03-21 14:29:32 +08:00
snapshot_test.go
two_pass_renderer.go
two_pass_renderer_test.go
validate_config.go
validate_config_test.go