vulragrag-starandyxxhero d4a4135f9b fix: cancel kubedog-tracked helm subprocesses on SIGINT/SIGTERM (#2791) ...

* fix: cancel kubedog-tracked helm subprocesses on SIGINT/SIGTERM

Kubedog tracking rooted helm and tracker contexts at Background (via
traceOnlyContext), so App.Cancel never reached those subprocesses and
Ctrl+C blocked in CleanWaitGroup until helm exited on its own.

Thread the app cancel context into HelmState (SetCancelContext) and use
it for the three kubedog tracking call sites, keeping the per-release
WithCancel safety valve. Hooks stay on the non-canceling trace bridge.

Fixes #2770

Signed-off-by: Jason Wang <vulragrag@gmail.com>

* docs/test: align cancel-context docs with #2791 and pin the kubedog wiring

- traceOnlyContext comment no longer lists kubedog tracking among the
  detached paths; only hooks (#2771) remain, with a pointer to #2791.
- docs/proposals/otel-tracing.md sections 4.3/4.4/7/9 now mark the
  kubedog cancellation gap as fixed by #2791 (SetCancelContext), so the
  design doc stops misdescribing main.
- TestBufferHelmOutputRootsAtCancelContext pins the actual #2770 wiring:
  the context bufferHelmOutput hands to ContextSwapper.WithContext must
  become Done when the app cancel context is canceled, and stay
  non-cancelable when unset.

Signed-off-by: yxxhero <aiopsclub@163.com>

---------

Signed-off-by: Jason Wang <vulragrag@gmail.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
Co-authored-by: yxxhero <aiopsclub@163.com>

2026-09-15 07:35:09 +08:00

..

testdata

feat(state): add mergeStrategy: fallback for first-file-wins env values (#2578)

2026-05-07 21:50:05 +08:00

chart_dependencies_rewrite_test.go

fix: refresh Chart.lock after rewriting file:// dependencies (#2587)

2026-05-19 05:41:41 +08:00

chart_dependency_test.go

fix: helmfile deps broken for OCI charts with underscores in path (#2648)

2026-06-18 22:51:44 +08:00

chart_dependency.go

fix: helmfile deps broken for OCI charts with underscores in path (#2648)

2026-06-18 22:51:44 +08:00

create_test.go

fix: include release values in .Values for patch template rendering (#2556)

2026-06-15 16:31:46 +08:00

create.go

feat(state): add mergeStrategy: fallback for first-file-wins env values (#2578)

2026-05-07 21:50:05 +08:00

diff_error_propagation_test.go

feat: add Helm 4 support while maintaining Helm 3 compatibility (#2262)

2025-11-19 07:49:30 +08:00

environment.go

feat(state): add mergeStrategy: fallback for first-file-wins env values (#2578)

2026-05-07 21:50:05 +08:00

envvals_loader_test.go

feat(state): add mergeStrategy: fallback for first-file-wins env values (#2578)

2026-05-07 21:50:05 +08:00

envvals_loader.go

feat(state): add mergeStrategy: fallback for first-file-wins env values (#2578)

2026-05-07 21:50:05 +08:00

helmx_test.go

feat: parallel kubedog tracking with progress printer and safety valves (#2654)

2026-06-21 13:43:17 +08:00

helmx.go

fix: support go-getter URLs in ad-hoc dependencies to fix #821 (#2670)

2026-06-28 15:28:05 +08:00

inherited_test.go

feat: add inherits: for sub-helmfile config inheritance (#2680)

2026-07-01 14:44:16 +08:00

inherited.go

feat: add inherits: for sub-helmfile config inheritance (#2680)

2026-07-01 14:44:16 +08:00

inherits_yaml_test.go

feat: add inherits: for sub-helmfile config inheritance (#2680)

2026-07-01 14:44:16 +08:00

issue923_test.go

feat: allow helmfile to continue on failed releases (#2616)

2026-09-03 06:26:46 +08:00

issue_768_test.go

fix: serialize concurrent helm operations for same chart to fix #768 (#2662)

2026-06-25 14:37:04 +08:00

issue_821_test.go

fix: support go-getter URLs in ad-hoc dependencies to fix #821 (#2670)

2026-06-28 15:28:05 +08:00

issue_1757_test.go

refactor: drop empty-render workaround now that chartify handles it natively (#2747)

2026-08-16 10:47:19 +08:00

issue_1799_test.go

fix: clean up chartify temp directories after helm operations (#2668)

2026-06-28 11:55:31 +08:00

issue_2297_test.go

fix: resolve issues #2295, #2296, and #2297 (#2298)

2025-11-27 22:13:03 +08:00

issue_2355_test.go

feat: add --template-args flag to template/apply/sync for helm lookup() support (#2666)

2026-06-28 12:19:33 +08:00

issue_2444_test.go

feat: add --template-args flag to template/apply/sync for helm lookup() support (#2666)

2026-06-28 12:19:33 +08:00

issue_2549_test.go

Honor skipSchemaValidation during chartification when forceNamespace is set (#2550)

2026-04-30 12:30:41 -04:00

issue_2596_test.go

fix: normalize dependency chart path before DirectoryExistsAt check (#2598)

2026-05-20 08:44:14 +08:00

issue_2616_test.go

feat: allow helmfile to continue on failed releases (#2616)

2026-09-03 06:26:46 +08:00

issue_2741_test.go

feat: allow helmfile to continue on failed releases (#2616)

2026-09-03 06:26:46 +08:00

issue_2766_test.go

fix: resolve OCI version constraints before deriving the shared chart cache path (#2768)

2026-09-07 16:50:25 +08:00

llm_field_test.go

feat: add helmfile doctor command for AI-assisted diff analysis (#2660)

2026-06-22 16:52:35 +08:00

oci_chart_lock_test.go

fix: skip cache refresh for shared cache paths to prevent race conditions (#2396)

2026-02-14 10:46:05 +08:00

oci_chart_version_test.go

fix: support OCI chart digest syntax (@sha256:...) (#2398)

2026-02-12 20:20:43 +08:00

oci_parse_test.go

fix: support OCI chart digest syntax (@sha256:...) (#2398)

2026-02-12 20:20:43 +08:00

release_error.go

…

release_filters_test.go

fix: skip subhelmfiles when selectors conflict with CLI selectors (#2545)

2026-04-25 17:18:39 +08:00

release_filters.go

fix: skip subhelmfiles when selectors conflict with CLI selectors (#2545)

2026-04-25 17:18:39 +08:00

release_test.go

refactor(yaml): upgrade from gopkg.in/yaml.v2 to v3 (#2039)

2025-05-15 10:21:37 -04:00

release.go

feat: Add ConditionTemplate support in releaseSpec (#2669)

2026-07-01 18:44:43 +08:00

run_helm_dep_builds_skip_refresh_test.go

feat: allow helmfile to continue on failed releases (#2616)

2026-09-03 06:26:46 +08:00

selector_test.go

feat: add labels for helm release (#1046)

2025-03-30 19:24:41 -04:00

skip_test.go

Fix four critical bugs: array merging (#2281), AWS SDK logging (#2270), helmDefaults skip flags (#2269), and OCI chart versions (#2247) (#2288)

2025-11-22 09:27:51 +08:00

span_test.go

fix: cancel kubedog-tracked helm subprocesses on SIGINT/SIGTERM (#2791)

2026-09-15 07:35:09 +08:00

span.go

fix: cancel kubedog-tracked helm subprocesses on SIGINT/SIGTERM (#2791)

2026-09-15 07:35:09 +08:00

state_exec_tmpl_test.go

feat: Add ConditionTemplate support in releaseSpec (#2669)

2026-07-01 18:44:43 +08:00

state_exec_tmpl.go

feat: Add ConditionTemplate support in releaseSpec (#2669)

2026-07-01 18:44:43 +08:00

state_gogetter_test.go

…

state_kubeversion_test.go

🐛 Fix four critical issues: environment merging, kubeVersion detection, lookup() with kustomize, and Helm 4 color flags (#2276)

2025-11-21 08:32:54 +08:00

state_run.go

feat: opt-in OpenTelemetry tracing and metrics (experimental) (#2769)

2026-09-07 20:34:10 +08:00

state_test.go

fix: resolve OCI version constraints before deriving the shared chart cache path (#2768)

2026-09-07 16:50:25 +08:00

state.go

fix: cancel kubedog-tracked helm subprocesses on SIGINT/SIGTERM (#2791)

2026-09-15 07:35:09 +08:00

storage_test.go

feat(remote): support wildcards in remote values/secrets file selectors (#2787)

2026-09-13 09:16:26 +08:00

storage.go

feat(remote): support wildcards in remote values/secrets file selectors (#2787)

2026-09-13 09:16:26 +08:00

temp_test.go

fix: resolve OCI version constraints before deriving the shared chart cache path (#2768)

2026-09-07 16:50:25 +08:00

temp.go

…

types_test.go

fix: boolean false overrides dropped in multi-document helmfiles (#2527) (#2532)

2026-04-12 09:44:49 +08:00

types.go

fix: boolean false overrides dropped in multi-document helmfiles (#2527) (#2532)

2026-04-12 09:44:49 +08:00

util_test.go

…

util.go

fix: resolve OCI version constraints before deriving the shared chart cache path (#2768)

2026-09-07 16:50:25 +08:00