mirror of
https://github.com/helmfile/helmfile.git
synced 2026-09-30 14:47:44 +02:00
yxxheroandClaude
ad81e4231e
Toolchain and CI:
- Bump go directive from 1.26.8 to 1.27.1 (go.mod)
- Use golang:1.27-alpine builder images in all Dockerfiles
- Bump golangci-lint to v2.13.2 (first release with go1.27 support)
- Add CI gate: `go fix -diff` fails when outdated Go patterns are
detected (locally: `make check-modernize`)
Note: darwin binaries now require macOS 13 or later.
Lint fixes required by golangci-lint v2.13.2:
- goconst: ignore tests (all 436 findings were test-only; goconst
got stricter since v2.12 and this option was added for it)
- openai.go: keep deprecated MaxTokens deliberately with a nolint
rationale (max_tokens is the only form universally supported by
OpenAI-compatible backends like One-API, LiteLLM, Ollama shim)
- state.go: drop always-nil flags param from appendChartVersionFlags
(renamed to chartVersionFlags, unparam)
Modernization (go fix ./..., 62 files):
- interface{} -> any, maps.Copy, strings.SplitSeq, range-over-int,
builtin min/max, slices.Contains/ContainsFunc/Sort, WaitGroup.Go,
reflect.Type.Fields(), new(expr)
- exit_error.go: strings.Builder + fmt.Fprintf instead of string
concatenation and WriteString(fmt.Sprintf(...)) (QF1012)
- chart_dependency.go: strings.CutLast for OCI dependency helpers
Signed-off-by: yxxhero <aiopsclub@163.com>
Co-authored-by: Claude <noreply@anthropic.com>
118 lines
3.9 KiB
Go
118 lines
3.9 KiB
Go
package state
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
// TestSkipDepsAndSkipRefresh tests that helmDefaults.skipDeps and helmDefaults.skipRefresh
|
|
// are properly applied when preparing charts (issue #2269)
|
|
func TestSkipDepsAndSkipRefresh(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
helmDefaultsSkipDeps bool
|
|
helmDefaultsSkipRefresh bool
|
|
releaseSkipDeps *bool
|
|
releaseSkipRefresh *bool
|
|
optsSkipDeps bool
|
|
optsSkipRefresh bool
|
|
isLocal bool
|
|
expectedSkipDeps bool
|
|
expectedSkipRefresh bool
|
|
}{
|
|
{
|
|
name: "helmDefaults.skipDeps=true should skip deps",
|
|
helmDefaultsSkipDeps: true,
|
|
helmDefaultsSkipRefresh: false,
|
|
releaseSkipDeps: nil,
|
|
releaseSkipRefresh: nil,
|
|
optsSkipDeps: false,
|
|
optsSkipRefresh: false,
|
|
isLocal: true,
|
|
expectedSkipDeps: true,
|
|
expectedSkipRefresh: false,
|
|
},
|
|
{
|
|
name: "helmDefaults.skipRefresh=true should skip refresh",
|
|
helmDefaultsSkipDeps: false,
|
|
helmDefaultsSkipRefresh: true,
|
|
releaseSkipDeps: nil,
|
|
releaseSkipRefresh: nil,
|
|
optsSkipDeps: false,
|
|
optsSkipRefresh: false,
|
|
isLocal: true,
|
|
expectedSkipDeps: false,
|
|
expectedSkipRefresh: true,
|
|
},
|
|
{
|
|
name: "both helmDefaults.skipDeps and skipRefresh=true",
|
|
helmDefaultsSkipDeps: true,
|
|
helmDefaultsSkipRefresh: true,
|
|
releaseSkipDeps: nil,
|
|
releaseSkipRefresh: nil,
|
|
optsSkipDeps: false,
|
|
optsSkipRefresh: false,
|
|
isLocal: true,
|
|
expectedSkipDeps: true,
|
|
expectedSkipRefresh: true,
|
|
},
|
|
{
|
|
name: "release.skipRefresh overrides helmDefaults",
|
|
helmDefaultsSkipDeps: false,
|
|
helmDefaultsSkipRefresh: false,
|
|
releaseSkipDeps: nil,
|
|
releaseSkipRefresh: new(true),
|
|
optsSkipDeps: false,
|
|
optsSkipRefresh: false,
|
|
isLocal: true,
|
|
expectedSkipDeps: false,
|
|
expectedSkipRefresh: true,
|
|
},
|
|
{
|
|
name: "opts.SkipRefresh (CLI flag) has priority",
|
|
helmDefaultsSkipDeps: false,
|
|
helmDefaultsSkipRefresh: false,
|
|
releaseSkipDeps: nil,
|
|
releaseSkipRefresh: nil,
|
|
optsSkipDeps: false,
|
|
optsSkipRefresh: true,
|
|
isLocal: true,
|
|
expectedSkipDeps: false,
|
|
expectedSkipRefresh: true,
|
|
},
|
|
{
|
|
name: "non-local chart always skips refresh",
|
|
helmDefaultsSkipDeps: false,
|
|
helmDefaultsSkipRefresh: false,
|
|
releaseSkipDeps: nil,
|
|
releaseSkipRefresh: nil,
|
|
optsSkipDeps: false,
|
|
optsSkipRefresh: false,
|
|
isLocal: false,
|
|
expectedSkipDeps: true, // non-local charts skip deps
|
|
expectedSkipRefresh: true, // non-local charts skip refresh
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
// Calculate skipDeps using the actual logic from state.go
|
|
skipDepsGlobal := tt.optsSkipDeps
|
|
skipDepsRelease := tt.releaseSkipDeps != nil && *tt.releaseSkipDeps
|
|
skipDepsDefault := tt.releaseSkipDeps == nil && tt.helmDefaultsSkipDeps
|
|
chartFetchedByGoGetter := false
|
|
skipDeps := (!tt.isLocal && !chartFetchedByGoGetter) || skipDepsGlobal || skipDepsRelease || skipDepsDefault
|
|
|
|
// Calculate skipRefresh using the actual logic from state.go (after fix)
|
|
skipRefreshGlobal := tt.optsSkipRefresh
|
|
skipRefreshRelease := tt.releaseSkipRefresh != nil && *tt.releaseSkipRefresh
|
|
skipRefreshDefault := tt.releaseSkipRefresh == nil && tt.helmDefaultsSkipRefresh
|
|
skipRefresh := !tt.isLocal || skipRefreshGlobal || skipRefreshRelease || skipRefreshDefault
|
|
|
|
assert.Equal(t, tt.expectedSkipDeps, skipDeps, "skipDeps mismatch")
|
|
assert.Equal(t, tt.expectedSkipRefresh, skipRefresh, "skipRefresh mismatch")
|
|
})
|
|
}
|
|
}
|