yxxheroandcopilot-swe-agent[bot] acb7ce36fc fix: add mutex lock for concurrent rewriteChartDependencies access (#2509) ...

* fix: add mutex lock for concurrent rewriteChartDependencies access

Prevent race conditions when multiple goroutines concurrently access
the same Chart.yaml by introducing a per-chart-path mutex via sync.Map.

Signed-off-by: yxxhero <yxxhero@users.noreply.github.com>
Signed-off-by: yxxhero <aiopsclub@163.com>

* fix: unlock mutex on all error paths and improve race condition test validation

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/135e06b8-99e8-42cb-859d-524b2d2b1907

Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>

* fix: remove duplicate mutex, reuse getNamedRWMutex, restore on write failure, add test barrier

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/f93746bf-82fa-46b1-b8f0-b34bc9aa749c

Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>

* fix: early unlock when unmodified, assert exact restore in race test

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/5981aea4-2799-4560-9272-315d28d4b7d7

Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>

* fix: improve comment wording and strengthen race test start barrier

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/9e4d6f4f-cdc1-4e9e-bdc6-81061ebc1dcc

Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>

---------

Signed-off-by: yxxhero <yxxhero@users.noreply.github.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

2026-04-13 11:59:52 +08:00

..

testdata

…

chart_dependencies_rewrite_test.go

fix: add mutex lock for concurrent rewriteChartDependencies access (#2509)

2026-04-13 11:59:52 +08:00

chart_dependency_test.go

…

chart_dependency.go

fix: helmfile list now reflects version from helmfile.lock (#2486)

2026-03-19 14:25:03 +08:00

create_test.go

fix: helmBinary setting ignored in multi-document YAML files (#2414)

2026-02-20 22:12:38 +08:00

create.go

fix: helmBinary setting ignored in multi-document YAML files (#2414)

2026-02-20 22:12:38 +08:00

diff_error_propagation_test.go

feat: add Helm 4 support while maintaining Helm 3 compatibility (#2262)

2025-11-19 07:49:30 +08:00

environment.go

feat(state): add missingFileHandlerConfig and related logic (#2105)

2025-07-21 19:15:51 -04:00

envvals_loader_test.go

…

envvals_loader.go

fix: array merge regression - layer arrays now replace defaults (#2367)

2026-01-18 14:04:54 +08:00

helmx_test.go

fix: use --force-replace flag for Helm 4 instead of deprecated --force (#2477)

2026-03-11 21:23:51 +08:00

helmx.go

fix: helmfile fetch fails for kustomization directories (#2504)

2026-03-26 09:44:28 +08:00

issue_2297_test.go

fix: resolve issues #2295, #2296, and #2297 (#2298)

2025-11-27 22:13:03 +08:00

issue_2355_test.go

fix: resolve --validate flag conflict with kustomize in Helm 4 (#2362)

2026-01-18 13:59:55 +08:00

issue_2444_test.go

fix: pass --kubeconfig to chartify's helm template call (#2449)

2026-03-03 20:56:46 +08:00

oci_chart_lock_test.go

fix: skip cache refresh for shared cache paths to prevent race conditions (#2396)

2026-02-14 10:46:05 +08:00

oci_chart_version_test.go

fix: support OCI chart digest syntax (@sha256:...) (#2398)

2026-02-12 20:20:43 +08:00

oci_parse_test.go

fix: support OCI chart digest syntax (@sha256:...) (#2398)

2026-02-12 20:20:43 +08:00

release_error.go

…

release_filters_test.go

…

release_filters.go

…

release_test.go

…

release.go

…

run_helm_dep_builds_skip_refresh_test.go

fix: local chart with external dependencies error when repos configured (#2433)

2026-02-28 09:23:04 +08:00

selector_test.go

…

skip_test.go

Fix four critical bugs: array merging (#2281), AWS SDK logging (#2270), helmDefaults skip flags (#2269), and OCI chart versions (#2247) (#2288)

2025-11-22 09:27:51 +08:00

state_exec_tmpl_test.go

…

state_exec_tmpl.go

…

state_gogetter_test.go

…

state_kubeversion_test.go

🐛 Fix four critical issues: environment merging, kubeVersion detection, lookup() with kustomize, and Helm 4 color flags (#2276)

2025-11-21 08:32:54 +08:00

state_run.go

…

state_test.go

feat: add an arg that passing description to helm upgrade command (#2497)

2026-03-24 21:01:44 +08:00

state.go

fix: add mutex lock for concurrent rewriteChartDependencies access (#2509)

2026-04-13 11:59:52 +08:00

storage_test.go

fix: array merge regression - layer arrays now replace defaults (#2367)

2026-01-18 14:04:54 +08:00

storage.go

fix: eliminate os.Chdir in sequential helmfiles to fix relative path resolution (#2410)

2026-02-22 09:21:46 +08:00

temp_test.go

feat: add an arg that passing description to helm upgrade command (#2497)

2026-03-24 21:01:44 +08:00

temp.go

…

types_test.go

fix: boolean false overrides dropped in multi-document helmfiles (#2527) (#2532)

2026-04-12 09:44:49 +08:00

types.go

fix: boolean false overrides dropped in multi-document helmfiles (#2527) (#2532)

2026-04-12 09:44:49 +08:00

util_test.go

…

util.go

…