mirror of
https://github.com/helmfile/helmfile.git
synced 2026-10-03 19:00:49 +02:00
* feat: add --template-args to enable helm lookup() during template/apply/sync (#1833) Add a --template-args flag to the template, apply, and sync subcommands so extra args (most notably --dry-run=server) can be passed to the helm template invocation, enabling Helm's lookup() function to resolve live cluster values. - template: --template-args reaches both chartify's pre-render helm template and the final helm template output (flagsForTemplate). - apply/sync: --template-args reaches chartify's pre-render helm template. apply/sync already inject --dry-run=server automatically for cluster operations; the flag is an explicit opt-in for the template subcommand or for passing additional flags. - When --dry-run is present in template args, kube-context/kubeconfig are also injected into chartify so lookup() can actually reach the cluster. - Resolves the long-stale PR #1833 rebased onto current main, which already contains the cluster-connectivity infrastructure (issues #2271, #2309, #2355, #2444). - Includes integration test (lookup.sh) covering both chartify and non-chartify scenarios. Signed-off-by: yxxhero <aiopsclub@163.com> * test: make lookup template nil-safe to fix integration CI The lookup() function returns an empty map when the chart is rendered without a cluster connection (notably the helm-diff phase of `helmfile apply`). The original fixture chained `index` over the lookup result, panicking with "index of untyped nil" during apply's diff rendering. Guard every index with `default dict` so the template falls back to "overwritten" when lookup is empty, while still resolving to the live value ("init") when cluster access is available (--dry-run=server via --template-args, or a real helm upgrade). Signed-off-by: yxxhero <aiopsclub@163.com> * feat: enable lookup() during apply/diff via --template-args in helm-diff Thread --template-args into the helm-diff rendering path so that `helmfile apply`/`diff --template-args="--dry-run=server"` resolves Helm's lookup() function during the diff phase too. helm-diff supports `--dry-run=server`, which explicitly "enables the cluster access ... and the lookup template function". Previously --template-args only reached chartify's pre-render (which is a no-op for plain charts due to chartify's early-return when there is no forceNamespace/patches/injections) and the final `helm template` of the `template` subcommand. As a result `helmfile apply` on a lookup chart rendered client-side during the diff phase. Changes: - pkg/state: add TemplateArgs to DiffOpts; append it in appendExtraDiffFlags (reaches every helm-diff invocation: apply, standalone diff, interactive sync), mirroring the existing flagsForTemplate handling. - pkg/config + cmd: add --template-args to the diff/doctor commands and to DiffConfigProvider, so lookup works for `helmfile diff` as well. - pkg/app: populate DiffOpts.TemplateArgs from apply/diff/sync-interactive. - docs/cli.md: correct the previous overpromising wording and document diff support plus the nil-safe lookup guidance. - tests: unit-test the TemplateArgs handling in appendExtraDiffFlags and flagsForTemplate; integration lookup.sh now exercises apply with --template-args="--dry-run=server". Signed-off-by: yxxhero <aiopsclub@163.com> * refactor: de-duplicate chartify template-args logic, add helmDefaults.templateArgs Address review feedback on #2666: 1. Eliminate stale duplicated test helpers (issue_2444_test.go, issue_2355_test.go). Both files intentionally copied the processChartification flag-building logic with explicit SYNC WARNING comments, then drifted out of sync when #2666 refactored the production code (needsKubeConnection gate, user-args merge). Extract the real logic into pure, unit-tested helpers (buildChartifyTemplateArgs, commandRequiresCluster) and delete the copies. 2. Add unit coverage for the new chartify merge path: template + --template-args=--dry-run=server now triggers kubeconfig/kube-context injection (TestTemplateArgsDryRunTriggersKubeInjection, TestTemplateArgsMergedBeforeInjection) — previously only covered by the cluster-dependent integration test. 3. Add a negative integration case (lookup.sh assert_template_fallback) verifying lookup() falls back to the default value WITHOUT --template-args, guarding against a regression that silently always connects to the cluster. 4. Add helmDefaults.templateArgs for parity with diffArgs/syncArgs, so users can enable lookup() support permanently instead of passing the flag on every invocation. CLI --template-args overrides (does not merge with) the default. Resolved via effectiveTemplateArgs, wired into the chartify, flagsForTemplate, and appendExtraDiffFlags paths. 5. Minor: capitalize --template-args help text to match surrounding flags; document helmDefaults.templateArgs precedence in docs/cli.md. Signed-off-by: yxxhero <aiopsclub@163.com> * test: cover helmDefaults->chartify composition; fix helm helm-diff typo Address remaining review nits on #2666: - Add TestHelmDefaultsTemplateArgsReachesChartify, a belt-and-suspenders test for the processChartification composition (effectiveTemplateArgs -> buildChartifyTemplateArgs), closing the last unit-level coverage gap for helmDefaults.templateArgs reaching the chartify path. - Fix pre-existing typo in cmd/bind_diff_flags.go: 'pass args to helm helm-diff' -> 'Pass args to helm-diff' (doubled 'helm', lowercase). Signed-off-by: yxxhero <aiopsclub@163.com> * fix: correct 'helm helm-diff' typo in apply --diff-args help text Sibling of the bind_diff_flags.go fix; the same doubled-'helm' typo and lowercase help existed in cmd/apply.go's --diff-args registration, leaving the apply and diff/doctor help strings inconsistent. Signed-off-by: yxxhero <aiopsclub@163.com> * docs: add helmDefaults.templateArgs to configuration reference The complete helmfile.yaml schema in docs/configuration.md documents diffArgs and syncArgs under helmDefaults but was missing the new templateArgs field added in #2666. Add it beside syncArgs for discoverability, noting the --template-args CLI override. Signed-off-by: yxxhero <aiopsclub@163.com> --------- Signed-off-by: yxxhero <aiopsclub@163.com>
369 lines
11 KiB
Go
369 lines
11 KiB
Go
package config
|
|
|
|
import (
|
|
"fmt"
|
|
"slices"
|
|
)
|
|
|
|
// ApplyOptoons is the options for the apply command
|
|
type ApplyOptions struct {
|
|
// Set is a list of key value pairs to be merged into the command
|
|
Set []string
|
|
// Values is a list of value files to be merged into the command
|
|
Values []string
|
|
// Concurrency is the maximum number of concurrent helm processes to run
|
|
Concurrency int
|
|
// Validate is validate your manifests against the Kubernetes cluster you are currently pointing at. Note that this requires access to a Kubernetes cluster to obtain information necessary for validating, like the list of available API versions
|
|
Validate bool
|
|
// Context is the number of lines of context to show around changes
|
|
Context int
|
|
// Output is the output format for the diff plugin
|
|
Output string
|
|
// DetailedExitcode is true if the exit code should be 2 instead of 0 if there were changes detected and the changes were synced successfully
|
|
DetailedExitcode bool
|
|
// StripTrailingCR is true if trailing carriage returns should be stripped during diffing
|
|
StripTrailingCR bool
|
|
// SkipCleanup is true if the cleanup of temporary values files should be skipped
|
|
SkipCleanup bool
|
|
// SkipCRDs is true if the CRDs should be skipped
|
|
SkipCRDs bool
|
|
// SkipNeeds is true if the needs should be skipped
|
|
SkipNeeds bool
|
|
// IncludeNeeds is true if the needs should be included
|
|
IncludeNeeds bool
|
|
// IncludeTransitiveNeeds is true if the transitive needs should be included
|
|
IncludeTransitiveNeeds bool
|
|
// EnforceNeedsAreInstalled is true if we should error if/when there are unmeetable dependencies
|
|
EnforceNeedsAreInstalled bool
|
|
// SkipDiffOnInstall is true if the diff should be skipped on install
|
|
SkipDiffOnInstall bool
|
|
// DiffArgs is the list of arguments to pass to the helm-diff.
|
|
DiffArgs string
|
|
// IncludeTests is true if the tests should be included
|
|
IncludeTests bool
|
|
// Suppress is true if the output should be suppressed
|
|
Suppress []string
|
|
// SuppressSecrets is true if the secrets should be suppressed
|
|
SuppressSecrets bool
|
|
// ShowSecrets is true if the secrets should be shown
|
|
ShowSecrets bool
|
|
// NoHooks skips checking for hooks
|
|
NoHooks bool
|
|
// SuppressDiff is true if the diff should be suppressed
|
|
SuppressDiff bool
|
|
// Wait is true if the helm command should wait for the release to be deployed
|
|
Wait bool
|
|
// WaitRetries is the number of times to retry waiting for the release to be deployed
|
|
WaitRetries int
|
|
// WaitForJobs is true if the helm command should wait for the jobs to be completed
|
|
WaitForJobs bool
|
|
// Timeout is the timeout for helm operations in seconds
|
|
Timeout int
|
|
// Propagate '--skip-schema-validation' to helmv3 template and helm install
|
|
SkipSchemaValidation bool
|
|
// ReuseValues is true if the helm command should reuse the values
|
|
ReuseValues bool
|
|
// ResetValues is true if helm command should reset values to charts' default
|
|
ResetValues bool
|
|
// Propagate '--post-renderer' to helmv3 template and helm install
|
|
PostRenderer string
|
|
// Propagate '--post-renderer-args' to helmv3 template and helm install
|
|
PostRendererArgs []string
|
|
// Cascade '--cascade' to helmv3 delete, available values: background, foreground, or orphan, default: background
|
|
Cascade string
|
|
// SuppressOutputLineRegex is a list of regexes to suppress output lines
|
|
SuppressOutputLineRegex []string
|
|
// SyncArgs is the list of arguments to pass to helm upgrade.
|
|
SyncArgs string
|
|
// HideNotes is the hide notes flag
|
|
HideNotes bool
|
|
|
|
// TakeOwnership is true if the ownership should be taken
|
|
TakeOwnership bool
|
|
|
|
// ServerSide controls the helm 4 --server-side flag. Must be "true", "false", or "auto".
|
|
ServerSide string
|
|
|
|
SyncReleaseLabels bool
|
|
// TrackMode specifies whether to use 'helm' or 'kubedog' for tracking resources
|
|
TrackMode string
|
|
// TrackTimeout specifies timeout for kubedog tracking (in seconds)
|
|
TrackTimeout int
|
|
// TrackLogs enables log streaming with kubedog
|
|
TrackLogs bool
|
|
// TrackFailedLogs streams logs only for pods that enter a failed state.
|
|
TrackFailedLogs bool
|
|
// HelmStuckGrace, when > 0, enables the helm-killer safety valve. See
|
|
// ReleaseSpec.HelmStuckGrace for details. Value is in seconds.
|
|
HelmStuckGrace int
|
|
// TrackFailOnError controls whether kubedog tracking failures cause a non-zero exit code
|
|
TrackFailOnError bool
|
|
// Description is the description that will be passed to helm upgrade --description
|
|
Description string
|
|
// TemplateArgs are extra args appended to the helm template run by chartify
|
|
// during chart preparation (e.g. "--dry-run=server" for lookup() support).
|
|
TemplateArgs string
|
|
}
|
|
|
|
// NewApply creates a new Apply
|
|
func NewApplyOptions() *ApplyOptions {
|
|
return &ApplyOptions{}
|
|
}
|
|
|
|
// ApplyImpl is impl for applyOptions
|
|
type ApplyImpl struct {
|
|
*GlobalImpl
|
|
*ApplyOptions
|
|
}
|
|
|
|
// NewApplyImpl creates a new ApplyImpl
|
|
func NewApplyImpl(g *GlobalImpl, a *ApplyOptions) *ApplyImpl {
|
|
return &ApplyImpl{
|
|
GlobalImpl: g,
|
|
ApplyOptions: a,
|
|
}
|
|
}
|
|
|
|
// Set returns the set.
|
|
func (a *ApplyImpl) Set() []string {
|
|
return a.ApplyOptions.Set
|
|
}
|
|
|
|
// Concurrency returns the concurrency.
|
|
func (a *ApplyImpl) Concurrency() int {
|
|
return a.ApplyOptions.Concurrency
|
|
}
|
|
|
|
// Context returns the context.
|
|
func (a *ApplyImpl) Context() int {
|
|
return a.ApplyOptions.Context
|
|
}
|
|
|
|
// DetailedExitcode returns the detailed exitcode.
|
|
func (a *ApplyImpl) DetailedExitcode() bool {
|
|
return a.ApplyOptions.DetailedExitcode
|
|
}
|
|
|
|
// StripTrailingCR is true if trailing carriage returns should be stripped during diffing
|
|
func (a *ApplyImpl) StripTrailingCR() bool {
|
|
return a.ApplyOptions.StripTrailingCR
|
|
}
|
|
|
|
// DiffOutput returns the diff output.
|
|
func (a *ApplyImpl) DiffOutput() string {
|
|
return a.Output
|
|
}
|
|
|
|
// IncludeNeeds returns the include needs.
|
|
func (a *ApplyImpl) IncludeNeeds() bool {
|
|
return a.ApplyOptions.IncludeNeeds || a.IncludeTransitiveNeeds()
|
|
}
|
|
|
|
// IncludeTests returns the include tests.
|
|
func (a *ApplyImpl) IncludeTests() bool {
|
|
return a.ApplyOptions.IncludeTests
|
|
}
|
|
|
|
// IncludeTransitiveNeeds returns the include transitive needs.
|
|
func (a *ApplyImpl) IncludeTransitiveNeeds() bool {
|
|
return a.ApplyOptions.IncludeTransitiveNeeds
|
|
}
|
|
|
|
// EnforceNeedsAreInstalled is true we should error if/when there are unmeetable dependencies
|
|
func (a *ApplyImpl) EnforceNeedsAreInstalled() bool {
|
|
return a.ApplyOptions.EnforceNeedsAreInstalled
|
|
}
|
|
|
|
// ShowSecrets returns the show secrets.
|
|
func (a *ApplyImpl) ShowSecrets() bool {
|
|
return a.ApplyOptions.ShowSecrets
|
|
}
|
|
|
|
// NoHooks skips hooks.
|
|
func (a *ApplyImpl) NoHooks() bool {
|
|
return a.ApplyOptions.NoHooks
|
|
}
|
|
|
|
// SkipCRDs returns the skip crds.
|
|
func (a *ApplyImpl) SkipCRDs() bool {
|
|
return a.ApplyOptions.SkipCRDs
|
|
}
|
|
|
|
// SkipCleanup returns the skip cleanup.
|
|
func (a *ApplyImpl) SkipCleanup() bool {
|
|
return a.ApplyOptions.SkipCleanup
|
|
}
|
|
|
|
// SkipDiffOnInstall returns the skip diff on install.
|
|
func (a *ApplyImpl) SkipDiffOnInstall() bool {
|
|
return a.ApplyOptions.SkipDiffOnInstall
|
|
}
|
|
|
|
// DiffArgs is the list of arguments to pass to helm-diff.
|
|
func (a *ApplyImpl) DiffArgs() string {
|
|
return a.ApplyOptions.DiffArgs
|
|
}
|
|
|
|
// SkipNeeds returns the skip needs.
|
|
func (a *ApplyImpl) SkipNeeds() bool {
|
|
if !a.IncludeNeeds() {
|
|
return a.ApplyOptions.SkipNeeds
|
|
}
|
|
return false
|
|
}
|
|
|
|
// Suppress returns the suppress.
|
|
func (a *ApplyImpl) Suppress() []string {
|
|
return a.ApplyOptions.Suppress
|
|
}
|
|
|
|
// SuppressDiff returns the suppress diff.
|
|
func (a *ApplyImpl) SuppressDiff() bool {
|
|
return a.ApplyOptions.SuppressDiff
|
|
}
|
|
|
|
// SuppressSecrets returns the suppress secrets.
|
|
func (a *ApplyImpl) SuppressSecrets() bool {
|
|
return a.ApplyOptions.SuppressSecrets
|
|
}
|
|
|
|
// Validate returns the validate.
|
|
func (a *ApplyImpl) Validate() bool {
|
|
return a.ApplyOptions.Validate
|
|
}
|
|
|
|
// Values returns the values.
|
|
func (a *ApplyImpl) Values() []string {
|
|
return a.ApplyOptions.Values
|
|
}
|
|
|
|
// Wait returns the wait.
|
|
func (a *ApplyImpl) Wait() bool {
|
|
return a.ApplyOptions.Wait
|
|
}
|
|
|
|
// WaitRetries returns the wait retries.
|
|
func (a *ApplyImpl) WaitRetries() int {
|
|
return a.ApplyOptions.WaitRetries
|
|
}
|
|
|
|
// WaitForJobs returns the wait for jobs.
|
|
func (a *ApplyImpl) WaitForJobs() bool {
|
|
return a.ApplyOptions.WaitForJobs
|
|
}
|
|
|
|
// Timeout returns the timeout.
|
|
func (a *ApplyImpl) Timeout() int {
|
|
return a.ApplyOptions.Timeout
|
|
}
|
|
|
|
// ReuseValues returns the ReuseValues.
|
|
func (a *ApplyImpl) ReuseValues() bool {
|
|
if !a.ResetValues() {
|
|
return a.ApplyOptions.ReuseValues
|
|
}
|
|
return false
|
|
}
|
|
|
|
func (a *ApplyImpl) ResetValues() bool {
|
|
return a.ApplyOptions.ResetValues
|
|
}
|
|
|
|
// PostRenderer returns the PostRenderer.
|
|
func (a *ApplyImpl) PostRenderer() string {
|
|
return a.ApplyOptions.PostRenderer
|
|
}
|
|
|
|
// PostRendererArgs returns the PostRendererArgs.
|
|
func (a *ApplyImpl) PostRendererArgs() []string {
|
|
return a.ApplyOptions.PostRendererArgs
|
|
}
|
|
|
|
// SkipSchemaValidation returns the SkipSchemaValidation.
|
|
func (a *ApplyImpl) SkipSchemaValidation() bool {
|
|
return a.ApplyOptions.SkipSchemaValidation
|
|
}
|
|
|
|
// Cascade returns cascade flag
|
|
func (a *ApplyImpl) Cascade() string {
|
|
return a.ApplyOptions.Cascade
|
|
}
|
|
|
|
// SuppressOutputLineRegex returns the SuppressOutputLineRegex.
|
|
func (a *ApplyImpl) SuppressOutputLineRegex() []string {
|
|
return a.ApplyOptions.SuppressOutputLineRegex
|
|
}
|
|
|
|
// SyncArgs returns the SyncArgs.
|
|
func (a *ApplyImpl) SyncArgs() string {
|
|
return a.ApplyOptions.SyncArgs
|
|
}
|
|
|
|
// HideNotes returns the HideNotes.
|
|
func (a *ApplyImpl) HideNotes() bool {
|
|
return a.ApplyOptions.HideNotes
|
|
}
|
|
|
|
// TakeOwnership returns the TakeOwnership.
|
|
func (a *ApplyImpl) TakeOwnership() bool {
|
|
return a.ApplyOptions.TakeOwnership
|
|
}
|
|
|
|
// ServerSide returns the ServerSide.
|
|
func (a *ApplyImpl) ServerSide() string {
|
|
return a.ApplyOptions.ServerSide
|
|
}
|
|
|
|
// SyncReleaseLabels returns the SyncReleaseLabels.
|
|
func (a *ApplyImpl) SyncReleaseLabels() bool {
|
|
return a.ApplyOptions.SyncReleaseLabels
|
|
}
|
|
|
|
// TrackMode returns the track mode.
|
|
func (a *ApplyImpl) TrackMode() string {
|
|
return a.ApplyOptions.TrackMode
|
|
}
|
|
|
|
// TrackTimeout returns the track timeout.
|
|
func (a *ApplyImpl) TrackTimeout() int {
|
|
return a.ApplyOptions.TrackTimeout
|
|
}
|
|
|
|
// TrackLogs returns the track logs flag.
|
|
func (a *ApplyImpl) TrackLogs() bool {
|
|
return a.ApplyOptions.TrackLogs
|
|
}
|
|
|
|
// TrackFailedLogs returns the track-failed-logs flag.
|
|
func (a *ApplyImpl) TrackFailedLogs() bool {
|
|
return a.ApplyOptions.TrackFailedLogs
|
|
}
|
|
|
|
// HelmStuckGrace returns the helm-stuck-grace value (seconds, 0 = disabled).
|
|
func (a *ApplyImpl) HelmStuckGrace() int {
|
|
return a.ApplyOptions.HelmStuckGrace
|
|
}
|
|
|
|
// TrackFailOnError returns whether kubedog tracking failures should cause a non-zero exit code.
|
|
func (a *ApplyImpl) TrackFailOnError() bool {
|
|
return a.ApplyOptions.TrackFailOnError
|
|
}
|
|
|
|
// Description returns the description.
|
|
func (a *ApplyImpl) Description() string {
|
|
return a.ApplyOptions.Description
|
|
}
|
|
|
|
// TemplateArgs returns extra args to pass to chartify's helm template.
|
|
func (a *ApplyImpl) TemplateArgs() string {
|
|
return a.ApplyOptions.TemplateArgs
|
|
}
|
|
|
|
func (a *ApplyImpl) ValidateConfig() error {
|
|
validTrackModes := []string{"helm", "helm-legacy", "kubedog"}
|
|
if a.ApplyOptions.TrackMode != "" && !slices.Contains(validTrackModes, a.ApplyOptions.TrackMode) {
|
|
return fmt.Errorf("--track-mode must be 'helm', 'helm-legacy', or 'kubedog', got: %s", a.ApplyOptions.TrackMode)
|
|
}
|
|
return a.GlobalImpl.ValidateConfig()
|
|
}
|