a409b450cd
This improves the `helmfile sync` performance. From the code: `BuildDeps` is used only by `runHelmDepBuilds`, which only is used by `PrepareCharts` which is finally only used by `withPreparedCharts`. `withPreparedCharts` already does `SyncReposOnce` which means we do not have to refresh the local repository cache on each chart build. This is only supported in Helm v3. This seems to be mostly affecting helmfiles which have a lot of releases and those release charts use sub dependencies. I saw significant performance improvements for a helmfile with 45 releases, 2 repositories, and most of the charts also had their own dependencies. Results: Before the patch: * real 9m10.565s * real 9m38.335s * real 9m14.941s * real 5m13.106s (with cache) After the patch: * real 6m51.965s * real 6m36.605s * real 6m31.685s * real 3m0.271s (with cache) These were tested with: ``` rm -rf ~/.cache/helmfile ~/.cache/helm ~/.config/helm/repositories.* && helmfile sync ... ``` The result with `(with cache)` was without deleting the caches first. From these metrics it seems that the sync duration decreased 20-45% depending on the run, release count, dependencies and if the cache was used or not. As far as I understand, this should be backward-compatible change. Signed-off-by: Indrek Juhkam <indrek@urgas.eu> Signed-off-by: Indrek Juhkam <indrek@urgas.eu> |
||
|---|---|---|
| .. | ||
| context.go | ||
| context_test.go | ||
| exec.go | ||
| exec_test.go | ||
| exit_error.go | ||
| helmexec.go | ||
| id.go | ||
| id_test.go | ||
| log.go | ||
| runner.go | ||
| runner_test.go | ||