When using helmfile with the following setup
```
releases:
- name: my-app
chart: ./mychart
trackMode: kubedog
trackLogs: true
trackFailOnError: true
```
We don't actually see any logs from the container being printed.
This is because when building the options for the Kubedog tracker, we never
specify `SaveLogsOnlyForNumberOfReplicas` which means this defaults to 0.
Looking at the logic in `pkg/tracker/deployment/tracker.go` we see
```
ignoreLogs := job.ignoreLogs || job.savingLogsReplicas >= job.SaveLogsOnlyForNumberOfReplicas
```
With job.SaveLogsOnlyForNumberOfReplicas always defaulting to 0, this will always ignore logs
This change sets it to a reasonable default of tracking logs from up to 10 pods.
Signed-off-by: Graeme Gillies <ggillies@gitlab.com>
|
||
|---|---|---|
| .. | ||
| app | ||
| argparser | ||
| cluster | ||
| config | ||
| environment | ||
| envvar | ||
| errors | ||
| event | ||
| exectest | ||
| filesystem | ||
| hcllang | ||
| helmexec | ||
| kubedog | ||
| maputil | ||
| plugins | ||
| policy | ||
| remote | ||
| resource | ||
| runtime | ||
| state | ||
| testhelper | ||
| testutil | ||
| tmpl | ||
| yaml | ||