mirror of
https://github.com/helmfile/helmfile.git
synced 2026-09-30 11:28:08 +02:00
yxxhero
7bebfab71a
* feat: add --repo-retries for retrying helm repo and registry login commands Add a configurable retry mechanism for chart repository operations to handle unstable networks (corporate proxies, slow internal registries). Closes #1894 - New --repo-retries N flag and HELMFILE_REPO_RETRIES env var (default 0 = opt-in, backward compatible) - Retry applies to helm repo add, helm repo update (incl. ACR), and helm registry login with exponential backoff (1s, 2s, 4s, ..., capped 30s) - Single retryRepoOp helper; per-attempt args/buffer are local to avoid state leaking across retries - Tests cover succeed-after-retry, exhausted-retries, disabled-by-default, and regression guards for password-buffer and args-accumulation Signed-off-by: yxxhero <aiopsclub@163.com> * fix: address PR review (overflow guard, cancellable sleep, flag-override, docs) Address Copilot review feedback on #2683: - Cap backoff shift exponent at 5 to prevent time.Duration overflow on large --repo-retries values - Make retry sleep context-aware (sleepCtx) so Ctrl+C aborts the retry loop promptly via the ShellRunner context - Log a concise exit status instead of the verbose ExitError dump, and clarify the retry-counter wording ('retry N/M') - Use -1 sentinel as the CLI default so --repo-retries=0 can explicitly disable retries even when HELMFILE_REPO_RETRIES is set - Align help text and docs: retry applies 'on failure' (not just transient errors), document the 0-disables behavior - Add tests for overflow guard, cancellable sleep, and flag-zero-disables Signed-off-by: yxxhero <aiopsclub@163.com> * fix: abort retries on canceled context, hide sentinel default, align comment Address follow-up Copilot review on #2683: - Fix tight-loop bug: sleepCtx now returns whether it completed vs was interrupted by context cancellation, and retryRepoOp aborts the retry loop on interruption so Ctrl+C no longer spins into rapid helm calls - Hide the -1 sentinel from --help by overriding the displayed default to 0 (pflag DefValue), matching the documented default while keeping the flag-override semantics - Correct HelmExecOptions.RepoRetry comment: 'on failure' not 'transient network errors', matching the actual retry behavior - Add Test_Retry_AbortsOnCanceledContext covering the no-tight-loop path Signed-off-by: yxxhero <aiopsclub@163.com> * fix: copy args per retry in RegistryLogin, make cancel test deterministic Address follow-up Copilot review on #2683: - RegistryLogin: pass a per-attempt copy of args to execStdIn so its internal append (for helm.extra) can't alias the shared slice across retries - Test_Retry_AbortsOnCanceledContext: cancel the context deterministically inside the op closure after the first attempt, replacing the flaky time.Sleep(20ms) goroutine Signed-off-by: yxxhero <aiopsclub@163.com> * fix: return error on unknown managed repo type instead of silent skip Address Copilot review on #2683: AddRepo logged an error for an unknown managed type but returned nil, silently succeeding while skipping the repo add. Now returns an error so misconfigurations fail loudly. Signed-off-by: yxxhero <aiopsclub@163.com> --------- Signed-off-by: yxxhero <aiopsclub@163.com>
49 lines
2.5 KiB
Go
49 lines
2.5 KiB
Go
package envvar
|
|
|
|
const (
|
|
DisableInsecureFeatures = "HELMFILE_DISABLE_INSECURE_FEATURES"
|
|
DisableInsecureTemplateFunctions = "HELMFILE_DISABLE_INSECURE_TEMPLATE_FUNCTIONS"
|
|
DisableHooks = "HELMFILE_DISABLE_HOOKS"
|
|
|
|
// use helm status to check if a release exists before installing it
|
|
UseHelmStatusToCheckReleaseExistence = "HELMFILE_USE_HELM_STATUS_TO_CHECK_RELEASE_EXISTENCE"
|
|
|
|
DisableRunnerUniqueID = "HELMFILE_DISABLE_RUNNER_UNIQUE_ID"
|
|
Experimental = "HELMFILE_EXPERIMENTAL" // environment variable for experimental features, expecting "true" lower case
|
|
Environment = "HELMFILE_ENVIRONMENT"
|
|
KubeContext = "HELMFILE_KUBE_CONTEXT"
|
|
Namespace = "HELMFILE_NAMESPACE"
|
|
HelmBinary = "HELMFILE_HELM_BINARY"
|
|
KustomizeBinary = "HELMFILE_KUSTOMIZE_BINARY"
|
|
LogLevel = "HELMFILE_LOG_LEVEL"
|
|
Debug = "HELMFILE_DEBUG"
|
|
Quiet = "HELMFILE_QUIET"
|
|
NoColor = "HELMFILE_NO_COLOR"
|
|
FilePath = "HELMFILE_FILE_PATH"
|
|
TempDir = "HELMFILE_TEMPDIR"
|
|
UpgradeNoticeDisabled = "HELMFILE_UPGRADE_NOTICE_DISABLED"
|
|
GoYamlV3 = "HELMFILE_GO_YAML_V3"
|
|
CacheHome = "HELMFILE_CACHE_HOME"
|
|
Interactive = "HELMFILE_INTERACTIVE"
|
|
RepoRetry = "HELMFILE_REPO_RETRIES"
|
|
RenderYaml = "HELMFILE_RENDER_YAML" // force helmfile.yaml to be rendered as template regardless of extension, expecting "true" lower case
|
|
|
|
// AWSSDKLogLevel controls AWS SDK logging level
|
|
// Valid values: "off" (default), "minimal", "standard", "verbose", or custom (e.g., "request,response")
|
|
// - "off": No AWS SDK logging (secure default, prevents credential leakage)
|
|
// - "minimal": Log retries only
|
|
// - "standard": Log retries and requests (previous default behavior)
|
|
// - "verbose": Log everything (requests, responses, bodies, signing)
|
|
// - Custom: Comma-separated AWS SDK log modes
|
|
// This is passed to vals Options.AWSLogLevel
|
|
// Can be overridden by AWS_SDK_GO_LOG_LEVEL environment variable
|
|
// See issue #2270 and vals PR #893
|
|
AWSSDKLogLevel = "HELMFILE_AWS_SDK_LOG_LEVEL"
|
|
|
|
// ValsFailOnMissingKeyInMap controls whether vals should fail when a key is missing in a map.
|
|
// When set to "true", vals returns an error if a referenced key does not exist in the secret map.
|
|
// Default is false for backward compatibility (returns empty string for missing keys).
|
|
// See issue #1563
|
|
ValsFailOnMissingKeyInMap = "HELMFILE_VALS_FAIL_ON_MISSING_KEY_IN_MAP"
|
|
)
|