yxxhero 76613bd0bb fix: serialize concurrent helm operations for same chart to fix #768 (#2662) ...

When multiple releases in a helmfile use the same remote chart, concurrent
helm upgrade/diff calls race on helm's internal repository cache file rename,
causing intermittent 'cannot rename: Access is denied' errors on Windows.

This fix introduces two layers of serialization:

1. withChartOperationLock (operation-level): wraps SyncRelease/DiffRelease
   calls with a per-chart+version mutex. Only applies to remote charts
   (release.ChartPath is empty); local/pre-fetched/OCI charts bypass the
   lock entirely. Different charts remain fully parallel.

2. Per-chart+version download mutex in forcedDownloadChart/getOCIChart
   (download-level): uses double-check locking to ensure only one
   helm fetch runs per unique chart+version within a process.

The fix does NOT change chart paths passed to helm, preserving backward
compatibility with all existing behavior and tests.

Trade-off: same-chart releases are fully serialized (the entire helm
operation including deployment, not just download). This is unavoidable
without pre-fetching because helm downloads and deploys atomically.
Releases with different charts are unaffected.

Fixes #768

Signed-off-by: yxxhero <aiopsclub@163.com>

2026-06-25 14:37:04 +08:00

..

testdata

feat(state): add mergeStrategy: fallback for first-file-wins env values (#2578)

2026-05-07 21:50:05 +08:00

chart_dependencies_rewrite_test.go

fix: refresh Chart.lock after rewriting file:// dependencies (#2587)

2026-05-19 05:41:41 +08:00

chart_dependency_test.go

fix: helmfile deps broken for OCI charts with underscores in path (#2648)

2026-06-18 22:51:44 +08:00

chart_dependency.go

fix: helmfile deps broken for OCI charts with underscores in path (#2648)

2026-06-18 22:51:44 +08:00

create_test.go

fix: include release values in .Values for patch template rendering (#2556)

2026-06-15 16:31:46 +08:00

create.go

feat(state): add mergeStrategy: fallback for first-file-wins env values (#2578)

2026-05-07 21:50:05 +08:00

diff_error_propagation_test.go

…

environment.go

feat(state): add mergeStrategy: fallback for first-file-wins env values (#2578)

2026-05-07 21:50:05 +08:00

envvals_loader_test.go

feat(state): add mergeStrategy: fallback for first-file-wins env values (#2578)

2026-05-07 21:50:05 +08:00

envvals_loader.go

feat(state): add mergeStrategy: fallback for first-file-wins env values (#2578)

2026-05-07 21:50:05 +08:00

helmx_test.go

feat: parallel kubedog tracking with progress printer and safety valves (#2654)

2026-06-21 13:43:17 +08:00

helmx.go

feat: parallel kubedog tracking with progress printer and safety valves (#2654)

2026-06-21 13:43:17 +08:00

issue923_test.go

fix: ensure OCI charts are prepared for needed releases with --include-needs (#2663)

2026-06-25 14:36:50 +08:00

issue_768_test.go

fix: serialize concurrent helm operations for same chart to fix #768 (#2662)

2026-06-25 14:37:04 +08:00

issue_2297_test.go

…

issue_2355_test.go

…

issue_2444_test.go

fix: pass --kubeconfig to chartify's helm template call (#2449)

2026-03-03 20:56:46 +08:00

issue_2549_test.go

Honor skipSchemaValidation during chartification when forceNamespace is set (#2550)

2026-04-30 12:30:41 -04:00

issue_2596_test.go

fix: normalize dependency chart path before DirectoryExistsAt check (#2598)

2026-05-20 08:44:14 +08:00

llm_field_test.go

feat: add helmfile doctor command for AI-assisted diff analysis (#2660)

2026-06-22 16:52:35 +08:00

oci_chart_lock_test.go

fix: skip cache refresh for shared cache paths to prevent race conditions (#2396)

2026-02-14 10:46:05 +08:00

oci_chart_version_test.go

fix: support OCI chart digest syntax (@sha256:...) (#2398)

2026-02-12 20:20:43 +08:00

oci_parse_test.go

fix: support OCI chart digest syntax (@sha256:...) (#2398)

2026-02-12 20:20:43 +08:00

release_error.go

…

release_filters_test.go

fix: skip subhelmfiles when selectors conflict with CLI selectors (#2545)

2026-04-25 17:18:39 +08:00

release_filters.go

fix: skip subhelmfiles when selectors conflict with CLI selectors (#2545)

2026-04-25 17:18:39 +08:00

release_test.go

…

release.go

fix: support array of maps in set/setTemplate values (#2615)

2026-05-31 09:57:35 +08:00

run_helm_dep_builds_skip_refresh_test.go

fix: local chart with external dependencies error when repos configured (#2433)

2026-02-28 09:23:04 +08:00

selector_test.go

…

skip_test.go

…

state_exec_tmpl_test.go

fix: support array of maps in set/setTemplate values (#2615)

2026-05-31 09:57:35 +08:00

state_exec_tmpl.go

feat: add defaultInherit for automatic release template inheritance (#2600)

2026-05-20 18:21:03 +08:00

state_gogetter_test.go

…

state_kubeversion_test.go

…

state_run.go

…

state_test.go

fix: helmfile deps broken for OCI charts with underscores in path (#2648)

2026-06-18 22:51:44 +08:00

state.go

fix: serialize concurrent helm operations for same chart to fix #768 (#2662)

2026-06-25 14:37:04 +08:00

storage_test.go

…

storage.go

fix: eliminate os.Chdir in sequential helmfiles to fix relative path resolution (#2410)

2026-02-22 09:21:46 +08:00

temp_test.go

feat: parallel kubedog tracking with progress printer and safety valves (#2654)

2026-06-21 13:43:17 +08:00

temp.go

…

types_test.go

fix: boolean false overrides dropped in multi-document helmfiles (#2527) (#2532)

2026-04-12 09:44:49 +08:00

types.go

fix: boolean false overrides dropped in multi-document helmfiles (#2527) (#2532)

2026-04-12 09:44:49 +08:00

util_test.go

…

util.go

…