71bb7354e7
This commit proposes a potential solution for https://github.com/roboll/helmfile/issues/1201 The gist is that, if prestate rendering fails, for any reason, we do not populate the .Values in the second pass renderer. I think that what have been expected in this case is to populate the .Values irregardless. pkg/app/two_pass_renderer.go - Migrated to use finalEnv.GetMergedValues() pkg/environment/environment.go - Introduced GetMergedValues, which merges the environment's defaults and current values, and then casts the keys to string; This was previously defined in HelmState.Values() - however, as this method is only concerned with the environment, I think it's more appropriate for it to sit here. pkg/state/state_exec_tmpl.go - Extracted out HelmState.Values() to environment.go, see above |
||
|---|---|---|
| .. | ||
| version | ||
| app.go | ||
| app_test.go | ||
| ask.go | ||
| config.go | ||
| constants.go | ||
| constants_test.go | ||
| context.go | ||
| desired_state_file_loader.go | ||
| destroy_test.go | ||
| diff_test.go | ||
| errors.go | ||
| load_opts.go | ||
| mocks_test.go | ||
| run.go | ||
| two_pass_renderer.go | ||
| two_pass_renderer_test.go | ||