mirror of
https://github.com/helmfile/helmfile.git
synced 2026-10-06 01:18:13 +02:00
Address Copilot review comments on preBuildTransitiveSubchartDeps: - execHelmDep shelled out via os/exec, bypassing Helmfile's standard command wiring. Thread the helmexec.Interface (already available in prepareChartForRelease) through processChartification into the prebuild helpers and dispatch via helm.BuildDeps/helm.UpdateDeps. Drop the os/exec call and the DefaultHelmBinary re-resolution. - isLockOutOfSync now inspects the helmexec ExitError message (which embeds the combined output) instead of raw []byte output. - DoesNotRecurseIntoRemoteDeps used a real helm binary, risking network I/O to https://charts.example.com. Switch it to a stub helm whose BuildDeps returns an error so it fails fast and deterministically, and assert it visits only the chart dir (no recursion). Signed-off-by: yxxhero <aiopsclub@163.com>