mirror of
https://github.com/helmfile/helmfile.git
synced 2026-09-30 13:27:18 +02:00
yxxheroandClaude
ad81e4231e
Toolchain and CI:
- Bump go directive from 1.26.8 to 1.27.1 (go.mod)
- Use golang:1.27-alpine builder images in all Dockerfiles
- Bump golangci-lint to v2.13.2 (first release with go1.27 support)
- Add CI gate: `go fix -diff` fails when outdated Go patterns are
detected (locally: `make check-modernize`)
Note: darwin binaries now require macOS 13 or later.
Lint fixes required by golangci-lint v2.13.2:
- goconst: ignore tests (all 436 findings were test-only; goconst
got stricter since v2.12 and this option was added for it)
- openai.go: keep deprecated MaxTokens deliberately with a nolint
rationale (max_tokens is the only form universally supported by
OpenAI-compatible backends like One-API, LiteLLM, Ollama shim)
- state.go: drop always-nil flags param from appendChartVersionFlags
(renamed to chartVersionFlags, unparam)
Modernization (go fix ./..., 62 files):
- interface{} -> any, maps.Copy, strings.SplitSeq, range-over-int,
builtin min/max, slices.Contains/ContainsFunc/Sort, WaitGroup.Go,
reflect.Type.Fields(), new(expr)
- exit_error.go: strings.Builder + fmt.Fprintf instead of string
concatenation and WriteString(fmt.Sprintf(...)) (QF1012)
- chart_dependency.go: strings.CutLast for OCI dependency helpers
Signed-off-by: yxxhero <aiopsclub@163.com>
Co-authored-by: Claude <noreply@anthropic.com>
85 lines
2.1 KiB
Go
85 lines
2.1 KiB
Go
package state
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestAppendSkipSchemaValidationFlagToChartifyTemplateArgs(t *testing.T) {
|
|
enable := true
|
|
|
|
tests := []struct {
|
|
name string
|
|
defaults HelmSpec
|
|
release *ReleaseSpec
|
|
fromCLI bool
|
|
templateArgs string
|
|
want string
|
|
}{
|
|
{
|
|
name: "adds flag from release setting",
|
|
release: &ReleaseSpec{
|
|
SkipSchemaValidation: &enable,
|
|
},
|
|
want: "--skip-schema-validation",
|
|
},
|
|
{
|
|
name: "adds flag from helm defaults",
|
|
defaults: HelmSpec{
|
|
SkipSchemaValidation: &enable,
|
|
},
|
|
release: &ReleaseSpec{},
|
|
want: "--skip-schema-validation",
|
|
},
|
|
{
|
|
name: "appends flag to existing args",
|
|
release: &ReleaseSpec{
|
|
SkipSchemaValidation: &enable,
|
|
},
|
|
templateArgs: "--kube-context default",
|
|
want: "--kube-context default --skip-schema-validation",
|
|
},
|
|
{
|
|
name: "does not duplicate existing flag",
|
|
release: &ReleaseSpec{
|
|
SkipSchemaValidation: &enable,
|
|
},
|
|
templateArgs: "--skip-schema-validation --kube-context default",
|
|
want: "--skip-schema-validation --kube-context default",
|
|
},
|
|
{
|
|
name: "does not treat similar flag values as existing flag",
|
|
release: &ReleaseSpec{
|
|
SkipSchemaValidation: &enable,
|
|
},
|
|
templateArgs: "--set name=foo--skip-schema-validation",
|
|
want: "--set name=foo--skip-schema-validation --skip-schema-validation",
|
|
},
|
|
{
|
|
name: "adds flag from cli setting",
|
|
release: &ReleaseSpec{},
|
|
fromCLI: true,
|
|
templateArgs: "--kube-context default",
|
|
want: "--kube-context default --skip-schema-validation",
|
|
},
|
|
{
|
|
name: "does not add flag when disabled",
|
|
release: &ReleaseSpec{},
|
|
templateArgs: "--kube-context default",
|
|
want: "--kube-context default",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
st := &HelmState{
|
|
HelmDefaults: tt.defaults,
|
|
}
|
|
|
|
got := st.appendSkipSchemaValidationFlagToChartifyTemplateArgs(tt.templateArgs, tt.release, tt.fromCLI)
|
|
require.Equal(t, tt.want, got)
|
|
})
|
|
}
|
|
}
|