mirror of
https://github.com/helmfile/helmfile.git
synced 2026-09-30 09:51:55 +02:00
yxxhero
bbf925f154
* test: add integration test for issue #1880 transformers with file:// deps Add an integration test reproducing the exact scenario from issue #1880: a local chart with a relative file:// dependency (file://../library) used together with kustomize transformers. Before the fix (rewriteChartDependencies in PR #2334), chartify copied the chart to a temp directory, breaking the relative file:// path and causing helm dependency up to fail with: Error: directory /tmp/chartify.../monitoring/library not found Also fix test artifact leak in issue923_test.go where OCI chart downloads wrote to CWD because OutputDirTemplate lacked {{ .OutputDir }}. Closes #1880 Signed-off-by: yxxhero <aiopsclub@163.com> * fix(test): guard exit-code captures against set -e in integration tests Under set -e (enabled in run.sh), a failing command exits the shell before 'var=$?' can execute, defeating diagnostic cat+fail blocks and breaking helm diff tests that expect exit code 2. Replaced 'cmd; var=$?' with 'var=0; cmd || var=$?' across 12 test files (29 sites), matching the pattern already used in oci-parallel-pull.sh. Signed-off-by: yxxhero <aiopsclub@163.com> --------- Signed-off-by: yxxhero <aiopsclub@163.com>
89 lines
5.0 KiB
Bash
89 lines
5.0 KiB
Bash
chart_need_case_input_dir="${cases_dir}/chart-needs/input"
|
|
chart_need_case_output_dir="${cases_dir}/chart-needs/output"
|
|
|
|
config_file="helmfile.yaml.gotmpl"
|
|
chart_needs_tmp=$(mktemp -d)
|
|
chart_needs_template_reverse=${chart_needs_tmp}/chart.needs.template.log
|
|
chart_needs_lint_reverse=${chart_needs_tmp}/chart.needs.lint.log
|
|
chart_needs_diff_reverse=${chart_needs_tmp}/chart.needs.diff.log
|
|
|
|
lint_out_file=${chart_need_case_output_dir}/lint
|
|
diff_out_file=${chart_need_case_output_dir}/diff
|
|
if [[ $EXTRA_HELMFILE_FLAGS == *--enable-live-output* ]]; then
|
|
lint_out_file=${chart_need_case_output_dir}/lint-live
|
|
diff_out_file=${chart_need_case_output_dir}/diff-live
|
|
fi
|
|
|
|
# Use Helm 4 variant files for lint (diff output is identical between Helm 3 and 4)
|
|
if [ "${HELMFILE_HELM4}" = "1" ]; then
|
|
if [ -f "${lint_out_file}-helm4" ]; then
|
|
lint_out_file="${lint_out_file}-helm4"
|
|
fi
|
|
fi
|
|
|
|
test_start "chart prepare when helmfile template with needs"
|
|
|
|
info "https://github.com/helmfile/helmfile/issues/455"
|
|
|
|
for i in $(seq 10); do
|
|
info "Comparing template/chart-needs #$i"
|
|
${helmfile} -f ${chart_need_case_input_dir}/${config_file} template --include-needs > ${chart_needs_template_reverse} || fail "\"helmfile template\" shouldn't fail"
|
|
./dyff between -bs ${chart_need_case_output_dir}/template ${chart_needs_template_reverse} || fail "\"helmfile template\" should be consistent"
|
|
done
|
|
|
|
for i in $(seq 10); do
|
|
info "Comparing lint/chart-needs #$i"
|
|
# Remove azuredisk-csi-driver repo to ensure consistent output (repo addition message)
|
|
${helm} repo remove azuredisk-csi-driver &>/dev/null || true
|
|
${helmfile} -f ${chart_need_case_input_dir}/${config_file} lint --include-needs | grep -v Linting | grep -v "has been removed" | grep -Ev "(Updating repo|Hang tight while we grab|Update Complete|Successfully got an update from|Warning:.*is not a valid SemVerV2|\[WARNING\].*is not a valid SemVerV2|failed to load plugins)" > ${chart_needs_lint_reverse} || fail "\"helmfile lint\" shouldn't fail"
|
|
diff -u ${lint_out_file} ${chart_needs_lint_reverse} || fail "\"helmfile lint\" should be consistent"
|
|
done
|
|
|
|
for i in $(seq 10); do
|
|
info "Comparing diff/chart-needs #$i"
|
|
# Remove azuredisk-csi-driver repo to ensure consistent output (repo addition message)
|
|
${helm} repo remove azuredisk-csi-driver &>/dev/null || true
|
|
${helmfile} -f ${chart_need_case_input_dir}/${config_file} diff --include-needs | grep -Ev "(Updating repo|Hang tight while we grab|Update Complete|Successfully got an update from|Comparing release=azuredisk-csi-storageclass, chart=.*/chartify.*/azuredisk-csi-storageclass)" > ${chart_needs_diff_reverse}.tmp || fail "\"helmfile diff\" shouldn't fail"
|
|
cat ${chart_needs_diff_reverse}.tmp | sed -E '/\*{20}/,/\*{20}/d' > ${chart_needs_diff_reverse}
|
|
|
|
# With --enable-live-output, there's a race condition that can cause non-deterministic ordering
|
|
# Try both the primary expected output and the alternate ordering
|
|
if ! diff -u ${diff_out_file} ${chart_needs_diff_reverse} >/dev/null 2>&1; then
|
|
if [[ $EXTRA_HELMFILE_FLAGS == *--enable-live-output* ]] && [ -f "${diff_out_file}-alt" ]; then
|
|
info "Primary diff failed, trying alternate ordering (due to --enable-live-output race condition)"
|
|
diff -u ${diff_out_file}-alt ${chart_needs_diff_reverse} || fail "\"helmfile diff\" should match either expected output"
|
|
else
|
|
diff -u ${diff_out_file} ${chart_needs_diff_reverse} || fail "\"helmfile diff\" should be consistent"
|
|
fi
|
|
fi
|
|
done
|
|
|
|
info "Applying ${chart_need_case_input_dir}/${config_file}"
|
|
code=0
|
|
${helmfile} -f ${chart_need_case_input_dir}/${config_file} apply --include-needs || code=$?
|
|
[ ${code} -eq 0 ] || fail "unexpected exit code returned by helmfile apply: want 0, got ${code}"
|
|
|
|
${kubectl} get storageclass managed-csi -o yaml | grep -q "provisioner: disk.csi.azure.com" || fail "storageclass managed-csi should be created when applying helmfile.yaml"
|
|
|
|
info "Destroying ${chart_need_case_input_dir}/${config_file}"
|
|
code=0
|
|
${helmfile} -f ${chart_need_case_input_dir}/${config_file} destroy || code=$?
|
|
[ ${code} -eq 0 ] || fail "unexpected exit code returned by helmfile destroy: want 0, got ${code}"
|
|
|
|
info "Syncing ${chart_need_case_input_dir}/${config_file}"
|
|
code=0
|
|
${helmfile} -f ${chart_need_case_input_dir}/${config_file} sync --include-needs || code=$?
|
|
[ ${code} -eq 0 ] || fail "unexpected exit code returned by helmfile apply: want 0, got ${code}"
|
|
|
|
${kubectl} get storageclass managed-csi -o yaml | grep -q "provisioner: disk.csi.azure.com" || fail "storageclass managed-csi should be created when syncing helmfile.yaml"
|
|
|
|
info "Destroying ${chart_need_case_input_dir}/${config_file}"
|
|
code=0
|
|
${helmfile} -f ${chart_need_case_input_dir}/${config_file} destroy || code=$?
|
|
[ ${code} -eq 0 ] || fail "unexpected exit code returned by helmfile destroy: want 0, got ${code}"
|
|
|
|
# Clean up: remove azuredisk-csi-driver repo to avoid conflicts with subsequent tests
|
|
${helm} repo remove azuredisk-csi-driver &>/dev/null || true
|
|
|
|
test_pass "chart prepare when helmfile template with needs"
|