helmfile/test/integration/test-cases/issue-2097/input/helmfile-version-in-url.yaml at patch-1 - helmfile - Gitea: Git with a cup of tea

public_git/helmfile

mirror of https://github.com/helmfile/helmfile.git synced 2026-10-08 22:31:55 +02:00

Files

T

Aditya Menon 5c43fa6465 fix: support OCI chart digest syntax (@sha256:...) (#2398 )

fix: support OCI chart digest syntax in chart URLs and version fields

Helm supports pinning OCI chart images by digest (@sha256:...), version
tag (:version), or both (:version@sha256:digest) since helm/helm#12690.
Helmfile failed to parse these formats, incorrectly constructing helm
commands and losing version/digest information embedded in chart URLs.

Root causes:
- resolveOciChart() used last ":" to find version tag, but sha256:abc
  contains ":", so digest URLs were split incorrectly
- getOCIQualifiedChartName() included :version and @digest in chartName
  with no parsing of either source
- appendChartVersionFlags() passed release.Version verbatim to --version
  flag, including any digest suffix
- ChartPull() discarded the tag from resolveOciChart but did not
  preserve digest in the URL

This commit adds parseOCIChartRef() and parseVersionDigest() utilities,
then updates the OCI chart handling pipeline so that:
- Digests are preserved in the chart URL passed to helm pull
- Version tags are extracted cleanly for the --version flag
- Both chart URL and version field are parsed for version/digest info

Fixes #2097

Signed-off-by: Aditya Menon <amenon@canarytechnologies.com>

2026-02-12 20:20:43 +08:00

5 lines

120 B

YAML

Raw Permalink Blame History

 releases:
   - name: test-oci-version-in-url
     namespace: default
     chart: oci://registry.example.com/my-chart:2.0.0