mirror of
https://github.com/helmfile/helmfile.git
synced 2026-10-01 12:49:47 +02:00
Aditya Menon
c375b48550
PR #2367 introduced CLIOverrides to give --state-values-set element-by-element array merge semantics. However, nested helmfile values (helmfiles[].values:) were also routed into CLIOverrides, causing their arrays to merge instead of replace. This broke the pre-v1.3.0 behavior where passing an array via helmfiles[].values: would fully replace the child's default array. Add OverrideValuesAreCLI flag to SubhelmfileEnvironmentSpec so the loader can distinguish CLI flags from nested helmfile values. CLI values continue using CLIOverrides (element-by-element merge); nested helmfile values now use Values (Sparse merge strategy → full array replacement). Fixes #2451 Signed-off-by: Aditya Menon <amenon@canarytechnologies.com>
37 lines
1016 B
Go
37 lines
1016 B
Go
package app
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// TestLoadOptsDeepCopy tests the DeepCopy function for LoadOpts struct.
|
|
func TestLoadOptsDeepCopy(t *testing.T) {
|
|
lOld := LoadOpts{
|
|
Selectors: []string{"test"},
|
|
RetainValuesFiles: true,
|
|
CalleePath: "test",
|
|
Reverse: true,
|
|
Filter: true,
|
|
}
|
|
lNew := lOld.DeepCopy()
|
|
|
|
// Check that the new struct is not the same as the old one.
|
|
require.Equal(t, lOld, lNew, "DeepCopy should return a copy of the LoadOpts struct")
|
|
}
|
|
|
|
// TestLoadOptsDeepCopyPreservesOverrideValuesAreCLI verifies that DeepCopy
|
|
// preserves the OverrideValuesAreCLI flag which is tagged yaml:"-".
|
|
func TestLoadOptsDeepCopyPreservesOverrideValuesAreCLI(t *testing.T) {
|
|
lOld := LoadOpts{
|
|
Selectors: []string{"test"},
|
|
CalleePath: "test",
|
|
}
|
|
lOld.Environment.OverrideValuesAreCLI = true
|
|
|
|
lNew := lOld.DeepCopy()
|
|
|
|
require.True(t, lNew.Environment.OverrideValuesAreCLI, "DeepCopy should preserve OverrideValuesAreCLI flag")
|
|
}
|