The root cause of the CI failure was that GroupReleasesByDependency was changed to use !r.Filtered instead of opts.SelectedReleases for the DAG plan's Only field. When no selectors are active (like helmfile destroy), all releases are unfiltered, causing all releases to be planned for deletion - including uninstalled ones. Fix: Use opts.SelectedReleases when provided, fall back to Filtered flag otherwise. Also remove unnecessary SelectedReleases block from PlanReleases since GroupReleasesByDependency now handles it directly. Restore test snapshots from main as the behavior should now match. Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com> Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/170cecc0-7a3e-4326-98d3-4f2bffee1848 |
||
|---|---|---|
| .. | ||
| bad_--selector | ||
| skip-needs=false_include-needs=true | ||
| skip-needs=false_include-needs=true_but_no_diff_on_needed_release | ||
| skip-needs=false_include-needs=true_with_installed_but_disabled_release | ||
| skip-needs=false_include-needs=true_with_not_installed_and_disabled_release | ||
| skip-needs=true | ||
| skip-needs=true_with_no_diff_on_a_release | ||