mirror of
https://github.com/helmfile/helmfile.git
synced 2026-10-04 01:11:49 +02:00
Aditya MenonandCopilot
c6b962dbbf
* fix: include query params in HTTP getter cache key (#2103) When helmfile caches remote HTTP files fetched via the "normal" getter (plain https:// URLs without a git:: prefix), the cache key did not include query parameters. This caused URLs that differ only in query params (e.g. ?ref=commit1 vs ?ref=commit2) to share the same cache directory, silently returning the wrong file version. The root cause was in Fetch() where the "normal" getter branch overwrote the cache key with only scheme + host, discarding query params that were correctly computed earlier. Fix: extract the query-params suffix into a reusable variable and apply it in both the default and "normal" getter cache key paths. Signed-off-by: Aditya Menon <amenon@canarytechnologies.com> * Update pkg/remote/remote.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Aditya Menon <amenon@canarytechnologies.com> * Update pkg/remote/remote_test.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Aditya Menon <amenon@canarytechnologies.com> --------- Signed-off-by: Aditya Menon <amenon@canarytechnologies.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
37 lines
861 B
Go
37 lines
861 B
Go
// server.go is a small HTTP server used by the issue-2103 integration test.
|
|
// It serves different YAML content based on the "ref" query parameter.
|
|
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"net"
|
|
"net/http"
|
|
"os"
|
|
)
|
|
|
|
func main() {
|
|
mux := http.NewServeMux()
|
|
mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
|
|
ref := r.URL.Query().Get("ref")
|
|
if ref == "" {
|
|
ref = "unknown"
|
|
}
|
|
w.Header().Set("Content-Type", "text/plain")
|
|
_, _ = fmt.Fprintf(w, "version: %s\n", ref)
|
|
})
|
|
|
|
listener, err := net.Listen("tcp", "127.0.0.1:0")
|
|
if err != nil {
|
|
fmt.Fprintf(os.Stderr, "Failed to listen: %v\n", err)
|
|
os.Exit(1)
|
|
}
|
|
|
|
// Print the address so the test script can capture it.
|
|
fmt.Printf("http://%s\n", listener.Addr().String())
|
|
|
|
if err := http.Serve(listener, mux); err != nil {
|
|
fmt.Fprintf(os.Stderr, "Server error: %v\n", err)
|
|
os.Exit(1)
|
|
}
|
|
}
|