mirror of
https://github.com/helmfile/helmfile.git
synced 2026-09-30 09:51:55 +02:00
Aditya Menon
4f275b3667
This commit adds comprehensive support for Helm 4 while maintaining full backward compatibility with Helm 3. The implementation includes: - Updated helm version detection to support both Helm 3 and Helm 4 - Added HELMFILE_HELM4 environment variable to control Helm version - Modified helm execution paths to handle version-specific binaries - Updated helm plugin installation to support split architecture - Helm 4: Uses split plugin architecture (3 separate .tgz files) - helm-secrets.tgz - helm-secrets-getter.tgz - helm-secrets-post-renderer.tgz - Helm 3: Continues using single plugin installation - Updated Dockerfiles, CI workflows, and core installation code - Helm 4 requires post-renderers to be plugins, not executable scripts - Created Helm plugin structure for integration tests - Updated helmfile.yaml templates to dynamically select renderer type - Added test plugins: add-cm, add-cm1, add-cm2 - Updated integration tests for Helm 3/4 compatibility - Created Helm 4 variant expected output files - Fixed test determinism issues (repo cleanup between iterations) - Added version-specific output filtering for warnings/messages - Updated workflows to test both Helm 3 and Helm 4 - Matrix testing across Helm versions - Updated helm-diff to v3.14.0 for compatibility - Updated README and docs with Helm 4 information - Added migration guidance - Updated version requirements All changes are backward compatible - existing Helm 3 users will see no behavior changes. fix: update Helm 4 lint expected output to match filtered output The grep filter removes the semver warning, so the expected output should not include it. Updated lint-helm4 files to match the filtered output (warning removed, no extra blank line). Signed-off-by: Aditya Menon <amenon@canarytechnologies.com>
64 lines
1.8 KiB
Go
64 lines
1.8 KiB
Go
package state
|
|
|
|
import (
|
|
"errors"
|
|
"strings"
|
|
"sync"
|
|
"testing"
|
|
|
|
"go.uber.org/zap"
|
|
|
|
"github.com/helmfile/helmfile/pkg/exectest"
|
|
"github.com/helmfile/helmfile/pkg/helmexec"
|
|
)
|
|
|
|
func TestIsReleaseInstalled_HandlesConnectionError(t *testing.T) {
|
|
logger := zap.NewNop().Sugar()
|
|
|
|
state := &HelmState{
|
|
logger: logger,
|
|
}
|
|
|
|
// Create a custom helm mock that fails on List operations
|
|
helm := &CustomFailingHelm{
|
|
Helm: &exectest.Helm{
|
|
DiffMutex: &sync.Mutex{},
|
|
ChartsMutex: &sync.Mutex{},
|
|
ReleasesMutex: &sync.Mutex{},
|
|
},
|
|
}
|
|
|
|
release := ReleaseSpec{
|
|
Name: "test-release",
|
|
Chart: "test/chart",
|
|
Namespace: "default",
|
|
}
|
|
|
|
// This should return an error due to connection failure
|
|
_, err := state.isReleaseInstalled(helmexec.HelmContext{}, helm, release)
|
|
|
|
// Verify that error was propagated
|
|
if err == nil {
|
|
t.Fatalf("expected isReleaseInstalled to return error when Kubernetes is unreachable, but got no error")
|
|
}
|
|
|
|
if err.Error() == "" {
|
|
t.Fatalf("expected isReleaseInstalled to return meaningful error when Kubernetes is unreachable, but got empty error")
|
|
}
|
|
|
|
// Check if the error contains the expected message
|
|
expectedMsg := "Kubernetes cluster unreachable"
|
|
if err.Error() != expectedMsg && !strings.Contains(err.Error(), "Kubernetes cluster unreachable") {
|
|
t.Fatalf("expected error to contain 'Kubernetes cluster unreachable', but got: %v", err.Error())
|
|
}
|
|
}
|
|
|
|
// CustomFailingHelm wraps exectest.Helm and overrides List to simulate failures
|
|
type CustomFailingHelm struct {
|
|
*exectest.Helm
|
|
}
|
|
|
|
func (h *CustomFailingHelm) List(context helmexec.HelmContext, filter string, flags ...string) (string, error) {
|
|
return "", errors.New("Kubernetes cluster unreachable: Get \"http://localhost:8080/version\": dial tcp [::1]:8080: connect: connection refused")
|
|
}
|