f3b19fd81e
Add parameter to render helmfile as go template without .gotmpl extension ( #2312 )
...
* Add parameter to render helmfile as go template without gotmpl extension
Signed-off-by: Ronaldo <ronaldo.ur@gmail.com>
* Update pkg/envvar/const.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---------
Signed-off-by: Ronaldo <ronaldo.ur@gmail.com>
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-12-09 14:41:47 +09:00
83b4a8ffc7
Fix AWS SDK debug logging by making it configurable (issue #2270 ) ( #2290 )
...
* fix: make AWS SDK debug logging configurable (issue #2270 )
This PR fixes issue #2270 where AWS SDK debug logs expose sensitive
credentials in helmfile output, by adding flexible, configurable AWS SDK
logging with secure defaults.
Problem:
--------
Despite PR #2288 's fix, AWS SDK debug logs still appeared in helmfile
output, exposing sensitive information:
- AWS tokens and authorization headers
- Request/response bodies containing credentials
- Secret metadata from vals providers
Root Cause:
-----------
1. PR #2288 only suppressed vals' own logging via LogOutput: io.Discard
2. AWS SDK v2 uses separate logging (AWS_SDK_GO_LOG_LEVEL, WithClientLogMode)
3. Vals library defaulted to verbose logging (aws.LogRetries | aws.LogRequest)
4. No programmatic way to control AWS SDK logging
Solution:
---------
Two-part fix in conjunction with vals PR #893 :
1. Vals library enhancement (helmfile/vals#893 ):
- Added Options.AWSLogLevel field for programmatic control
- Changed default from verbose to secure (no logging)
- Added preset levels: off, minimal, standard, verbose
- Maintains AWS_SDK_GO_LOG_LEVEL precedence
2. Helmfile changes (this PR):
- Added HELMFILE_AWS_SDK_LOG_LEVEL environment variable
- Enhanced vals configuration to use new AWSLogLevel field
- Added conditional AWS SDK log suppression in remote.go (3 locations)
- Comprehensive unit tests (15 test cases)
Configuration:
--------------
Preset levels via HELMFILE_AWS_SDK_LOG_LEVEL:
- "off" (default) - No logging, secure, prevents credential leakage
- "minimal" - Log retries only
- "standard" - Log retries + requests (previous default behavior)
- "verbose" - Log everything (requests, responses, bodies, signing)
- Custom - Comma-separated values (e.g., "request,response")
Priority order:
1. AWS_SDK_GO_LOG_LEVEL env var (highest)
2. HELMFILE_AWS_SDK_LOG_LEVEL env var
3. Secure default ("off")
Testing:
--------
Added comprehensive unit tests:
- pkg/plugins/vals_test.go: 9 test cases
* TestAWSSDKLogLevelConfiguration - all preset levels
* TestEnvironmentVariableReading - env var parsing
- pkg/remote/remote_test.go: 6 test cases
* TestAWSSDKLogLevelInit - init() logic
All tests passing:
- pkg/plugins: PASS (3/3 test suites)
- pkg/remote: PASS (all test suites)
- golangci-lint: 0 issues
Files changed: 7 files, 271 insertions(+), 31 deletions(-)
Security:
---------
Before: Credentials exposed by default (aws.LogRetries | aws.LogRequest)
After: Credentials protected by default (no logging unless explicitly enabled)
Follows security principles:
- Secure by default
- Principle of least privilege
- Explicit opt-in for sensitive logging
- Defense in depth
Dependency:
-----------
Depends on: helmfile/vals#893
Currently using: aditmeno/vals@a97336ce2b (via go.mod replace)
After vals PR merges: Update to official release
Fixes : #2270
Related: #2288 , #2289 , helmfile/vals#893
Signed-off-by: Aditya Menon <amenon@canarytechnologies.com>
* chore: update vals to use parameter-based AWS log level configuration
Updated vals dependency to commit 06d7cd29 which implements clean
parameter-based AWS SDK logging configuration instead of using
global state mutation.
Changes in vals implementation:
- AWS log level passed through function parameters to each provider
- No os.Setenv() - no environment mutation
- No package-level global variables
- No sync/atomic dependency needed
- Thread-safe by design - each provider instance has its own log level
This maintains the same functionality as before but with a cleaner
implementation that avoids global state mutation.
Signed-off-by: Aditya Menon <amenon@canarytechnologies.com>
* deps: update vals to upstream v0.42.6
Update from vals fork (aditmeno/vals) to official release v0.42.6.
Remove replace directive now that vals PR #893 has been merged upstream.
This brings in the AWS SDK log level configuration improvements:
- SetDefaultLogLevel() package-level function
- Options.AWSLogLevel field support
- Secure default (no logging)
- Preset log levels (off, minimal, standard, verbose)
Also updates related dependencies:
- Azure SDK and auth libraries
- AWS SDK config and credentials
- OAuth2 library
Signed-off-by: Aditya Menon <amenon@canarytechnologies.com>
---------
Signed-off-by: Aditya Menon <amenon@canarytechnologies.com>
2025-11-24 18:27:04 +08:00
b52ca9ae04
refactor(yaml): upgrade from gopkg.in/yaml.v2 to v3 ( #2039 )
...
* refactor(yaml): upgrade from gopkg.in/yaml.v2 to v3
Signed-off-by: yxxhero <aiopsclub@163.com>
* refactor(yaml): enhance yaml encoding with consistent formatting and quotes
Signed-off-by: yxxhero <aiopsclub@163.com>
* optimize code
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix more issues
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
---------
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-05-15 10:21:37 -04:00
844726b09b
feat(tmpl): enhance ToYaml test with multiple scenarios ( #2031 )
...
* feat(tmpl): enhance ToYaml test with multiple scenarios
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-05-09 11:56:54 +08:00
5d29f03782
Remove all v0.x references ( #1919 )
...
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* refactor(two_pass_renderer): remove unused imports and functions
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
---------
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-03-08 07:43:21 -06:00
63e2684ade
Revert "cleanup: remove all about v0.x" ( #1918 )
...
Revert "cleanup: remove all about v0.x (#1903 )"
This reverts commit d7bcd5e998
2025-02-08 18:25:16 +08:00
d7bcd5e998
cleanup: remove all about v0.x ( #1903 )
...
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* refactor(two_pass_renderer): remove unused imports and functions
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
---------
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-02-05 13:50:16 -05:00
4287471acc
feat: add HELMFILE_INTERACTIVE env var to enable interactive mode ( #1787 )
...
* feat: add HELMFILE_INTERACTIVE env var to enable interactive mode
This commit adds the `HELMFILE_INTERACTIVE` environment variable
to enable the interactive mode by default.
Anything other than `true` will disable the interactive mode.
The precedence has the `--interactive` flag.
Signed-off-by: Krzysztof Łuczak <krzysztof.luczak.pro@gmail.com>
* Trim trailing whitespaces
Signed-off-by: Krzysztof Łuczak <krzysztof.luczak.pro@gmail.com>
---------
Signed-off-by: Krzysztof Łuczak <krzysztof.luczak.pro@gmail.com>
2024-11-18 16:35:48 +08:00
75ad24e6dc
feat: use helm status to find helm release ( #1640 )
...
* feat: use helm status to find helm release
Signed-off-by: yxxhero <aiopsclub@163.com>
2024-07-30 13:40:44 +08:00
270f27f481
remove HELMFILE_SKIP_INSECURE_TEMPLATE_FUNCTIONS for v1 ( #1434 )
...
Signed-off-by: yxxhero <aiopsclub@163.com>
2024-04-01 08:42:55 +08:00
d681c62ff8
add support for HELMFILE_FILE_PATH envvar to set -f ( #1255 )
...
* fix imports
Signed-off-by: Shane Starcher <shanestarcher@gmail.com>
* unset env var
Signed-off-by: Shane Starcher <shanestarcher@gmail.com>
---------
Signed-off-by: Shane Starcher <shanestarcher@gmail.com>
2024-01-03 21:37:49 +08:00
5cdec2dd51
clean: helm v2 logic code ( #736 )
...
Signed-off-by: yxxhero <aiopsclub@163.com>
2023-03-12 00:28:39 +08:00
4688cf0132
Use gopkg.in/yaml.v2 for Helmfile v0.x ( #609 )
...
This should fix #435 for Helmfile v0.x releases since the next v0.150.0.
We introduce a new envvar to opt-in to the new YAML library, so that you can give it a shot before upgrading your Helmfile to v1. The same envvar can be used to opt-out of the new YAML library after you upgrade to Helmfile v1, giving you a more flexible migration story.
Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
2023-01-04 18:17:24 +09:00
8144638bab
feat: Helmfile V1 mode ( #594 )
...
* feat: Helmfile V1 mode
We add a new "V1 mode" to Helmfile so that you can seemlessly upgrade Helmfile from the current v0.x to the upcoming v1.0.
The idea is that we build both v0 and v1 binaries from the same tagged commit within the main branch, with different defaults for the "V1 mode"- the V1 mode is disabled by default for v0.x binaries, while it is enabled by default for v1.x binaries.
The V1 mode can be overrode at runtime via envvar. That is, even after upgrading the binary to v1, you will not see any backward-incompatible changes while you explicitly set an envvar, `HELMFILE_V1MODE=true`, at runtime.
Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
2022-12-22 20:30:44 +09:00
398c812e49
Use go-getter with secrets as well ( #560 )
...
* Use go-getter with secrets as well
Signed-off-by: Quan TRAN <account@itscaro.me>
2022-12-09 07:46:28 +08:00
ed228c9c7e
move HELMFILE_UPGRADE_NOTICE_DISABLED into envvar file
...
Signed-off-by: yxxhero <aiopsclub@163.com>
2022-10-15 14:22:51 +08:00
577f54af7a
Introduce DISABLE_INSECURE_FEATURES to disable insecure command executions ( #1 )
...
* introduce DISABLE_INSECURE_FEATURES to disable insecure executions
Signed-off-by: Quan TRAN <account@itscaro.me>
* disable remote sources when DISABLE_INSECURE_FEATURES is set to "true"
Signed-off-by: Quan TRAN <account@itscaro.me>
* refactor envvar package
Signed-off-by: Quan TRAN <account@itscaro.me>
* (test) fix test fixtures
Signed-off-by: Quan TRAN <account@itscaro.me>
* use absolute path to avoid unit test failure
Signed-off-by: Quan TRAN <account@itscaro.me>
* Fix conflicts
Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com>
2022-06-05 15:15:06 +09:00
Ronaldo Umana
Aditya Menon
yxxhero
Krzysztof Łuczak
Shane Starcher
Yusuke Kuoka
Quan TRAN
yxxhero