Commit Graph

1090 Commits

Author SHA1 Message Date
Yusuke Kuoka 8e50dbc46d Fix helmfile deps not to remove entries for charts that are being chartified
When chartify is involved due to the use of `forceNamespace`, `strategicMergePatches`, `jsonPatches`, and so on, We had been internally mutating the Release.Chart with the path to the local temporary directory that contains the modified version of the chart.

This resulted in us unintentionally making `helmfile deps` to remove entries for the chart being modified out of helmfile.lock file, which resulted in issues like #2110.

To be clear, although the original issue is reported to occur for `strategicMergePatches`, I believe that it occurered also for any remote charts using `jsonPatches` and `forceNamespace` too.

I also believe this has been the issue since our introduction of chartify (maybe a year or so ago??), and I guess why it took so much time to be found and reported is that not so many people with chartify in combination with `helmfile deps` 🤔

Lastly, this changes chart names surfaced in the various log output from Helmfile, from temporary chart paths to the chart name/path declared in the helmfile.yaml. I think this is generally a good change, no fear of being a breaking change. But if anyone has any concern about that, please feel free to comment/report/etc.

Ref https://github.com/roboll/helmfile/issues/2110

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
2022-04-06 02:12:08 +00:00
Yusuke Kuoka 8fb418e3c9
Merge pull request #21 from itscaro/qtran.fix-golang1.18
[fix] bump go 1.18 & optional TAG definition in makefile
2022-04-06 08:39:14 +09:00
Yusuke Kuoka f49d181b41
Merge pull request #20 from itscaro/qtran/fix-decrypted-file
[fix] unclosed file stream when creating temporary decrypted files
2022-04-06 08:37:13 +09:00
Yusuke Kuoka f7eb4a9e3e
Merge pull request #19 from itscaro/qtran/badge
Update badge to reflect Github Action status
2022-04-06 08:36:23 +09:00
Yusuke Kuoka 3f1d01a688
Merge pull request #18 from yxxhero/add_unittest_RequiredEnv
add unittest for RequiredEnv func
2022-04-06 08:35:26 +09:00
Yusuke Kuoka e8212276d5
Merge pull request #17 from yxxhero/update_args_unitest
update args_test.go unittest
2022-04-06 08:32:35 +09:00
Quan TRAN 03cbf5f9f4 [fix] bump go 1.18 & optional TAG definition in makefile
Signed-off-by: Quan TRAN <account@itscaro.me>
2022-04-06 00:35:23 +02:00
Quan TRAN a793797404 [fix] unclosed file stream when creating temporary decrypted files
Signed-off-by: Quan TRAN <account@itscaro.me>
2022-04-05 22:52:17 +02:00
Quan TRAN eed489efc1 Update badge to reflect Github Action status
Signed-off-by: Quan TRAN <account@itscaro.me>
2022-04-05 21:16:52 +02:00
yxxhero 5cb82ec3d1 add unittest for RequiredEnv func
Signed-off-by: yxxhero <aiopsclub@163.com>
2022-04-05 22:53:07 +08:00
Yusuke Kuoka 4247b97eb1
Merge pull request #2 from itscaro/qtran/go1.18
bump go 1.18 & remove .circleci
2022-04-05 08:51:15 +09:00
Yusuke Kuoka 4480ec2cdc
Merge pull request #11 from yxxhero/add_unittest_for_apptest
add unittest for load_opts.go
2022-04-05 08:50:11 +09:00
Yusuke Kuoka 7cc9778a13
Merge pull request #16 from itscaro/qtran/helm-3.8.1
[test] update helm 3.8.0 to 3.8.1
2022-04-05 08:49:38 +09:00
yxxhero 8e5c779626 update args_test.go unittest
Signed-off-by: yxxhero <aiopsclub@163.com>
2022-04-05 06:26:42 +08:00
Quan TRAN b2798315b1 [test] update helm 3.8.0 to 3.8.1
Signed-off-by: Quan TRAN <account@itscaro.me>
2022-04-04 16:39:06 +02:00
Quan TRAN a1dfcb3480 bump go 1.18 & remove .circleci
Signed-off-by: Quan TRAN <account@itscaro.me>
2022-04-04 16:33:48 +02:00
yxxhero 02058cc1f5 add unittest for load_opts.go
Signed-off-by: yxxhero <aiopsclub@163.com>
2022-04-04 17:20:54 +08:00
Yusuke Kuoka 4a52ce0ac2
Merge pull request #13 from yxxhero/mv_captureStdout_as_public_func
mv captureStdout as public func
2022-04-04 10:06:03 +09:00
yxxhero e0244bc341 mv captureStdout as public func
Signed-off-by: yxxhero <aiopsclub@163.com>
2022-04-03 22:24:38 +08:00
Yusuke Kuoka 01b5b79a01
Merge pull request #9 from yxxhero/unit_formatters
add unittest for formatters.go
2022-04-03 19:22:32 +09:00
yxxhero 7f70138b5f add unit for formatters.go
Signed-off-by: yxxhero <aiopsclub@163.com>
2022-04-03 17:31:59 +08:00
Yusuke Kuoka ed27147cac Add more links to the new-issue page 2022-04-03 08:35:22 +00:00
Yusuke Kuoka 137afa3f35
Merge pull request #5 from yxxhero/replace_ioutil
remove ioutil usage in all project
2022-04-03 17:16:46 +09:00
Yusuke Kuoka 6c258af4b6 Encourage users to sponsor the project 2022-04-03 08:09:15 +00:00
Yusuke Kuoka 31c68607ac Fix bug report issue form 2022-04-03 08:03:31 +00:00
Yusuke Kuoka 4bafeab2fe
Merge pull request #4 from helmfile/issue-form-bug
Add an issue form for bug report
2022-04-03 17:00:31 +09:00
Yusuke Kuoka 4567a643a5 Skip CI for changes in issue templates 2022-04-03 07:58:13 +00:00
Yusuke Kuoka 81cc843710 Add an issue form for bug report
Ref https://github.com/roboll/helmfile/issues/1824
2022-04-03 07:56:34 +00:00
yxxhero 303ef9cd80 remove ioutil usage in all project
Signed-off-by: yxxhero <aiopsclub@163.com>
2022-04-03 15:53:19 +08:00
Yusuke Kuoka 1aa87538a7 Publish canary container images via ghcr.io
Ref https://github.com/roboll/helmfile/issues/1824
2022-04-03 07:25:28 +00:00
Yusuke Kuoka 11ab0cb8c8 Lock issues and pull requests after close
Ref https://github.com/roboll/helmfile/issues/1824
2022-04-03 05:19:22 +00:00
Yusuke Kuoka e561e9bc06 Add a documentation badge to README 2022-04-03 05:11:01 +00:00
Yusuke Kuoka 3267484f47 Documentation site based on mkdocs and Read the Docs
Ref https://github.com/roboll/helmfile/issues/1824
Ref https://github.com/roboll/helmfile/issues/1755
2022-04-03 05:04:54 +00:00
Yusuke Kuoka 498a976efb Add stale bot config
Ref https://github.com/roboll/helmfile/issues/1824
2022-04-03 02:48:01 +00:00
Yusuke Kuoka f6fac3ff32 Add an experimental GitHub Actions workflow for CI
All the credits goes to @itscaro's work at https://github.com/roboll/helmfile/pull/2084. The only change I made is related to the main branch rename.
2022-04-03 02:29:34 +00:00
Yusuke Kuoka 19ba9d2c4d Merge remote-tracking branch 'origin/master' into main 2022-04-03 02:26:35 +00:00
Yusuke Kuoka 1e41817c63
Create FUNDING.yml 2022-04-03 11:18:04 +09:00
yxxhero d4a7b3bfff
fix little issue (#2126)
Signed-off-by: yxxhero <aiopsclub@163.com>
2022-04-03 09:16:59 +09:00
Yusuke Kuoka be5af8e3b7
Enhance support for kube-version and api-versions (#2121)
This adds support for `kube-version` and `api-versions` to be available to `chartify` so that it works even if your release requires `chartify` due to that you use features like `forceNamespace`, `jsonPatches`, `strategicMergePatches`, and so on.

This also enhances `ReleaseSpec` which corresponds to each item of `releases[]` in your `helmfile.yaml` to also accept `kubeVersion` and `apiVersions`, in addition to the top-level `kubeVersion` and `apiVersions` we have today.

The top-level ones works as the default values for release-specific ones. If you have been using the top-level ones, keep using it. It is backward-compatible. If you want to specify it per release, because, for example, your releases are deployed across clusters(in case you differentiate `kubeContext` fields), try the new fields added to the release spec.

Resolves #1864
2022-03-31 11:02:36 +09:00
Quan TRAN ed436ba68b
Add template function isFile (#2045)
* Add template function isFile

* Update context_funcs.go
2022-03-31 10:59:10 +09:00
Quan TRAN 45be24da53
Add .StateValues as alias of .Values in EnvironmentTemplateData (#2056) 2022-03-31 10:57:33 +09:00
qb-abdul 4716320d99
Update README.md (#2105)
Added examples in Readme.md for fetching values from Remote
2022-03-31 10:54:25 +09:00
Yusuke Kuoka 9b621b3d21
Bump chartify to v0.9.5 (#2119)
This release of chartify fixes a single bug in chartify that resulted in a few issues when your chart had dependencies. One of issues is the mysterious "no cached repository for helm-manager-HASH found" error mentioned in https://github.com/variantdev/chartify/pull/31. Another is #2117 which was due to the bug resulted in rendering some resources, CRDs in the case, twice.

See https://github.com/variantdev/chartify/releases/tag/v0.9.5 for more information.
2022-03-29 09:45:00 +09:00
yxxhero a8784a17ed
precheck for make test (#2116)
Signed-off-by: yxxhero <aiopsclub@163.com>
2022-03-27 12:21:36 +09:00
yxxhero cabaf15a1a
update go for 1.14 to 1.17 (#2115)
Signed-off-by: yxxhero <aiopsclub@163.com>
2022-03-27 12:21:00 +09:00
Yusuke Kuoka 04c379b284
Bump chartify to v0.9.4 (#2114)
This release fixes an issue when you tried to chartify a local chart whose directory name does not match the name of the chart defined in Chart.yaml.

See https://github.com/variantdev/chartify/releases/tag/v0.9.4 for more information.
2022-03-25 09:37:31 +09:00
Yusuke Kuoka 742391357a Fix release job by limiting gox parallelism 2022-03-24 02:18:27 +00:00
Yusuke Kuoka f65d1e6b05
Bump chartify to v0.9.3 (#2113)
This release fixes a few issues, including a regression introduced in the previous version of chartify v0.9.2.

See https://github.com/variantdev/chartify/releases/tag/v0.9.3 for more information.
2022-03-24 10:36:01 +09:00
Yusuke Kuoka 185bc82992
Bump chartify to v0.9.2 (#2102)
This should fix a few issues, most notably that adhoc dependencies breaks when some of original chart dependencies are unresolvable with `helm dep up` and/or `helm dep build`.

https://github.com/variantdev/chartify/releases/tag/v0.9.2
2022-03-14 19:25:08 +09:00
Anton Bretting b1928e585d
Stop panic when deduplicating releases (#2067)
* Stop panic when deduplicating releases
* Add testdata for new testcases
2022-03-10 18:57:58 +09:00