public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(helm3): `Error: unknown flag: --purge` on deletion via `helmfile sync` (#890) 

Fixes #888
This commit is contained in:
KUOKA Yusuke 2019-10-10 16:54:15 +09:00 committed by GitHub
parent f51949ac3f
commit fdca10678b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/state/state.go
View File

@ -434,7 +434,13 @@ func (st *HelmState) SyncReleases(affectedReleases *AffectedReleases, helm helme
if err != nil { if err != nil {
relErr = newReleaseError(release, err) relErr = newReleaseError(release, err)
} else if installed { } else if installed {
deletionFlags := st.appendConnectionFlags([]string{"--purge"}, release) var args []string
if isHelm3() {
args = []string{}
} else {
args = []string{"--purge"}
}
deletionFlags := st.appendConnectionFlags(args, release)
if err := helm.DeleteRelease(context, release.Name, deletionFlags...); err != nil { if err := helm.DeleteRelease(context, release.Name, deletionFlags...); err != nil {
affectedReleases.Failed = append(affectedReleases.Failed, release) affectedReleases.Failed = append(affectedReleases.Failed, release)
relErr = newReleaseError(release, err) relErr = newReleaseError(release, err)