From fdca10678bb388b9b88386a54af4d4512ec11392 Mon Sep 17 00:00:00 2001 From: KUOKA Yusuke Date: Thu, 10 Oct 2019 16:54:15 +0900 Subject: [PATCH] fix(helm3): `Error: unknown flag: --purge` on deletion via `helmfile sync` (#890) Fixes #888 --- pkg/state/state.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/pkg/state/state.go b/pkg/state/state.go index bb3128f1..79e087d6 100644 --- a/pkg/state/state.go +++ b/pkg/state/state.go @@ -434,7 +434,13 @@ func (st *HelmState) SyncReleases(affectedReleases *AffectedReleases, helm helme if err != nil { relErr = newReleaseError(release, err) } else if installed { - deletionFlags := st.appendConnectionFlags([]string{"--purge"}, release) + var args []string + if isHelm3() { + args = []string{} + } else { + args = []string{"--purge"} + } + deletionFlags := st.appendConnectionFlags(args, release) if err := helm.DeleteRelease(context, release.Name, deletionFlags...); err != nil { affectedReleases.Failed = append(affectedReleases.Failed, release) relErr = newReleaseError(release, err)