public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: Make logging on unmatched selectors less verbose 

Fixes #200
This commit is contained in:
Yusuke KUOKA 2018-08-22 18:57:01 +09:00
parent d609dab848
commit fcb75fa851
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
state/state.go
View File

@ -607,7 +607,8 @@ func (state *HelmState) FilterReleases(labels []string) error {
filteredReleases = append(filteredReleases, r) filteredReleases = append(filteredReleases, r)
} }
if len(filteredReleases) == 0 { if len(filteredReleases) == 0 {
return fmt.Errorf("specified selector did not match any releases in %s\n", state.file) state.logger.Debugf("specified selector did not match any releases in %s\n", state.file)
return nil
} }
state.Releases = filteredReleases state.Releases = filteredReleases
return nil return nil

5
state/state_test.go
View File

@ -861,18 +861,19 @@ func TestHelmState_NoReleaseMatched(t *testing.T) {
{ {
name: "name does not exist", name: "name does not exist",
labels: "name=releaseB", labels: "name=releaseB",
wantErr: true, wantErr: false,
}, },
{ {
name: "label does not match anything", name: "label does not match anything",
labels: "foo=notbar", labels: "foo=notbar",
wantErr: true, wantErr: false,
}, },
} }
for _, tt := range tests { for _, tt := range tests {
i := func(t *testing.T) { i := func(t *testing.T) {
state := &HelmState{ state := &HelmState{
Releases: releases, Releases: releases,
logger: logger,
} }
errs := state.FilterReleases([]string{tt.labels}) errs := state.FilterReleases([]string{tt.labels})
if (errs != nil) != tt.wantErr { if (errs != nil) != tt.wantErr {