fix: eliminate race condition in rewriteChartDependencies (#2541)

* fix: eliminate race condition in rewriteChartDependencies by copying chart before modifying

Instead of modifying the original Chart.yaml in-place (which causes race
conditions when multiple releases reference the same local chart), copy the
chart to a temporary directory and rewrite the copy's dependencies. This
eliminates the need for per-chart mutex locks and prevents file corruption
when concurrent goroutines process releases sharing the same local chart.

Fixes #2502

Signed-off-by: yxxhero <aiopsclub@163.com>

* fix: address PR review comments for rewriteChartDependencies

- Handle non-NotExist errors from st.fs.Stat to surface permission/IO failures
- Reword function doc to clarify temp copy is conditional on rewrite being needed
- Assert rewrittenPath vs tempDir based on expectModified in test table

Signed-off-by: yxxhero <aiopsclub@163.com>

* test: add integration test for issue #2502 race condition with shared local chart

Signed-off-by: yxxhero <aiopsclub@163.com>

* fix: separate environments and releases with --- in helmfile.yaml

Signed-off-by: yxxhero <aiopsclub@163.com>

* fix: correct file:// path and remove --skip-deps for dependency build

Signed-off-by: yxxhero <aiopsclub@163.com>

* fix: correct file:// dependency path (5 levels up to test/integration/)

Signed-off-by: yxxhero <aiopsclub@163.com>

* fix: remove output validation from race condition test

Signed-off-by: yxxhero <aiopsclub@163.com>

* fix: assert WriteFile/MkdirTemp/RemoveAll/CopyDir in DefaultFileSystem test

Signed-off-by: yxxhero <aiopsclub@163.com>

* fix: add strategicMergePatches to trigger chartify in race condition test

Signed-off-by: yxxhero <aiopsclub@163.com>

* fix: scope test values under raw subchart and align ConfigMap name with strategic merge patches

The race condition test values.yaml had templates at the top level instead
of scoped under the raw subchart key, causing helm template to produce no
output and chartify's ReplaceWithRendered to fail with an empty
helmx.1.rendered directory. Also align the ConfigMap name to match the
strategicMergePatches target.

Signed-off-by: yxxhero <aiopsclub@163.com>

---------

Signed-off-by: yxxhero <aiopsclub@163.com>

pkg/filesystem/fs.go

@@ -27,7 +27,10 @@ func (fs fileStat) Sys() any           { return nil }
 type FileSystem struct {
 	ReadFile          func(string) ([]byte, error)
 	ReadDir           func(string) ([]fs.DirEntry, error)
+	WriteFile         func(string, []byte, fs.FileMode) error
 	DeleteFile        func(string) error
+	MkdirTemp         func(string, string) (string, error)
+	RemoveAll         func(string) error
 	FileExists        func(string) (bool, error)
 	Glob              func(string) ([]string, error)
 	FileExistsAt      func(string) bool
@@ -44,7 +47,10 @@ type FileSystem struct {
 func DefaultFileSystem() *FileSystem {
 	dfs := FileSystem{
 		ReadDir:      os.ReadDir,
+		WriteFile:    os.WriteFile,
 		DeleteFile:   os.Remove,
+		MkdirTemp:    os.MkdirTemp,
+		RemoveAll:    os.RemoveAll,
 		Glob:         filepath.Glob,
 		Getwd:        os.Getwd,
 		Chdir:        os.Chdir,
@@ -107,6 +113,15 @@ func FromFileSystem(params FileSystem) *FileSystem {
 	if params.CopyDir != nil {
 		dfs.CopyDir = params.CopyDir
 	}
+	if params.WriteFile != nil {
+		dfs.WriteFile = params.WriteFile
+	}
+	if params.MkdirTemp != nil {
+		dfs.MkdirTemp = params.MkdirTemp
+	}
+	if params.RemoveAll != nil {
+		dfs.RemoveAll = params.RemoveAll
+	}
 	return dfs
 }
 

pkg/filesystem/fs_test.go

@@ -252,4 +252,8 @@ func TestFs_DefaultBuilder(t *testing.T) {
 	assert.NotNil(t, ffs.Chdir)
 	assert.NotNil(t, ffs.Abs)
 	assert.NotNil(t, ffs.EvalSymlinks)
+	assert.NotNil(t, ffs.WriteFile)
+	assert.NotNil(t, ffs.MkdirTemp)
+	assert.NotNil(t, ffs.RemoveAll)
+	assert.NotNil(t, ffs.CopyDir)
 }