public_git/helmfile
1
0
Fork 0
mirror of https://github.com/helmfile/helmfile.git synced 2026-10-19 11:07:24 +02:00
Code Issues Projects Releases Wiki Activity

fix: log should show only releases matching selector, not including needs

Browse Source 
Signed-off-by: yxxhero <aiopsclub@163.com>
This commit is contained in:
yxxhero
2026-03-18 08:25:32 +08:00
committed by yxxhero
parent 03e7338eae
commit f2702416ae
11 changed files with 360 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/app/app.go
+5 -1
View File
@@ -1597,7 +1597,11 @@ func (a *App) getSelectedReleases(r *Run, includeNeeds bool, includeTransitiveNe
extra = " matching " + strings.Join(r.state.Selectors, ",")
}
a.Logger.Debugf("%d release(s)%s found in %s\n", len(selected), extra, r.state.FilePath)
matchedOnly, err := r.state.GetSelectedReleases(false, false)
if err != nil {
return nil, nil, err
}
a.Logger.Debugf("%d release(s)%s found in %s\n", len(matchedOnly), extra, r.state.FilePath)
return selected, deduplicated, nil
}
pkg/app/testdata/testapply_2/include-transitive-needs=true/log
Vendored
+1 -1
View File
@@ -22,7 +22,7 @@ rendering result of "helmfile.yaml.gotmpl.part.0":
19:
merged environment: &{default map[] map[] map[]}
3 release(s) matching name=serviceA found in helmfile.yaml.gotmpl
1 release(s) matching name=serviceA found in helmfile.yaml.gotmpl
Affected releases are:
serviceA (my/chart) UPDATED
pkg/app/testdata/testapply_2/skip-needs=false_include-needs=true/log
Vendored
+1 -1
View File
@@ -26,7 +26,7 @@ rendering result of "helmfile.yaml.gotmpl.part.0":
23:
merged environment: &{default map[] map[] map[]}
3 release(s) matching app=test found in helmfile.yaml.gotmpl
2 release(s) matching app=test found in helmfile.yaml.gotmpl
Affected releases are:
external-secrets (incubator/raw) UPDATED
pkg/app/testdata/testapply_2/skip-needs=false_include-needs=true_but_no_diff_on_needed_release/log
Vendored
+1 -1
View File
@@ -26,7 +26,7 @@ rendering result of "helmfile.yaml.gotmpl.part.0":
23:
merged environment: &{default map[] map[] map[]}
3 release(s) matching app=test found in helmfile.yaml.gotmpl
2 release(s) matching app=test found in helmfile.yaml.gotmpl
Affected releases are:
external-secrets (incubator/raw) UPDATED
pkg/app/testdata/testapply_2/skip-needs=false_include-needs=true_with_installed_but_disabled_release/log
Vendored
+1 -1
View File
@@ -28,7 +28,7 @@ rendering result of "helmfile.yaml.gotmpl.part.0":
merged environment: &{default map[] map[] map[]}
WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
3 release(s) matching app=test found in helmfile.yaml.gotmpl
2 release(s) matching app=test found in helmfile.yaml.gotmpl
WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
Affected releases are:
pkg/app/testdata/testapply_2/skip-needs=false_include-needs=true_with_not_installed_and_disabled_release/log
Vendored
+1 -1
View File
@@ -28,7 +28,7 @@ rendering result of "helmfile.yaml.gotmpl.part.0":
merged environment: &{default map[] map[] map[]}
WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
3 release(s) matching app=test found in helmfile.yaml.gotmpl
2 release(s) matching app=test found in helmfile.yaml.gotmpl
WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
Affected releases are:
pkg/app/testdata/testapply_3/skip-needs=false_include-needs=true/log
Vendored
+1 -1
View File
@@ -26,7 +26,7 @@ rendering result of "helmfile.yaml.gotmpl.part.0":
23:
merged environment: &{default map[] map[] map[]}
3 release(s) matching app=test found in helmfile.yaml.gotmpl
2 release(s) matching app=test found in helmfile.yaml.gotmpl
Affected releases are:
external-secrets (incubator/raw) UPDATED
pkg/app/testdata/testapply_3/skip-needs=false_include-needs=true_but_no_diff_on_needed_release/log
Vendored
+1 -1
View File
@@ -26,7 +26,7 @@ rendering result of "helmfile.yaml.gotmpl.part.0":
23:
merged environment: &{default map[] map[] map[]}
3 release(s) matching app=test found in helmfile.yaml.gotmpl
2 release(s) matching app=test found in helmfile.yaml.gotmpl
Affected releases are:
external-secrets (incubator/raw) UPDATED
pkg/app/testdata/testapply_3/skip-needs=false_include-needs=true_with_installed_but_disabled_release/log
Vendored
+1 -1
View File
@@ -28,7 +28,7 @@ rendering result of "helmfile.yaml.gotmpl.part.0":
merged environment: &{default map[] map[] map[]}
WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
3 release(s) matching app=test found in helmfile.yaml.gotmpl
2 release(s) matching app=test found in helmfile.yaml.gotmpl
WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
Affected releases are:
pkg/app/testdata/testapply_3/skip-needs=false_include-needs=true_with_not_installed_and_disabled_release/log
Vendored
+1 -1
View File
@@ -28,7 +28,7 @@ rendering result of "helmfile.yaml.gotmpl.part.0":
merged environment: &{default map[] map[] map[]}
WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
3 release(s) matching app=test found in helmfile.yaml.gotmpl
2 release(s) matching app=test found in helmfile.yaml.gotmpl
WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
Affected releases are: