mirror of
https://github.com/helmfile/helmfile.git
synced 2026-10-18 15:27:03 +02:00
Use helm show chart to identify chart version
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
This commit is contained in:
+6
-3
@@ -867,7 +867,7 @@ func (st *HelmState) SyncReleases(affectedReleases *AffectedReleases, helm helme
|
||||
m.Unlock()
|
||||
installedVersion, err := st.getDeployedVersion(context, helm, release)
|
||||
if err != nil { // err is not really impacting so just log it
|
||||
st.logger.Debugf("getting deployed release version failed:%v", err)
|
||||
st.logger.Debugf("getting deployed release version failed: %v", err)
|
||||
} else {
|
||||
release.installedVersion = installedVersion
|
||||
}
|
||||
@@ -938,8 +938,11 @@ func (st *HelmState) getDeployedVersion(context helmexec.HelmContext, helm helme
|
||||
if len(versions) > 0 {
|
||||
return versions[1], nil
|
||||
} else {
|
||||
//fails to find the version
|
||||
return "failed to get version", errors.New("Failed to get the version for:" + chartName)
|
||||
chartMetadata, err := helm.ShowChart(release.Chart)
|
||||
if err != nil {
|
||||
return "failed to get version", errors.New("Failed to get the version for: " + chartName)
|
||||
}
|
||||
return chartMetadata.Version, nil
|
||||
}
|
||||
} else {
|
||||
return "failed to get version", err
|
||||
|
||||
@@ -1455,6 +1455,16 @@ func TestGetDeployedVersion(t *testing.T) {
|
||||
foo-bar-release 1 Wed Apr 17 17:39:04 2019 DEPLOYED foo-bar-1.0.0-alpha+001 0.1.0 default`,
|
||||
installedVersion: "1.0.0-alpha+001",
|
||||
},
|
||||
{
|
||||
name: "chart version from helm show chart",
|
||||
release: ReleaseSpec{
|
||||
Name: "foo",
|
||||
Chart: "../../foo-bar",
|
||||
},
|
||||
listResult: `NAME REVISION UPDATED STATUS CHART APP VERSION NAMESPACE
|
||||
foo 1 Wed Apr 17 17:39:04 2019 DEPLOYED foo-bar 0.1.0 default`,
|
||||
installedVersion: "3.2.0",
|
||||
},
|
||||
}
|
||||
for i := range tests {
|
||||
tt := tests[i]
|
||||
@@ -1467,6 +1477,7 @@ func TestGetDeployedVersion(t *testing.T) {
|
||||
valsRuntime: valsRuntime,
|
||||
RenderedValues: map[string]interface{}{},
|
||||
}
|
||||
|
||||
helm := &exectest.Helm{
|
||||
Lists: map[exectest.ListKey]string{},
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user