From ec87a39015ded163d10d83008e2863752b45ebf6 Mon Sep 17 00:00:00 2001 From: KUOKA Yusuke Date: Thu, 13 Aug 2020 10:10:30 +0900 Subject: [PATCH] Revert filtering on repositories to be updated (#1412) This reverts a part of #1383 so that repository updates are done in the pre-0.125.0 way, which tries to update any repositories only once regardless of they are referenced by selected releases or not. Ref #1404 --- pkg/app/app_test.go | 1 + pkg/state/state.go | 7 +------ 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/pkg/app/app_test.go b/pkg/app/app_test.go index 9792cac3..4568d6d3 100644 --- a/pkg/app/app_test.go +++ b/pkg/app/app_test.go @@ -2490,6 +2490,7 @@ releases: var wantRepos = []mockRepo{ {Name: "stable"}, + {Name: "stable2"}, } var buffer bytes.Buffer diff --git a/pkg/state/state.go b/pkg/state/state.go index 04126cab..0a4c480f 100644 --- a/pkg/state/state.go +++ b/pkg/state/state.go @@ -330,15 +330,10 @@ func (st *HelmState) getRepositoriesToSync() (map[string]bool, error) { } func (st *HelmState) SyncRepos(helm RepoUpdater, shouldSkip map[string]bool) ([]string, error) { - shouldUpdate, err := st.getRepositoriesToSync() - if err != nil { - return nil, err - } - var updated []string for _, repo := range st.Repositories { - if !shouldUpdate[repo.Name] || shouldSkip[repo.Name] { + if shouldSkip[repo.Name] { continue }