From ec3a9eb8c659dbc25db4a644ab83107e675e9d09 Mon Sep 17 00:00:00 2001 From: yxxhero Date: Sat, 15 Feb 2025 12:05:22 +0800 Subject: [PATCH] refactor(state): optimize HelmState flags handling Signed-off-by: yxxhero --- pkg/state/state.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pkg/state/state.go b/pkg/state/state.go index b2d9b74b..22f619c3 100644 --- a/pkg/state/state.go +++ b/pkg/state/state.go @@ -2824,22 +2824,24 @@ func (st *HelmState) flagsForTemplate(helm helmexec.Interface, release *ReleaseS flags = st.appendChartVersionFlags(flags, release) flags = st.appendHelmXFlags(flags, release) - postRenderer := "" var postRendererArgs []string - kubeVersion := "" var showOnly []string + postRenderer := "" + kubeVersion := "" + skipSchemaValidation := false if opt != nil { postRenderer = opt.PostRenderer postRendererArgs = opt.PostRendererArgs kubeVersion = opt.KubeVersion showOnly = opt.ShowOnly + skipSchemaValidation = opt.SkipSchemaValidation } flags = st.appendPostRenderFlags(flags, release, postRenderer) flags = st.appendPostRenderArgsFlags(flags, release, postRendererArgs) flags = st.appendApiVersionsFlags(flags, release, kubeVersion) flags = st.appendChartDownloadFlags(flags, release) flags = st.appendShowOnlyFlags(flags, showOnly) - flags = st.appendSkipSchemaValidationFlags(flags, release, opt.SkipSchemaValidation) + flags = st.appendSkipSchemaValidationFlags(flags, release, skipSchemaValidation) common, files, err := st.namespaceAndValuesFlags(helm, release, workerIndex) if err != nil {